[Buildroot] [git commit] package/nettle: add missing dependency on host-m4

[Buildroot] [git commit] package/nettle: add missing dependency on host-m4

[Thomas Petazzoni via buildroot]

commit: https://git.buildroot.net/buildroot/commit/?id=d4ca1b03c0d6f34d10d10cab06ca28c24a7d296d
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master

nettle uses m4 during its build process. Without it, the build fails
with:

m4 ./m4-utils.m4 ./asm.m4 config.m4 machine.m4 aes-decrypt-internal.asm >aes-decrypt-internal.s
/bin/sh: 1: m4: not found

For the target package this is not visible, as the existing gmp
dependency pulls in host-m4. But technically speaking, nettle needs
host-m4 directly, so it makes sense to have this dependency.

For the host package, it clearly fails to build, but probably isn't
very visible as most systems have m4 installed system-wide: this was
noticed when building inside Buildroot's minimal Docker
container. There are no recorded autobuilder failures for this issue.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
 package/nettle/nettle.mk | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/package/nettle/nettle.mk b/package/nettle/nettle.mk
index d1987d427f..04e3adb84e 100644
--- a/package/nettle/nettle.mk
+++ b/package/nettle/nettle.mk
@@ -6,7 +6,7 @@
 
 NETTLE_VERSION = 3.9.1
 NETTLE_SITE = https://ftp.gnu.org/gnu/nettle
-NETTLE_DEPENDENCIES = gmp
+NETTLE_DEPENDENCIES = host-m4 gmp
 NETTLE_INSTALL_STAGING = YES
 NETTLE_LICENSE = Dual GPL-2.0+/LGPL-3.0+
 NETTLE_LICENSE_FILES = COPYING.LESSERv3 COPYINGv2
@@ -15,6 +15,8 @@ NETTLE_CPE_ID_VENDOR = nettle_project
 # with static linking
 NETTLE_CONF_OPTS = --disable-openssl
 
+HOST_NETTLE_DEPENDENCIES = host-m4
+
 # ARM assembly requires v6+ ISA
 ifeq ($(BR2_ARM_CPU_ARMV4)$(BR2_ARM_CPU_ARMV5)$(BR2_ARM_CPU_ARMV7M),y)
 NETTLE_CONF_OPTS += --disable-assembler
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [git commit] package/nettle: add missing dependency on host-m4

[Peter Korsgaard]

>>>>> "Thomas" == Thomas Petazzoni via buildroot <buildroot@buildroot.org> writes:

 > commit: https://git.buildroot.net/buildroot/commit/?id=d4ca1b03c0d6f34d10d10cab06ca28c24a7d296d
 > branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master

 > nettle uses m4 during its build process. Without it, the build fails
 > with:

 > m4 ./m4-utils.m4 ./asm.m4 config.m4 machine.m4 aes-decrypt-internal.asm >aes-decrypt-internal.s
 > /bin/sh: 1: m4: not found

 > For the target package this is not visible, as the existing gmp
 > dependency pulls in host-m4. But technically speaking, nettle needs
 > host-m4 directly, so it makes sense to have this dependency.

 > For the host package, it clearly fails to build, but probably isn't
 > very visible as most systems have m4 installed system-wide: this was
 > noticed when building inside Buildroot's minimal Docker
 > container. There are no recorded autobuilder failures for this issue.

 > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Committed to 2023.02.x and 2023.08.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot