* [Buildroot] [PATCH] package/iputils: use relative symlink for ping6
@ 2020-01-10 7:33 Peter Korsgaard
2020-01-10 7:55 ` Petr Vorel
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Peter Korsgaard @ 2020-01-10 7:33 UTC (permalink / raw)
To: buildroot
Fixes (part of):
http://autobuild.buildroot.net/results/5659e1c91831921bd9ad6af670258783771b4dc8/
Commit 6b37dda2a972cdf (package/iputils: create ping6 symlink), added a
ping6 symlink, but used the absolute (build) path to ping as the target,
which is naturally no good at runtime:
ls -l target/bin/ping6
lrwxrwxrwx 1 peko peko 58 Jan 10 08:25 target/bin/ping6 -> /home/peko/source/buildroot/output-iputils/target/bin/ping
Instead use a relative symlink.
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
package/iputils/iputils.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/iputils/iputils.mk b/package/iputils/iputils.mk
index 5b20d4f99e..0d260891e2 100644
--- a/package/iputils/iputils.mk
+++ b/package/iputils/iputils.mk
@@ -88,7 +88,7 @@ IPUTILS_POST_INSTALL_TARGET_HOOKS += IPUTILS_MOVE_BINARIES
# upstream requires distros to create symlink
define IPUTILS_CREATE_PING6_SYMLINK
- ln -sf $(TARGET_DIR)/bin/ping $(TARGET_DIR)/bin/ping6
+ ln -sf ping $(TARGET_DIR)/bin/ping6
endef
IPUTILS_POST_INSTALL_TARGET_HOOKS += IPUTILS_CREATE_PING6_SYMLINK
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [Buildroot] [PATCH] package/iputils: use relative symlink for ping6
2020-01-10 7:33 [Buildroot] [PATCH] package/iputils: use relative symlink for ping6 Peter Korsgaard
@ 2020-01-10 7:55 ` Petr Vorel
2020-01-10 8:33 ` Peter Korsgaard
2020-01-10 20:18 ` Peter Korsgaard
2 siblings, 0 replies; 4+ messages in thread
From: Petr Vorel @ 2020-01-10 7:55 UTC (permalink / raw)
To: buildroot
Hi Peter,
> Fixes (part of):
> http://autobuild.buildroot.net/results/5659e1c91831921bd9ad6af670258783771b4dc8/
> Commit 6b37dda2a972cdf (package/iputils: create ping6 symlink), added a
> ping6 symlink, but used the absolute (build) path to ping as the target,
> which is naturally no good at runtime:
> ls -l target/bin/ping6
> lrwxrwxrwx 1 peko peko 58 Jan 10 08:25 target/bin/ping6 -> /home/peko/source/buildroot/output-iputils/target/bin/ping
> Instead use a relative symlink.
Thanks for a fix.
Reviewed-by: Petr Vorel <petr.vorel@gmail.com>
Kind regards,
Petr
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] package/iputils: use relative symlink for ping6
2020-01-10 7:33 [Buildroot] [PATCH] package/iputils: use relative symlink for ping6 Peter Korsgaard
2020-01-10 7:55 ` Petr Vorel
@ 2020-01-10 8:33 ` Peter Korsgaard
2020-01-10 20:18 ` Peter Korsgaard
2 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2020-01-10 8:33 UTC (permalink / raw)
To: buildroot
>>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes:
> Fixes (part of):
> http://autobuild.buildroot.net/results/5659e1c91831921bd9ad6af670258783771b4dc8/
> Commit 6b37dda2a972cdf (package/iputils: create ping6 symlink), added a
> ping6 symlink, but used the absolute (build) path to ping as the target,
> which is naturally no good at runtime:
> ls -l target/bin/ping6
> lrwxrwxrwx 1 peko peko 58 Jan 10 08:25 target/bin/ping6 -> /home/peko/source/buildroot/output-iputils/target/bin/ping
> Instead use a relative symlink.
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] package/iputils: use relative symlink for ping6
2020-01-10 7:33 [Buildroot] [PATCH] package/iputils: use relative symlink for ping6 Peter Korsgaard
2020-01-10 7:55 ` Petr Vorel
2020-01-10 8:33 ` Peter Korsgaard
@ 2020-01-10 20:18 ` Peter Korsgaard
2 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2020-01-10 20:18 UTC (permalink / raw)
To: buildroot
>>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes:
> Fixes (part of):
> http://autobuild.buildroot.net/results/5659e1c91831921bd9ad6af670258783771b4dc8/
> Commit 6b37dda2a972cdf (package/iputils: create ping6 symlink), added a
> ping6 symlink, but used the absolute (build) path to ping as the target,
> which is naturally no good at runtime:
> ls -l target/bin/ping6
> lrwxrwxrwx 1 peko peko 58 Jan 10 08:25 target/bin/ping6 -> /home/peko/source/buildroot/output-iputils/target/bin/ping
> Instead use a relative symlink.
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Committed to 2019.11.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-01-10 20:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-01-10 7:33 [Buildroot] [PATCH] package/iputils: use relative symlink for ping6 Peter Korsgaard
2020-01-10 7:55 ` Petr Vorel
2020-01-10 8:33 ` Peter Korsgaard
2020-01-10 20:18 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox