* [Buildroot] [PATCH] package/mender: fixing init script naming
@ 2019-02-05 14:16 Angelo Compagnucci
2019-02-05 14:26 ` Peter Korsgaard
0 siblings, 1 reply; 4+ messages in thread
From: Angelo Compagnucci @ 2019-02-05 14:16 UTC (permalink / raw)
To: buildroot
The installed systemv script should be name S42mender and not S04mender.
Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
---
package/mender/mender.mk | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/package/mender/mender.mk b/package/mender/mender.mk
index 0d71938..ae5bcb8 100644
--- a/package/mender/mender.mk
+++ b/package/mender/mender.mk
@@ -70,8 +70,8 @@ define MENDER_INSTALL_INIT_SYSTEMD
endef
define MENDER_INSTALL_INIT_SYSV
- $(INSTALL) -D -m 755 package/mender/S04mender \
- $(TARGET_DIR)/etc/init.d/S04mender
+ $(INSTALL) -D -m 755 package/mender/S42mender \
+ $(TARGET_DIR)/etc/init.d/S42mender
endef
$(eval $(golang-package))
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] package/mender: fixing init script naming
2019-02-05 14:16 [Buildroot] [PATCH] package/mender: fixing init script naming Angelo Compagnucci
@ 2019-02-05 14:26 ` Peter Korsgaard
2019-02-05 14:28 ` Angelo Compagnucci
0 siblings, 1 reply; 4+ messages in thread
From: Peter Korsgaard @ 2019-02-05 14:26 UTC (permalink / raw)
To: buildroot
>>>>> "Angelo" == Angelo Compagnucci <angelo@amarulasolutions.com> writes:
> The installed systemv script should be name S42mender and not S04mender.
You forgot to explain _WHY_, E.G. that mender needs the network to be up
before it starts (presumably?)
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] package/mender: fixing init script naming
2019-02-05 14:26 ` Peter Korsgaard
@ 2019-02-05 14:28 ` Angelo Compagnucci
2019-02-05 14:36 ` Peter Korsgaard
0 siblings, 1 reply; 4+ messages in thread
From: Angelo Compagnucci @ 2019-02-05 14:28 UTC (permalink / raw)
To: buildroot
On Tue, Feb 5, 2019 at 3:26 PM Peter Korsgaard <peter@korsgaard.com> wrote:
>
> >>>>> "Angelo" == Angelo Compagnucci <angelo@amarulasolutions.com> writes:
>
> > The installed systemv script should be name S42mender and not S04mender.
>
> You forgot to explain _WHY_, E.G. that mender needs the network to be up
> before it starts (presumably?)
It's simply a bug, the init script is already named that way!
>
> --
> Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] package/mender: fixing init script naming
2019-02-05 14:28 ` Angelo Compagnucci
@ 2019-02-05 14:36 ` Peter Korsgaard
0 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2019-02-05 14:36 UTC (permalink / raw)
To: buildroot
>>>>> "Angelo" == Angelo Compagnucci <angelo@amarulasolutions.com> writes:
> On Tue, Feb 5, 2019 at 3:26 PM Peter Korsgaard <peter@korsgaard.com> wrote:
>>
>> >>>>> "Angelo" == Angelo Compagnucci <angelo@amarulasolutions.com> writes:
>>
>> > The installed systemv script should be name S42mender and not S04mender.
>>
>> You forgot to explain _WHY_, E.G. that mender needs the network to be up
>> before it starts (presumably?)
> It's simply a bug, the init script is already named that way!
Ahh, ok - That wasn't clear from the description. Committed with the
commit log tweaked, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-02-05 14:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-05 14:16 [Buildroot] [PATCH] package/mender: fixing init script naming Angelo Compagnucci
2019-02-05 14:26 ` Peter Korsgaard
2019-02-05 14:28 ` Angelo Compagnucci
2019-02-05 14:36 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox