Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [git commit] package/xterm: Avoid freetype2 path poisoning using imake
@ 2018-03-31 20:56 Thomas Petazzoni
  2018-04-08 15:06 ` Peter Korsgaard
  0 siblings, 1 reply; 2+ messages in thread
From: Thomas Petazzoni @ 2018-03-31 20:56 UTC (permalink / raw)
  To: buildroot

commit: https://git.buildroot.net/buildroot/commit/?id=6d0316dc7b14f6cd2d44e92c6ab581a6ab385234
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master

When imake is installed on the host, it tries to include
freetype headers from host, so we must override ac_cv_path_IMAKE
to avoid this.

Extract from config.log:

configure:14803: checking if we should use imake to help
configure:14820: result: yes
configure:14829: checking for xmkmf
configure:14846: found /usr/bin/xmkmf
configure:14857: result: /usr/bin/xmkmf
configure:14920: testing Using /usr/bin/xmkmf  ...
configure:15015: testing IMAKE_CFLAGS  -I. -I/usr/include/freetype2

Signed-off-by: Valentin Korenblit <valentin.korenblit@smile.fr>
[Thomas: pass ac_cv_path_IMAKE="" as suggested by Romain Naour.]
Reviewed-by: Romain Naour <romain.naour@smile.fr>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
 package/xterm/xterm.mk | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/package/xterm/xterm.mk b/package/xterm/xterm.mk
index 645de92e22..201280fd46 100644
--- a/package/xterm/xterm.mk
+++ b/package/xterm/xterm.mk
@@ -14,6 +14,9 @@ XTERM_CONF_OPTS = --enable-256-color \
 	--x-includes=$(STAGING_DIR)/usr/include \
 	--x-libraries=$(STAGING_DIR)/usr/lib
 
+# Avoid freetype2 path poisoning by imake
+XTERM_CONF_ENV = ac_cv_path_IMAKE=""
+
 ifeq ($(BR2_PACKAGE_XLIB_LIBXFT),y)
 XTERM_DEPENDENCIES += xlib_libXft
 XTERM_CONF_OPTS += --enable-freetype \

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Buildroot] [git commit] package/xterm: Avoid freetype2 path poisoning using imake
  2018-03-31 20:56 [Buildroot] [git commit] package/xterm: Avoid freetype2 path poisoning using imake Thomas Petazzoni
@ 2018-04-08 15:06 ` Peter Korsgaard
  0 siblings, 0 replies; 2+ messages in thread
From: Peter Korsgaard @ 2018-04-08 15:06 UTC (permalink / raw)
  To: buildroot

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:

 > commit: https://git.buildroot.net/buildroot/commit/?id=6d0316dc7b14f6cd2d44e92c6ab581a6ab385234
 > branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master

 > When imake is installed on the host, it tries to include
 > freetype headers from host, so we must override ac_cv_path_IMAKE
 > to avoid this.

 > Extract from config.log:

 > configure:14803: checking if we should use imake to help
 > configure:14820: result: yes
 > configure:14829: checking for xmkmf
 > configure:14846: found /usr/bin/xmkmf
 > configure:14857: result: /usr/bin/xmkmf
 > configure:14920: testing Using /usr/bin/xmkmf  ...
 > configure:15015: testing IMAKE_CFLAGS  -I. -I/usr/include/freetype2

 > Signed-off-by: Valentin Korenblit <valentin.korenblit@smile.fr>
 > [Thomas: pass ac_cv_path_IMAKE="" as suggested by Romain Naour.]
 > Reviewed-by: Romain Naour <romain.naour@smile.fr>
 > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Committed to 2018.02.x, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-04-08 15:06 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-31 20:56 [Buildroot] [git commit] package/xterm: Avoid freetype2 path poisoning using imake Thomas Petazzoni
2018-04-08 15:06 ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox