Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [v1 1/1] uboot: Add local directory option to menuconfig
Date: Mon, 27 Jun 2016 23:44:22 +0200	[thread overview]
Message-ID: <87twgepart.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20160627205746.GC3714@free.fr> (Yann E. MORIN's message of "Mon,  27 Jun 2016 22:57:46 +0200")

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > Adam, All,
 > (Peter, Thomas, Arnout: questions for you, below.)

 > On 2016-06-26 22:25 -0400, Adam Duskett spake thusly:
 >> Just like the kernel menuconfig, this allows for a user to
 >> specify a local directory for the uboot source code.

 > I'm not sure this is a great idea... I'm not sure it was a great idea to
 > allow it for the Linux kernel either, mind you.

 > The problem with local sources is that they make the build
 > non-reproducible.

Indeed.

 >     commit 73da2ff6f718f2889e3c5024d899f8d58f502863
 >     Author: Rafal Fabich <rafal.fabich@gmail.com>
 >     Date:   Sat Feb 23 19:03:30 2013 +0100

 >         Added local directory as source of kernel code
    
 >         Add the option to use a local directory as the source for
 >         building the Linux kernel, which can be useful during
 >         kernel development.
    
 >         Signed-off-by: Rafal Fabich <rafal.fabich@gmail.com>
 >         Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
 >         Tested-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
 >         Signed-off-by: Peter Korsgaard <peter@korsgaard.com>

 > Peter, any reason that you applied this patch at the time?
 > Arnout, anything you remember for giving your ACK?

Sorry, I don't remember. Most likely because Arnout acked it. I have
never personally used this feature.

 > So, I would think that:
 >   1- we don't want this for U-Boot;
 >   2- we should drop it for Linux.

 > Peter, Thomas, Arnout: what do you think?

Ok from me unless somebody can explain a use case for it.

-- 
Venlig hilsen,
Peter Korsgaard 

  reply	other threads:[~2016-06-27 21:44 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-27  2:25 [Buildroot] [v1 1/1] uboot: Add local directory option to menuconfig Adam Duskett
2016-06-27 20:57 ` Yann E. MORIN
2016-06-27 21:44   ` Peter Korsgaard [this message]
2016-06-27 22:27   ` Arnout Vandecappelle
2016-06-27 22:39     ` Yann E. MORIN
2016-06-27 22:50       ` Arnout Vandecappelle
2016-06-28  1:36         ` aduskett at gmail.com
2016-06-28  6:23         ` Peter Korsgaard
2016-06-28 22:54           ` Arnout Vandecappelle
2016-06-29  6:44             ` Peter Korsgaard
2016-06-28  1:51   ` Adam Duskett
2016-06-28  6:14     ` Peter Korsgaard
2016-06-28 14:24       ` Thomas Petazzoni
2016-06-28 17:32         ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87twgepart.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox