Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [v1 1/1] uboot: Add local directory option to menuconfig
Date: Wed, 29 Jun 2016 08:44:28 +0200	[thread overview]
Message-ID: <87vb0sijeb.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <76677c72-574e-ea3b-230c-fd364ddea108@mind.be> (Arnout Vandecappelle's message of "Wed, 29 Jun 2016 00:54:15 +0200")

>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:

Hi,

 >> Yes, except that _CUSTOM_LOCAL ends up in the .config, so it easily gets
 >> committed to version version control, whereas you have to go out of your
 >> way to shoot yourself in the foot with _OVERRIDE_SRCDIR.

 >  Except, of course, when you really want to refer to a separately managed local
 > checkout. Though in that case putting local.mk under version control is equally
 > easy.

Exactly.

>> >  In my experience referring to tags or shas from a defconfig is really clunky,
 >> > it makes updating extremely inflexible. I've implemented scripts to automate the
 >> > tagging for some projects; in the end they didn't use it, because the submodule
 >> > tag already covers it.
 >> 
 >> What is the problem with referring to shas from the defconfig? That
 >> sounds to me to be no more work than changing the submodule version. Or
 >> are you just referring to the effort to tag the individual components
 >> for a release?

 >  To update the sha, you have to:

 > - commit in the component repo;
 > - generate a tag;

Why? You can just select the sha in the .config.

 > - update the .config;
 > - run a test build;

Or just let the continous integration system do this. That way you are
also sure it is clean build from pristine sources.


 > - make savedefconfig;
 > - git diff and check that it's OK to commit this;
 > - commit;
 > - generate a tag for integration repo;

Why the tag?

> - push both repos.

I think people would normally push the component changes earlier/more
often than the buildroot .config is changed, but ok.

 > => This really requires a script.

I don't really think so, but ok - Some might. It will end up being quite
a lot of scripts if you have many local components.


 >  While with submodules and OVERRIDE_SRCDIR, you do:

 > - run a test build;
 > - commit in the component repo;
 > - commit in the integration repo;
 > - git push --recurse-submodules

Without the tags above, this looks pretty similar to me. You don't
manually need to adjust the git hash in the .config, but you instead
gain the complications of sub modules and you basically need a buildroot
branch per project.

But anyway, both work flows are supported with override - So we're fine.

-- 
Venlig hilsen,
Peter Korsgaard 

  reply	other threads:[~2016-06-29  6:44 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-27  2:25 [Buildroot] [v1 1/1] uboot: Add local directory option to menuconfig Adam Duskett
2016-06-27 20:57 ` Yann E. MORIN
2016-06-27 21:44   ` Peter Korsgaard
2016-06-27 22:27   ` Arnout Vandecappelle
2016-06-27 22:39     ` Yann E. MORIN
2016-06-27 22:50       ` Arnout Vandecappelle
2016-06-28  1:36         ` aduskett at gmail.com
2016-06-28  6:23         ` Peter Korsgaard
2016-06-28 22:54           ` Arnout Vandecappelle
2016-06-29  6:44             ` Peter Korsgaard [this message]
2016-06-28  1:51   ` Adam Duskett
2016-06-28  6:14     ` Peter Korsgaard
2016-06-28 14:24       ` Thomas Petazzoni
2016-06-28 17:32         ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vb0sijeb.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox