* [Buildroot] [PATCH] fwup: disable documentation build
@ 2016-06-21 12:16 Baruch Siach
2016-06-21 12:37 ` Frank Hunleth
2016-06-21 14:41 ` Peter Korsgaard
0 siblings, 2 replies; 4+ messages in thread
From: Baruch Siach @ 2016-06-21 12:16 UTC (permalink / raw)
To: buildroot
Documentation build with help2man relies on the output of running 'fwup
--help'. That obviously can't work with cross compilation.
Fixes:
http://autobuild.buildroot.net/results/bdd/bdd8137973c37824f6aa9261ee307f6ed21b9166/
http://autobuild.buildroot.net/results/96a/96a53b3ec666bd09f09c8a3e5b31eff73e3dd0fa/
http://autobuild.buildroot.net/results/e0b/e0bcfaf9dd36d4992e507d18afeb1cec56048987/
Cc: Frank Hunleth <fhunleth@troodon-software.com>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
package/fwup/fwup.mk | 1 +
1 file changed, 1 insertion(+)
diff --git a/package/fwup/fwup.mk b/package/fwup/fwup.mk
index 7b007e1a9c8a..0a23856048b3 100644
--- a/package/fwup/fwup.mk
+++ b/package/fwup/fwup.mk
@@ -10,6 +10,7 @@ FWUP_LICENSE = Apache-2.0
FWUP_LICENSE_FILES = LICENSE
FWUP_DEPENDENCIES = libconfuse libarchive libsodium
FWUP_AUTORECONF = YES
+FWUP_CONF_ENV = ac_cv_path_HELP2MAN=""
$(eval $(autotools-package))
$(eval $(host-autotools-package))
--
2.8.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] fwup: disable documentation build
2016-06-21 12:16 [Buildroot] [PATCH] fwup: disable documentation build Baruch Siach
@ 2016-06-21 12:37 ` Frank Hunleth
2016-06-21 14:43 ` Peter Korsgaard
2016-06-21 14:41 ` Peter Korsgaard
1 sibling, 1 reply; 4+ messages in thread
From: Frank Hunleth @ 2016-06-21 12:37 UTC (permalink / raw)
To: buildroot
Hi Baruch,
On Tue, Jun 21, 2016 at 8:16 AM, Baruch Siach <baruch@tkos.co.il> wrote:
> Documentation build with help2man relies on the output of running 'fwup
> --help'. That obviously can't work with cross compilation.
Fwiw, there was a nearly identical patch a while ago that hasn't been
merged yet:
http://patchwork.ozlabs.org/patch/634937/
I prefer your commit comment, but I'm fine with whichever one gets
merged first. So,
Tested-by: Frank Hunleth <fhunleth@troodon-software.com>
Thanks,
Frank
>
> Fixes:
> http://autobuild.buildroot.net/results/bdd/bdd8137973c37824f6aa9261ee307f6ed21b9166/
> http://autobuild.buildroot.net/results/96a/96a53b3ec666bd09f09c8a3e5b31eff73e3dd0fa/
> http://autobuild.buildroot.net/results/e0b/e0bcfaf9dd36d4992e507d18afeb1cec56048987/
>
> Cc: Frank Hunleth <fhunleth@troodon-software.com>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> package/fwup/fwup.mk | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/package/fwup/fwup.mk b/package/fwup/fwup.mk
> index 7b007e1a9c8a..0a23856048b3 100644
> --- a/package/fwup/fwup.mk
> +++ b/package/fwup/fwup.mk
> @@ -10,6 +10,7 @@ FWUP_LICENSE = Apache-2.0
> FWUP_LICENSE_FILES = LICENSE
> FWUP_DEPENDENCIES = libconfuse libarchive libsodium
> FWUP_AUTORECONF = YES
> +FWUP_CONF_ENV = ac_cv_path_HELP2MAN=""
>
> $(eval $(autotools-package))
> $(eval $(host-autotools-package))
> --
> 2.8.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] fwup: disable documentation build
2016-06-21 12:16 [Buildroot] [PATCH] fwup: disable documentation build Baruch Siach
2016-06-21 12:37 ` Frank Hunleth
@ 2016-06-21 14:41 ` Peter Korsgaard
1 sibling, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2016-06-21 14:41 UTC (permalink / raw)
To: buildroot
>>>>> "Baruch" == Baruch Siach <baruch@tkos.co.il> writes:
> Documentation build with help2man relies on the output of running 'fwup
> --help'. That obviously can't work with cross compilation.
> Fixes:
> http://autobuild.buildroot.net/results/bdd/bdd8137973c37824f6aa9261ee307f6ed21b9166/
> http://autobuild.buildroot.net/results/96a/96a53b3ec666bd09f09c8a3e5b31eff73e3dd0fa/
> http://autobuild.buildroot.net/results/e0b/e0bcfaf9dd36d4992e507d18afeb1cec56048987/
> Cc: Frank Hunleth <fhunleth@troodon-software.com>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] fwup: disable documentation build
2016-06-21 12:37 ` Frank Hunleth
@ 2016-06-21 14:43 ` Peter Korsgaard
0 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2016-06-21 14:43 UTC (permalink / raw)
To: buildroot
>>>>> "Frank" == Frank Hunleth <fhunleth@troodon-software.com> writes:
> Hi Baruch,
> On Tue, Jun 21, 2016 at 8:16 AM, Baruch Siach <baruch@tkos.co.il> wrote:
>> Documentation build with help2man relies on the output of running 'fwup
>> --help'. That obviously can't work with cross compilation.
> Fwiw, there was a nearly identical patch a while ago that hasn't been
> merged yet:
> http://patchwork.ozlabs.org/patch/634937/
> I prefer your commit comment, but I'm fine with whichever one gets
> merged first. So,
> Tested-by: Frank Hunleth <fhunleth@troodon-software.com>
Thanks. I've committed this and marked the earlier patch as superseeded.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-06-21 14:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-21 12:16 [Buildroot] [PATCH] fwup: disable documentation build Baruch Siach
2016-06-21 12:37 ` Frank Hunleth
2016-06-21 14:43 ` Peter Korsgaard
2016-06-21 14:41 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox