Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Makefile: unbreak source-check
Date: Fri, 15 Jul 2011 20:59:04 +0200	[thread overview]
Message-ID: <87tyan8j5z.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <1310641353-7351-1-git-send-email-yann.morin.1998@anciens.enib.fr> (Yann E. MORIN's message of "Thu, 14 Jul 2011 13:02:33 +0200")

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@anciens.enib.fr> writes:

 Yann> 'source-check' breaks because the *_DEFCONFIG options are empty strings.
 Yann> There is an explicit check to avoid erroring-out when doing 'source', but
 Yann> not when doing 'source-check'.

 Yann> This patch set DL_MODE right from the first sub-make call.

Committed, thanks.
 
 Yann> -_source-check:
 Yann> -	$(MAKE) DL_MODE=SOURCE_CHECK $(EXTRAMAKEARGS) source
 Yann> -
 Yann>  external-deps:
 Yann>  	@$(MAKE) -Bs DL_MODE=SHOW_EXTERNAL_DEPS $(EXTRAMAKEARGS) source | sort -u
 
 Yann> @@ -595,7 +592,7 @@ savedefconfig: $(BUILD_DIR)/buildroot-config/conf outputmakefile
 
 Yann>  # check if download URLs are outdated
 Yann>  source-check: allyesconfig
 Yann> -	$(MAKE) $(EXTRAMAKEARGS) _source-check
 Yann> +	$(MAKE) $(EXTRAMAKEARGS) source DL_MODE=SOURCE_CHECK

trivial, but I reordered the args to match the other places ('source' at
the end).

-- 
Bye, Peter Korsgaard

      reply	other threads:[~2011-07-15 18:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-14 11:02 [Buildroot] [PATCH] Makefile: unbreak source-check Yann E. MORIN
2011-07-15 18:59 ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tyan8j5z.fsf@macbook.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox