[Buildroot] [PATCH] Makefile: unbreak source-check

[Buildroot] [PATCH] Makefile: unbreak source-check

[Yann E. MORIN]

'source-check' breaks because the *_DEFCONFIG options are empty strings.
There is an explicit check to avoid erroring-out when doing 'source', but
not when doing 'source-check'.

This patch set DL_MODE right from the first sub-make call.

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
---
 Makefile |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)

diff --git a/Makefile b/Makefile
index 2f3802c..f50457a 100644
--- a/Makefile
+++ b/Makefile
@@ -488,9 +488,6 @@ endif
 
 source: $(TARGETS_SOURCE) $(HOST_SOURCE)
 
-_source-check:
-	$(MAKE) DL_MODE=SOURCE_CHECK $(EXTRAMAKEARGS) source
-
 external-deps:
 	@$(MAKE) -Bs DL_MODE=SHOW_EXTERNAL_DEPS $(EXTRAMAKEARGS) source | sort -u
 
@@ -595,7 +592,7 @@ savedefconfig: $(BUILD_DIR)/buildroot-config/conf outputmakefile
 
 # check if download URLs are outdated
 source-check: allyesconfig
-	$(MAKE) $(EXTRAMAKEARGS) _source-check
+	$(MAKE) $(EXTRAMAKEARGS) source DL_MODE=SOURCE_CHECK
 
 endif # ifeq ($(BR2_HAVE_DOT_CONFIG),y)
 
-- 
1.7.2.5

[Buildroot] [PATCH] Makefile: unbreak source-check

[Peter Korsgaard]

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@anciens.enib.fr> writes:

 Yann> 'source-check' breaks because the *_DEFCONFIG options are empty strings.
 Yann> There is an explicit check to avoid erroring-out when doing 'source', but
 Yann> not when doing 'source-check'.

 Yann> This patch set DL_MODE right from the first sub-make call.

Committed, thanks.
 
 Yann> -_source-check:
 Yann> -	$(MAKE) DL_MODE=SOURCE_CHECK $(EXTRAMAKEARGS) source
 Yann> -
 Yann>  external-deps:
 Yann>  	@$(MAKE) -Bs DL_MODE=SHOW_EXTERNAL_DEPS $(EXTRAMAKEARGS) source | sort -u
 
 Yann> @@ -595,7 +592,7 @@ savedefconfig: $(BUILD_DIR)/buildroot-config/conf outputmakefile
 
 Yann>  # check if download URLs are outdated
 Yann>  source-check: allyesconfig
 Yann> -	$(MAKE) $(EXTRAMAKEARGS) _source-check
 Yann> +	$(MAKE) $(EXTRAMAKEARGS) source DL_MODE=SOURCE_CHECK

trivial, but I reordered the args to match the other places ('source' at
the end).

-- 
Bye, Peter Korsgaard