Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [pull request v2] Pull request for branch for-2011.02/fix-ccache-support
Date: Mon, 06 Dec 2010 16:08:17 +0100	[thread overview]
Message-ID: <87tyiruefy.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <AANLkTimzwXT4JMAv_oZxcCrRSEbGc8reZ+GfYhb8RHUZ@mail.gmail.com> ("Bjørn Forsman"'s message of "Mon, 6 Dec 2010 10:44:40 +0100")

>>>>> "Bj?rn" == Bj?rn Forsman <bjorn.forsman@gmail.com> writes:

Hi,

 Bj?rn> Actually, I am currently working on a CMAKETARGETS macro (similar to
 Bj?rn> AUTOTARGETS) and decided to write a patch that takes --sysroot out of
 Bj?rn> TARGET_CC and move it to the {C,CXX}FLAGS variables, to make CMake
 Bj?rn> happy. I've been meaning to post the patch series but I don't feel
 Bj?rn> it's ready to be merged yet. How do the Buildroot developers feel
 Bj?rn> about

 Bj?rn> a) moving --sysroot from TARGET_CC to {C,CXX}FLAGS

It afaik got moved in the first place to fix issues with external
toolchains (E.G. where sysroot is important) and various configure
scripts not using CFLAGS, so I don't think this will work.

Perhaps we should simply bite the bullet and add simple shell wrappers
in HOST_DIR / STAGING_DIR for gcc/g++/ld which add --sysroot when we're
using an external toolchain, and then get rid of --sysroot in TARGET_CC.

 Bj?rn> b) add CMAKETARGETS infrastructure

Sounds good!

 Bj?rn> If this sounds interesting I can post the patches for review.

Yes, please.

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2010-12-06 15:08 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-03 19:16 [Buildroot] [pull request v2] Pull request for branch for-2011.02/fix-ccache-support Thomas Petazzoni
2010-12-03 19:16 ` [Buildroot] [PATCH 1/1] ccache: rework ccache management Thomas Petazzoni
2010-12-05 22:47   ` Peter Korsgaard
2010-12-05 22:40 ` [Buildroot] [pull request v2] Pull request for branch for-2011.02/fix-ccache-support Peter Korsgaard
2010-12-06  9:44   ` Bjørn Forsman
2010-12-06 15:08     ` Peter Korsgaard [this message]
2010-12-06 19:24       ` Thomas Petazzoni
2010-12-06 19:22     ` Thomas Petazzoni
2010-12-07  0:04       ` Bjørn Forsman
2010-12-07 19:53         ` Thomas Petazzoni
2010-12-08 10:24           ` Bjørn Forsman
2010-12-06 23:14   ` Thomas Petazzoni
2010-12-07 12:26     ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tyiruefy.fsf@macbook.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox