Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] ccache: rework ccache management
Date: Sun, 05 Dec 2010 23:47:25 +0100	[thread overview]
Message-ID: <87zksjvnuq.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <03b95520ec943581129be4cf92a6ea70e661cf6d.1291403746.git.thomas.petazzoni@free-electrons.com> (Thomas Petazzoni's message of "Fri, 3 Dec 2010 20:16:23 +0100")

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

Hi,

 Thomas>  * ccache is now a normal package (both for the host and the target).

Besides the general comments, I have a few specific ones as well:

 Thomas> +++ b/docs/buildroot.html
 Thomas> @@ -681,6 +682,31 @@ endif
 Thomas>      Build options -&gt; Toolchain and header file location</code> options.
 Thomas>      This could be useful if the toolchain must be shared with other users.</p>
 
 Thomas> +    <h2 id="ccache-support">Using <code>ccache</code> in Buildroot</h2>
 Thomas> +
 Thomas> +    <p><a href="http://ccache.samba.org">ccache</a> is a compiler
 Thomas> +    cache. It stores the object files resulting from each compilation
 Thomas> +    process, and is able to skip future compilation of the same source
 Thomas> +    file (with same compiler and same arguments) by using the
 Thomas> +    pre-existing object files. When doing almost identical builds from
 Thomas> +    scratch a number of times, it can divide the build time by a
 Thomas> +    factor of two.</p>

The improvement depends quite a lot on the configuration / use case, so
I think we should simpluy write something like 'it can significantly
speed up the build process.' rather than specifically saying x2.

 Thomas> +++ b/package/ccache/Config.in
 Thomas> @@ -0,0 +1,5 @@
 Thomas> +config BR2_PACKAGE_CCACHE
 Thomas> +	bool "ccache"
 Thomas> +	help
 Thomas> +	  Compiler Cache
 Thomas> +	  http://samba.org/ftp/ccache
 Thomas> \ No newline at end of file

You forgot the missing newline here and for the .mk. We normally have an
empty line before the website. The official website is afaik also
http://ccache.samba.org, rather than this download URL.

Doesn't ccache need zlib?

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2010-12-05 22:47 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-03 19:16 [Buildroot] [pull request v2] Pull request for branch for-2011.02/fix-ccache-support Thomas Petazzoni
2010-12-03 19:16 ` [Buildroot] [PATCH 1/1] ccache: rework ccache management Thomas Petazzoni
2010-12-05 22:47   ` Peter Korsgaard [this message]
2010-12-05 22:40 ` [Buildroot] [pull request v2] Pull request for branch for-2011.02/fix-ccache-support Peter Korsgaard
2010-12-06  9:44   ` Bjørn Forsman
2010-12-06 15:08     ` Peter Korsgaard
2010-12-06 19:24       ` Thomas Petazzoni
2010-12-06 19:22     ` Thomas Petazzoni
2010-12-07  0:04       ` Bjørn Forsman
2010-12-07 19:53         ` Thomas Petazzoni
2010-12-08 10:24           ` Bjørn Forsman
2010-12-06 23:14   ` Thomas Petazzoni
2010-12-07 12:26     ` Peter Korsgaard
  -- strict thread matches above, loose matches on Subject: below --
2010-12-07 20:09 [Buildroot] [pull request] " Thomas Petazzoni
2010-12-07 20:09 ` [Buildroot] [PATCH 1/1] ccache: rework ccache management Thomas Petazzoni
2010-12-03 19:09 [Buildroot] [pull request] Pull request for branch for-2011.02/fix-ccache-support Thomas Petazzoni
2010-12-03 19:09 ` [Buildroot] [PATCH 1/1] ccache: rework ccache management Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zksjvnuq.fsf@macbook.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox