From: Peter Korsgaard <peter@korsgaard.com>
To: Mircea Gliga <gliga.mircea@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/2] package/Makefile.in: set GIT_DIR=. in {HOST, TARGET}_MAKE_ENV
Date: Fri, 26 Jan 2024 10:35:59 +0100 [thread overview]
Message-ID: <87v87g308w.fsf@48ers.dk> (raw)
In-Reply-To: <CAKpO6uGU7VsJ=Brc7B1m_5b1cQ9=W=cK8-sOJMU+3s=KyEbNgw@mail.gmail.com> (Mircea Gliga's message of "Fri, 26 Jan 2024 11:16:50 +0200")
>>>>> "Mircea" == Mircea Gliga <gliga.mircea@gmail.com> writes:
> Hi all,
>> In the context of Buildroot the packages are never built in their own git
>> checkout, so pass GIT_DIR=. to ensure git doesn't walk back up the
>> directory tree and finds the Buildroot git repo, which fixes the rauc (and
>> similar) issues.
>>
>> -TARGET_MAKE_ENV = PATH=$(BR_PATH)
>> +TARGET_MAKE_ENV = \
>> + GIT_DIR=. \
>> + PATH=$(BR_PATH)
>>
>> TARGET_CONFIGURE_OPTS = \
>> $(TARGET_MAKE_ENV) \
>> @@ -307,6 +309,7 @@ TARGET_CONFIGURE_OPTS = \
> This will also break the usage of package/environment-setup. The
> GIT_DIR=. leaks in
> the environment script `environment-setup` useful when a developer
> wants to use a Buildroot
> generated SDK to build an external project.
> So, on a developer machine after sourcing the environment script, all
> git commands fail:
> $ git status
> fatal: not a git repository: '.'
Thanks for the report, I've sent a fix here:
https://patchwork.ozlabs.org/project/buildroot/patch/20240126093441.2130693-1-peter@korsgaard.com/
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2024-01-26 9:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-11 10:56 [Buildroot] [PATCH 1/2] package/Makefile.in: set GIT_DIR=. in {HOST, TARGET}_MAKE_ENV Peter Korsgaard
2024-01-11 10:56 ` [Buildroot] [PATCH 2/2] package/micropython: drop GIT_DIR=. workaround Peter Korsgaard
2024-01-11 20:08 ` Yann E. MORIN
2024-01-13 20:31 ` Peter Korsgaard
2024-01-21 13:12 ` Yann E. MORIN
2024-01-21 19:29 ` Peter Korsgaard
2024-01-11 20:07 ` [Buildroot] [PATCH 1/2] package/Makefile.in: set GIT_DIR=. in {HOST, TARGET}_MAKE_ENV Yann E. MORIN
2024-01-11 21:10 ` Arnout Vandecappelle via buildroot
2024-01-12 7:14 ` Peter Korsgaard
2024-01-13 20:30 ` Peter Korsgaard
2024-01-16 15:32 ` Jan Kundrát via buildroot
2024-01-17 7:27 ` Peter Korsgaard
2024-01-18 1:56 ` Jan Kundrát via buildroot
2024-01-26 9:16 ` Mircea Gliga
2024-01-26 9:35 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v87g308w.fsf@48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
--cc=gliga.mircea@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox