From: Peter Korsgaard <peter@korsgaard.com>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Chris Packham <judge.packham@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 2/2] package/micropython: drop GIT_DIR=. workaround
Date: Sun, 21 Jan 2024 20:29:29 +0100 [thread overview]
Message-ID: <87zfwyh4di.fsf@48ers.dk> (raw)
In-Reply-To: <Za0YJSXFxMiKvO0j@landeda> (Yann E. MORIN's message of "Sun, 21 Jan 2024 14:12:05 +0100")
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
> Peter, All,
> On 2024-01-11 11:56 +0100, Peter Korsgaard spake thusly:
>> Now that it is handled globally in TARGET_MAKE_ENV.
>>
>> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
>> ---
>> package/micropython/micropython.mk | 5 -----
>> 1 file changed, 5 deletions(-)
>>
>> diff --git a/package/micropython/micropython.mk b/package/micropython/micropython.mk
>> index e6eb536ea5..3d356c51d8 100644
>> --- a/package/micropython/micropython.mk
>> +++ b/package/micropython/micropython.mk
>> @@ -14,11 +14,6 @@ MICROPYTHON_LICENSE = MIT, BSD-1-Clause, BSD-3-Clause, Zlib
>> MICROPYTHON_LICENSE_FILES = LICENSE
>> MICROPYTHON_DEPENDENCIES = host-pkgconf libffi host-python3
>>
>> -# Set GIT_DIR so package won't use buildroot's version number
>> -MICROPYTHON_MAKE_ENV = \
>> - $(TARGET_MAKE_ENV) \
>> - GIT_DIR=.
> I was way too sloppy when applying this patch: MICROPYTHON_MAKE_ENV
> previously contained $(TARGET_MAKE_ENV), but now it is totally unset,
> and the expansions of it have not been replaced with TARGET_MAKE_ENV,
> leading to all sorts of build faiulures, like:
> LINK build-standard/micropython
> arm-linux-gcc: ERROR: unsafe header/library path used in
> cross-compilation: '-L/usr/lib64/../lib64'
> I suspect it is also the issue reported by Julien in his micropython
> runtime test:
> https://patchwork.ozlabs.org/project/buildroot/patch/20240116210556.589407-1-ju.o@free.fr/
> I'll push a fixup patch that uses TARGET_MAKE_ENV
Argh, thanks! Sorry.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-01-21 20:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-11 10:56 [Buildroot] [PATCH 1/2] package/Makefile.in: set GIT_DIR=. in {HOST, TARGET}_MAKE_ENV Peter Korsgaard
2024-01-11 10:56 ` [Buildroot] [PATCH 2/2] package/micropython: drop GIT_DIR=. workaround Peter Korsgaard
2024-01-11 20:08 ` Yann E. MORIN
2024-01-13 20:31 ` Peter Korsgaard
2024-01-21 13:12 ` Yann E. MORIN
2024-01-21 19:29 ` Peter Korsgaard [this message]
2024-01-11 20:07 ` [Buildroot] [PATCH 1/2] package/Makefile.in: set GIT_DIR=. in {HOST, TARGET}_MAKE_ENV Yann E. MORIN
2024-01-11 21:10 ` Arnout Vandecappelle via buildroot
2024-01-12 7:14 ` Peter Korsgaard
2024-01-13 20:30 ` Peter Korsgaard
2024-01-16 15:32 ` Jan Kundrát via buildroot
2024-01-17 7:27 ` Peter Korsgaard
2024-01-18 1:56 ` Jan Kundrát via buildroot
2024-01-26 9:16 ` Mircea Gliga
2024-01-26 9:35 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zfwyh4di.fsf@48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
--cc=judge.packham@gmail.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox