[Buildroot] [PATCH 1/1] package/check: switch to cmake

[Buildroot] [PATCH 1/1] package/check: switch to cmake

[Bernd Kuhls]

The autoconf-build system fails to properly detect vsnprintf

    checking for vsnprintf... yes
    checking whether vsnprintf is C99 compliant... no

which leads to a build error

    snprintf.c:495:1: error: inlining failed in call to 'always_inline'
     'rpl_vsnprintf.localalias': function not inlinable

Building with cmake fixes the problem:

-- Looking for vsnprintf
-- Looking for vsnprintf - found

Fixes:
http://autobuild.buildroot.net/results/e55/e5562513226de902dae642526165b1555a540144/

Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
---
 package/check/check.mk | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/package/check/check.mk b/package/check/check.mk
index ccffd08ee3..d3977154df 100644
--- a/package/check/check.mk
+++ b/package/check/check.mk
@@ -10,12 +10,6 @@ CHECK_INSTALL_STAGING = YES
 CHECK_DEPENDENCIES = host-pkgconf
 CHECK_LICENSE = LGPL-2.1+
 CHECK_LICENSE_FILES = COPYING.LESSER
-CHECK_CONF_OPTS = --disable-build-docs
+CHECK_CONF_OPTS = -DBUILD_TESTING=OFF -DINSTALL_CHECKMK=OFF
 
-# Having checkmk in the target makes no sense
-define CHECK_REMOVE_CHECKMK
-	rm -f $(TARGET_DIR)/usr/bin/checkmk
-endef
-CHECK_POST_INSTALL_TARGET_HOOKS += CHECK_REMOVE_CHECKMK
-
-$(eval $(autotools-package))
+$(eval $(cmake-package))
-- 
2.39.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/check: switch to cmake

[Arnout Vandecappelle via buildroot]

On 19/06/2023 19:20, Bernd Kuhls wrote:
> The autoconf-build system fails to properly detect vsnprintf
> 
>      checking for vsnprintf... yes
>      checking whether vsnprintf is C99 compliant... no
> 
> which leads to a build error
> 
>      snprintf.c:495:1: error: inlining failed in call to 'always_inline'
>       'rpl_vsnprintf.localalias': function not inlinable
> 
> Building with cmake fixes the problem:
> 
> -- Looking for vsnprintf
> -- Looking for vsnprintf - found

  I also mentioned why CHECK_REMOVE_CHECKMK can be removed.

> 
> Fixes:
> http://autobuild.buildroot.net/results/e55/e5562513226de902dae642526165b1555a540144/
> 
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>

  Applied to master, thanks.

  Regards,
  Arnout

> ---
>   package/check/check.mk | 10 ++--------
>   1 file changed, 2 insertions(+), 8 deletions(-)
> 
> diff --git a/package/check/check.mk b/package/check/check.mk
> index ccffd08ee3..d3977154df 100644
> --- a/package/check/check.mk
> +++ b/package/check/check.mk
> @@ -10,12 +10,6 @@ CHECK_INSTALL_STAGING = YES
>   CHECK_DEPENDENCIES = host-pkgconf
>   CHECK_LICENSE = LGPL-2.1+
>   CHECK_LICENSE_FILES = COPYING.LESSER
> -CHECK_CONF_OPTS = --disable-build-docs
> +CHECK_CONF_OPTS = -DBUILD_TESTING=OFF -DINSTALL_CHECKMK=OFF
>   
> -# Having checkmk in the target makes no sense
> -define CHECK_REMOVE_CHECKMK
> -	rm -f $(TARGET_DIR)/usr/bin/checkmk
> -endef
> -CHECK_POST_INSTALL_TARGET_HOOKS += CHECK_REMOVE_CHECKMK
> -
> -$(eval $(autotools-package))
> +$(eval $(cmake-package))
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/check: switch to cmake

[Peter Korsgaard]

>>>>> "Bernd" == Bernd Kuhls <bernd@kuhls.net> writes:

 > The autoconf-build system fails to properly detect vsnprintf
 >     checking for vsnprintf... yes
 >     checking whether vsnprintf is C99 compliant... no

 > which leads to a build error

 >     snprintf.c:495:1: error: inlining failed in call to 'always_inline'
 >      'rpl_vsnprintf.localalias': function not inlinable

 > Building with cmake fixes the problem:

 > -- Looking for vsnprintf
 > -- Looking for vsnprintf - found

 > Fixes:
 > http://autobuild.buildroot.net/results/e55/e5562513226de902dae642526165b1555a540144/

 > Signed-off-by: Bernd Kuhls <bernd@kuhls.net>

Committed to 2023.02.x and 2023.05.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot