[Buildroot] [PATCH] package/qemu: qemu systems emulation needs fdt when building for all targets

[Buildroot] [PATCH] package/qemu: qemu systems emulation needs fdt when building for all targets

[Romain Naour]

defconfig fragment to reproduce the issue:
BR2_PACKAGE_QEMU_ARCH_SUPPORTS_TARGET=y
BR2_PACKAGE_QEMU=y
BR2_PACKAGE_QEMU_SYSTEM=y

ERROR: Problem encountered: fdt not available but required by targets
       aarch64-softmmu, arm-softmmu, i386-softmmu, loongarch64-softmmu,
       microblaze-softmmu, microblazeel-softmmu, mips64el-softmmu,
       nios2-softmmu, or1k-softmmu, ppc-softmmu, ppc64-softmmu,
       riscv32-softmmu, riscv64-softmmu, rx-softmmu, x86_64-softmmu

Commit [1] select BR2_PACKAGE_QEMU_FDT for each individual emulator targets
but forgot to select is when BR2_PACKAGE_QEMU_CHOOSE_TARGETS is not set
(building for all targets).

Fixes:
http://autobuild.buildroot.org/results/e44/e444a02b899d325a9d99daed96b8cb96108383e7

[1] 44be514b21fd94096702b80c62d46c31d72f15a5

Signed-off-by: Romain Naour <romain.naour@smile.fr>
Cc: Carlos Santos <unixmania@gmail.com>
Cc: Yann E. MORIN <yann.morin.1998@free.fr>
---
 package/qemu/Config.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/qemu/Config.in b/package/qemu/Config.in
index 91a1b288c6..6fb34a0dae 100644
--- a/package/qemu/Config.in
+++ b/package/qemu/Config.in
@@ -52,6 +52,7 @@ config BR2_PACKAGE_QEMU_SYSTEM
 	bool "Enable systems emulation"
 	depends on !BR2_STATIC_LIBS # dtc
 	select BR2_PACKAGE_PIXMAN
+	select BR2_PACKAGE_QEMU_FDT if !BR2_PACKAGE_QEMU_CHOOSE_TARGETS
 	help
 	  Say 'y' to build system emulators/virtualisers.
 
-- 
2.40.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/qemu: qemu systems emulation needs fdt when building for all targets

[Peter Korsgaard]

>>>>> "Romain" == Romain Naour <romain.naour@smile.fr> writes:

 > defconfig fragment to reproduce the issue:
 > BR2_PACKAGE_QEMU_ARCH_SUPPORTS_TARGET=y
 > BR2_PACKAGE_QEMU=y
 > BR2_PACKAGE_QEMU_SYSTEM=y

 > ERROR: Problem encountered: fdt not available but required by targets
 >        aarch64-softmmu, arm-softmmu, i386-softmmu, loongarch64-softmmu,
 >        microblaze-softmmu, microblazeel-softmmu, mips64el-softmmu,
 >        nios2-softmmu, or1k-softmmu, ppc-softmmu, ppc64-softmmu,
 >        riscv32-softmmu, riscv64-softmmu, rx-softmmu, x86_64-softmmu

 > Commit [1] select BR2_PACKAGE_QEMU_FDT for each individual emulator targets
 > but forgot to select is when BR2_PACKAGE_QEMU_CHOOSE_TARGETS is not set
 > (building for all targets).

 > Fixes:
 > http://autobuild.buildroot.org/results/e44/e444a02b899d325a9d99daed96b8cb96108383e7

 > [1] 44be514b21fd94096702b80c62d46c31d72f15a5

 > Signed-off-by: Romain Naour <romain.naour@smile.fr>
 > Cc: Carlos Santos <unixmania@gmail.com>
 > Cc: Yann E. MORIN <yann.morin.1998@free.fr>

Committed, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/qemu: qemu systems emulation needs fdt when building for all targets

[Peter Korsgaard]

>>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes:

>>>>> "Romain" == Romain Naour <romain.naour@smile.fr> writes:
 >> defconfig fragment to reproduce the issue:
 >> BR2_PACKAGE_QEMU_ARCH_SUPPORTS_TARGET=y
 >> BR2_PACKAGE_QEMU=y
 >> BR2_PACKAGE_QEMU_SYSTEM=y

 >> ERROR: Problem encountered: fdt not available but required by targets
 >> aarch64-softmmu, arm-softmmu, i386-softmmu, loongarch64-softmmu,
 >> microblaze-softmmu, microblazeel-softmmu, mips64el-softmmu,
 >> nios2-softmmu, or1k-softmmu, ppc-softmmu, ppc64-softmmu,
 >> riscv32-softmmu, riscv64-softmmu, rx-softmmu, x86_64-softmmu

 >> Commit [1] select BR2_PACKAGE_QEMU_FDT for each individual emulator targets
 >> but forgot to select is when BR2_PACKAGE_QEMU_CHOOSE_TARGETS is not set
 >> (building for all targets).

 >> Fixes:
 >> http://autobuild.buildroot.org/results/e44/e444a02b899d325a9d99daed96b8cb96108383e7

 >> [1] 44be514b21fd94096702b80c62d46c31d72f15a5

 >> Signed-off-by: Romain Naour <romain.naour@smile.fr>
 >> Cc: Carlos Santos <unixmania@gmail.com>
 >> Cc: Yann E. MORIN <yann.morin.1998@free.fr>

 > Committed, thanks.

Committed to 2023.02.x and 2023.05.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot