* [Buildroot] [PATCH] package/git: make _BUG_ condition more clear
@ 2020-02-27 11:18 Giulio Benetti
2020-02-27 21:12 ` Peter Korsgaard
0 siblings, 1 reply; 2+ messages in thread
From: Giulio Benetti @ 2020-02-27 11:18 UTC (permalink / raw)
To: buildroot
As pointed by Peter combined condition of the 2 gcc bugs is potentially
wrong, but as Thomas pointed in this case it's not harmful. Let's fix it
anyway since it's basically wrong even it doesn't cause harm.
Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
package/git/git.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/git/git.mk b/package/git/git.mk
index f32a2f8eb9..dd79c41e4a 100644
--- a/package/git/git.mk
+++ b/package/git/git.mk
@@ -67,7 +67,7 @@ endif
GIT_CFLAGS = $(TARGET_CFLAGS)
-ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180)$(BR2_TOOLCHAIN_HAS_GCC_BUG_93847),y)
+ifneq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180)$(BR2_TOOLCHAIN_HAS_GCC_BUG_93847),)
GIT_CFLAGS += -O0
endif
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Buildroot] [PATCH] package/git: make _BUG_ condition more clear
2020-02-27 11:18 [Buildroot] [PATCH] package/git: make _BUG_ condition more clear Giulio Benetti
@ 2020-02-27 21:12 ` Peter Korsgaard
0 siblings, 0 replies; 2+ messages in thread
From: Peter Korsgaard @ 2020-02-27 21:12 UTC (permalink / raw)
To: buildroot
>>>>> "Giulio" == Giulio Benetti <giulio.benetti@benettiengineering.com> writes:
> As pointed by Peter combined condition of the 2 gcc bugs is potentially
> wrong, but as Thomas pointed in this case it's not harmful. Let's fix it
> anyway since it's basically wrong even it doesn't cause harm.
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-02-27 21:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-02-27 11:18 [Buildroot] [PATCH] package/git: make _BUG_ condition more clear Giulio Benetti
2020-02-27 21:12 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox