Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 4/8] package/mender: add BR2_PACKAGE_MENDER_ARTIFACT_NAME option
Date: Wed, 15 Aug 2018 08:10:56 +0300	[thread overview]
Message-ID: <87va8cnrj3.fsf@tkos.co.il> (raw)
In-Reply-To: <20180814231337.19114-5-mirza.krak@northern.tech>

Hi Mirza,

Mirza Krak writes:
> ARTIFACT_NAME is used to set a unique string of the built artifact/image
> and this will be reported to the Mender managment server as "current
> software running".
>
> The Mender managment server will skip updating device if the
> ARTIFACT_NAME is the same on the target device as in the Mender artifact
> and hence this name must be unique for every release.
>
> Signed-off-by: Mirza Krak <mirza.krak@northern.tech>
> ---
>  package/mender/Config.in | 13 +++++++++++++
>  package/mender/mender.mk |  7 +++++++
>  2 files changed, 20 insertions(+)
>
> diff --git a/package/mender/Config.in b/package/mender/Config.in
> index 8c2838c64a..036b7cf798 100644
> --- a/package/mender/Config.in
> +++ b/package/mender/Config.in
> @@ -13,6 +13,19 @@ config BR2_PACKAGE_MENDER
>  
>  	  https://github.com/mendersoftware/mender
>  
> +if BR2_PACKAGE_MENDER
> +
> +config BR2_PACKAGE_MENDER_ARTIFACT_NAME
> +	string "Mender artifact name"

You should have a default value here. Otherwise ...

> +	help
> +	  The name of the image or update that will be built. This is what the
> +	  device will report that it is running, and different updates must have
> +	  different names.
> +
> +	  Will be stored in /etc/mender/artifact_info
> +
> +endif
> +
>  comment "mender needs a toolchain w/ threads"
>  	depends on BR2_PACKAGE_HOST_GO_ARCH_SUPPORTS
>  	depends on BR2_PACKAGE_HOST_GO_CGO_LINKING_SUPPORTS
> diff --git a/package/mender/mender.mk b/package/mender/mender.mk
> index b2df70256a..08bdd4bd78 100644
> --- a/package/mender/mender.mk
> +++ b/package/mender/mender.mk
> @@ -9,6 +9,10 @@ MENDER_SITE = $(call github,mendersoftware,mender,$(MENDER_VERSION))
>  MENDER_LICENSE = Apache-2.0 & BSD-2-Clause & BSD-3-Clause & MIT & OLDAP-2.8
>  MENDER_LICENSE_FILES = LICENSE LIC_FILES_CHKSUM.sha256
>  
> +ifeq ($(call qstrip,$(BR2_PACKAGE_MENDER_ARTIFACT_NAME)),)
> +$(error Mender device type not set. Check your BR2_PACKAGE_MENDER_ARTIFACT_NAME setting)

... this error will trigger by default. This will hit the autobuilders
badly.

Same goes for the next patch.

baruch

> +endif
> +
>  define MENDER_INSTALL_CONFIG_FILES
>  	$(INSTALL) -d -m 755 $(TARGET_DIR)/data/mender
>  	$(INSTALL) -d -m 755 $(TARGET_DIR)/data/uboot
> @@ -28,6 +32,9 @@ define MENDER_INSTALL_CONFIG_FILES
>  		$(TARGET_DIR)/usr/share/mender/inventory
>  
>  	ln -sf /data/mender $(TARGET_DIR)/var/lib/mender
> +
> +	echo "artifact_name=$(call qstrip,$(BR2_PACKAGE_MENDER_ARTIFACT_NAME))" > \
> +		$(TARGET_DIR)/etc/mender/artifact_info
>  endef
>  
>  MENDER_POST_INSTALL_TARGET_HOOKS += MENDER_INSTALL_CONFIG_FILES

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

  reply	other threads:[~2018-08-15  5:10 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-14 23:13 [Buildroot] [PATCH 0/8] various improvements to package/mender Mirza Krak
2018-08-14 23:13 ` [Buildroot] [PATCH 1/8] package/mender: update legal info Mirza Krak
2018-08-14 23:32   ` Arnout Vandecappelle
2018-08-15  7:37     ` Mirza Krak
2018-08-16 15:36       ` Arnout Vandecappelle
2018-08-16 19:59         ` Mirza Krak
2018-08-16 20:18         ` Mirza Krak
2018-08-17  3:48           ` Baruch Siach
2018-08-17  6:53             ` Mirza Krak
2018-08-14 23:13 ` [Buildroot] [PATCH 2/8] package/mender: update install of config files Mirza Krak
2018-08-15 12:31   ` Thomas Petazzoni
2018-08-15 12:42     ` Mirza Krak
2018-08-15 17:41       ` Thomas Petazzoni
2018-08-15 18:48         ` Mirza Krak
2018-08-15 19:02           ` Thomas Petazzoni
2018-08-14 23:13 ` [Buildroot] [PATCH 3/8] package/mender: add dep on BR2_PACKAGE_UBOOT_TOOLS_FWPRINTENV Mirza Krak
2018-08-15  5:08   ` Baruch Siach
2018-08-15  7:21     ` Mirza Krak
2018-08-14 23:13 ` [Buildroot] [PATCH 4/8] package/mender: add BR2_PACKAGE_MENDER_ARTIFACT_NAME option Mirza Krak
2018-08-15  5:10   ` Baruch Siach [this message]
2018-08-15  7:23     ` Mirza Krak
2018-08-15 11:53   ` Thomas Petazzoni
2018-08-15 12:23     ` Mirza Krak
2018-08-14 23:13 ` [Buildroot] [PATCH 5/8] package/mender: add BR2_PACKAGE_MENDER_DEVICE_TYPE option Mirza Krak
2018-08-15 11:55   ` Thomas Petazzoni
2018-08-15 12:26     ` Mirza Krak
2018-08-15 12:42       ` Thomas Petazzoni
2018-08-15 12:46         ` Mirza Krak
2018-08-15 17:47           ` Thomas Petazzoni
2018-08-15 19:41             ` Mirza Krak
2018-08-14 23:13 ` [Buildroot] [PATCH 6/8] package/mender: populate the mender.conf template Mirza Krak
2018-08-15 11:56   ` Thomas Petazzoni
2018-08-15 12:27     ` Mirza Krak
2018-08-14 23:13 ` [Buildroot] [PATCH 7/8] package/mender: select BR2_PACKAGE_CA_CERTIFICATES Mirza Krak
2018-08-15 11:57   ` Thomas Petazzoni
2018-08-15 12:28     ` Mirza Krak
2018-08-14 23:13 ` [Buildroot] [PATCH 8/8] package/mender: set version in go linker Mirza Krak
2018-08-15 11:58   ` Thomas Petazzoni
2018-08-15 12:32     ` Mirza Krak
2018-08-15 12:43       ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87va8cnrj3.fsf@tkos.co.il \
    --to=baruch@tkos.co.il \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox