Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/8] package/mender: add dep on BR2_PACKAGE_UBOOT_TOOLS_FWPRINTENV
Date: Wed, 15 Aug 2018 08:08:03 +0300	[thread overview]
Message-ID: <87wossnrnw.fsf@tkos.co.il> (raw)
In-Reply-To: <20180814231337.19114-4-mirza.krak@northern.tech>

Hi Mirza,

Mirza Krak writes:
> The Mender client uses fw_printenv/fw_setenv to manipulate the U-boot
> environment, e.g to change the boot candidate after a update has been
> done.
>
> Signed-off-by: Mirza Krak <mirza.krak@northern.tech>
> ---
>  package/mender/Config.in | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/package/mender/Config.in b/package/mender/Config.in
> index e461857486..8c2838c64a 100644
> --- a/package/mender/Config.in
> +++ b/package/mender/Config.in
> @@ -3,6 +3,8 @@ config BR2_PACKAGE_MENDER
>  	depends on BR2_PACKAGE_HOST_GO_ARCH_SUPPORTS
>  	depends on BR2_PACKAGE_HOST_GO_CGO_LINKING_SUPPORTS
>  	depends on BR2_TOOLCHAIN_HAS_THREADS
> +	depends on BR2_PACKAGE_UBOOT_TOOLS
> +	depends on BR2_PACKAGE_UBOOT_TOOLS_FWPRINTENV

For non-obvious dependencies like these we prefer 'select'. Also, since
this is a run-time only dependency, there should be a comment saying
that. So:

      select BR2_PACKAGE_UBOOT_TOOLS # runtime
      select BR2_PACKAGE_UBOOT_TOOLS_FWPRINTENV # runtime

baruch

>  	help
>  	  Mender is an open source over-the-air (OTA) software updater
>  	  for embedded Linux devices. Mender comprises a client

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

  reply	other threads:[~2018-08-15  5:08 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-14 23:13 [Buildroot] [PATCH 0/8] various improvements to package/mender Mirza Krak
2018-08-14 23:13 ` [Buildroot] [PATCH 1/8] package/mender: update legal info Mirza Krak
2018-08-14 23:32   ` Arnout Vandecappelle
2018-08-15  7:37     ` Mirza Krak
2018-08-16 15:36       ` Arnout Vandecappelle
2018-08-16 19:59         ` Mirza Krak
2018-08-16 20:18         ` Mirza Krak
2018-08-17  3:48           ` Baruch Siach
2018-08-17  6:53             ` Mirza Krak
2018-08-14 23:13 ` [Buildroot] [PATCH 2/8] package/mender: update install of config files Mirza Krak
2018-08-15 12:31   ` Thomas Petazzoni
2018-08-15 12:42     ` Mirza Krak
2018-08-15 17:41       ` Thomas Petazzoni
2018-08-15 18:48         ` Mirza Krak
2018-08-15 19:02           ` Thomas Petazzoni
2018-08-14 23:13 ` [Buildroot] [PATCH 3/8] package/mender: add dep on BR2_PACKAGE_UBOOT_TOOLS_FWPRINTENV Mirza Krak
2018-08-15  5:08   ` Baruch Siach [this message]
2018-08-15  7:21     ` Mirza Krak
2018-08-14 23:13 ` [Buildroot] [PATCH 4/8] package/mender: add BR2_PACKAGE_MENDER_ARTIFACT_NAME option Mirza Krak
2018-08-15  5:10   ` Baruch Siach
2018-08-15  7:23     ` Mirza Krak
2018-08-15 11:53   ` Thomas Petazzoni
2018-08-15 12:23     ` Mirza Krak
2018-08-14 23:13 ` [Buildroot] [PATCH 5/8] package/mender: add BR2_PACKAGE_MENDER_DEVICE_TYPE option Mirza Krak
2018-08-15 11:55   ` Thomas Petazzoni
2018-08-15 12:26     ` Mirza Krak
2018-08-15 12:42       ` Thomas Petazzoni
2018-08-15 12:46         ` Mirza Krak
2018-08-15 17:47           ` Thomas Petazzoni
2018-08-15 19:41             ` Mirza Krak
2018-08-14 23:13 ` [Buildroot] [PATCH 6/8] package/mender: populate the mender.conf template Mirza Krak
2018-08-15 11:56   ` Thomas Petazzoni
2018-08-15 12:27     ` Mirza Krak
2018-08-14 23:13 ` [Buildroot] [PATCH 7/8] package/mender: select BR2_PACKAGE_CA_CERTIFICATES Mirza Krak
2018-08-15 11:57   ` Thomas Petazzoni
2018-08-15 12:28     ` Mirza Krak
2018-08-14 23:13 ` [Buildroot] [PATCH 8/8] package/mender: set version in go linker Mirza Krak
2018-08-15 11:58   ` Thomas Petazzoni
2018-08-15 12:32     ` Mirza Krak
2018-08-15 12:43       ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wossnrnw.fsf@tkos.co.il \
    --to=baruch@tkos.co.il \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox