Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/2] package/dvb-apps: requires largefiles
  2013-01-08 12:06 [Buildroot] [pull request] Pull request for branch yem-misc-fixes Yann E. MORIN
@ 2013-01-08 12:06 ` Yann E. MORIN
  0 siblings, 0 replies; 6+ messages in thread
From: Yann E. MORIN @ 2013-01-08 12:06 UTC (permalink / raw)
  To: buildroot

Fixes (for example):
    http://autobuild.buildroot.net/results/5e12820c6537b176c49671a65afcbdb86c5154c9

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
 package/dvb-apps/Config.in |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/package/dvb-apps/Config.in b/package/dvb-apps/Config.in
index 5d0b6f5..ca8dc54 100644
--- a/package/dvb-apps/Config.in
+++ b/package/dvb-apps/Config.in
@@ -8,8 +8,12 @@ config BR2_PACKAGE_DVB_APPS
 
 if BR2_PACKAGE_DVB_APPS
 
+comment "dvb-apps utils needs LARGEFILE support in the toolchain"
+	depends on !BR2_LARGEFILE
+
 config BR2_PACKAGE_DVB_APPS_UTILS
 	bool "dvb-apps utilities"
+	depends on BR2_LARGEFILE
 	help
 	  A small number of DVB test and utility programs,
 	  including szap and dvbscan.
-- 
1.7.2.5

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [Buildroot] [pull request v2] Pull request for branch yem-misc-fixes
@ 2013-01-08 19:11 Yann E. MORIN
  2013-01-08 19:11 ` [Buildroot] [PATCH 1/2] package/dvb-apps: requires largefiles Yann E. MORIN
  2013-01-08 19:11 ` [Buildroot] [PATCH 2/2] package/dvb-apps: requires iconv Yann E. MORIN
  0 siblings, 2 replies; 6+ messages in thread
From: Yann E. MORIN @ 2013-01-08 19:11 UTC (permalink / raw)
  To: buildroot

Hello All!

Here is a series to fix the autobuilder issues with dvb-apps.

Changes v1 -> v2:
  - Fix libiconv dependency


The following changes since commit b0e63e5b9a736e70a24e156033663088b4a7f199:

  package: add green end sftp server (2013-01-08 17:15:16 +0100)

are available in the git repository at:
  git://gitorious.org/buildroot/buildroot.git yem-misc-fixes

Yann E. MORIN (2):
      package/dvb-apps: requires largefiles
      package/dvb-apps: requires iconv

 package/dvb-apps/Config.in   |    5 +++++
 package/dvb-apps/dvb-apps.mk |    3 ++-
 2 files changed, 7 insertions(+), 1 deletions(-)

Regards,
Yann E. MORIN

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/2] package/dvb-apps: requires largefiles
  2013-01-08 19:11 [Buildroot] [pull request v2] Pull request for branch yem-misc-fixes Yann E. MORIN
@ 2013-01-08 19:11 ` Yann E. MORIN
  2013-01-11 18:08   ` Peter Korsgaard
  2013-01-08 19:11 ` [Buildroot] [PATCH 2/2] package/dvb-apps: requires iconv Yann E. MORIN
  1 sibling, 1 reply; 6+ messages in thread
From: Yann E. MORIN @ 2013-01-08 19:11 UTC (permalink / raw)
  To: buildroot

Fixes (for example):
    http://autobuild.buildroot.net/results/5e12820c6537b176c49671a65afcbdb86c5154c9

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
 package/dvb-apps/Config.in |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/package/dvb-apps/Config.in b/package/dvb-apps/Config.in
index 5d0b6f5..ca8dc54 100644
--- a/package/dvb-apps/Config.in
+++ b/package/dvb-apps/Config.in
@@ -8,8 +8,12 @@ config BR2_PACKAGE_DVB_APPS
 
 if BR2_PACKAGE_DVB_APPS
 
+comment "dvb-apps utils needs LARGEFILE support in the toolchain"
+	depends on !BR2_LARGEFILE
+
 config BR2_PACKAGE_DVB_APPS_UTILS
 	bool "dvb-apps utilities"
+	depends on BR2_LARGEFILE
 	help
 	  A small number of DVB test and utility programs,
 	  including szap and dvbscan.
-- 
1.7.2.5

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 2/2] package/dvb-apps: requires iconv
  2013-01-08 19:11 [Buildroot] [pull request v2] Pull request for branch yem-misc-fixes Yann E. MORIN
  2013-01-08 19:11 ` [Buildroot] [PATCH 1/2] package/dvb-apps: requires largefiles Yann E. MORIN
@ 2013-01-08 19:11 ` Yann E. MORIN
  2013-01-11 18:08   ` Peter Korsgaard
  1 sibling, 1 reply; 6+ messages in thread
From: Yann E. MORIN @ 2013-01-08 19:11 UTC (permalink / raw)
  To: buildroot

Use libiconv if the toolchain does not have locales.

Fixes (for example):
    http://autobuild.buildroot.net/results/c5776c95ac128f7c7eadc2fe746ad89f8c1ef49a

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
 package/dvb-apps/Config.in   |    1 +
 package/dvb-apps/dvb-apps.mk |    3 ++-
 2 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/package/dvb-apps/Config.in b/package/dvb-apps/Config.in
index ca8dc54..7f76330 100644
--- a/package/dvb-apps/Config.in
+++ b/package/dvb-apps/Config.in
@@ -14,6 +14,7 @@ comment "dvb-apps utils needs LARGEFILE support in the toolchain"
 config BR2_PACKAGE_DVB_APPS_UTILS
 	bool "dvb-apps utilities"
 	depends on BR2_LARGEFILE
+	select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE
 	help
 	  A small number of DVB test and utility programs,
 	  including szap and dvbscan.
diff --git a/package/dvb-apps/dvb-apps.mk b/package/dvb-apps/dvb-apps.mk
index f914799..a1ad0c4 100644
--- a/package/dvb-apps/dvb-apps.mk
+++ b/package/dvb-apps/dvb-apps.mk
@@ -20,10 +20,11 @@ DVB_APPS_LICENSE        = unknown (probably public domain)
 
 ifeq ($(BR2_PACKAGE_DVB_APPS_UTILS),y)
 # Utilitiess are selected, build and install everything
+DVB_APPS_DEPENDENCIES    = $(if $(BR2_ENABLE_LOCALE),,libiconv)
 DVB_APPS_INSTALL_STAGING = YES
 
 define DVB_APPS_BUILD_CMDS
-	$(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) V=1
+	$(TARGET_CONFIGURE_OPTS) LDFLAGS="$(TARGET_LDFLAGS) -liconv" $(MAKE) -C $(@D) V=1
 endef
 
 define DVB_APPS_INSTALL_STAGING_CMDS
-- 
1.7.2.5

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/2] package/dvb-apps: requires largefiles
  2013-01-08 19:11 ` [Buildroot] [PATCH 1/2] package/dvb-apps: requires largefiles Yann E. MORIN
@ 2013-01-11 18:08   ` Peter Korsgaard
  0 siblings, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2013-01-11 18:08 UTC (permalink / raw)
  To: buildroot

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 Yann> Fixes (for example):
 Yann>     http://autobuild.buildroot.net/results/5e12820c6537b176c49671a65afcbdb86c5154c9

Committed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 2/2] package/dvb-apps: requires iconv
  2013-01-08 19:11 ` [Buildroot] [PATCH 2/2] package/dvb-apps: requires iconv Yann E. MORIN
@ 2013-01-11 18:08   ` Peter Korsgaard
  0 siblings, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2013-01-11 18:08 UTC (permalink / raw)
  To: buildroot

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 Yann> Use libiconv if the toolchain does not have locales.
 Yann> Fixes (for example):
 Yann>     http://autobuild.buildroot.net/results/c5776c95ac128f7c7eadc2fe746ad89f8c1ef49a

 Yann> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
 Yann> ---
 Yann>  package/dvb-apps/Config.in   |    1 +
 Yann>  package/dvb-apps/dvb-apps.mk |    3 ++-
 Yann>  2 files changed, 3 insertions(+), 1 deletions(-)

 Yann> diff --git a/package/dvb-apps/Config.in b/package/dvb-apps/Config.in
 Yann> index ca8dc54..7f76330 100644
 Yann> --- a/package/dvb-apps/Config.in
 Yann> +++ b/package/dvb-apps/Config.in
 Yann> @@ -14,6 +14,7 @@ comment "dvb-apps utils needs LARGEFILE support in the toolchain"
 Yann>  config BR2_PACKAGE_DVB_APPS_UTILS
 Yann>  	bool "dvb-apps utilities"
 Yann>  	depends on BR2_LARGEFILE
 Yann> +	select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE
 Yann>  	help
 Yann>  	  A small number of DVB test and utility programs,
 Yann>  	  including szap and dvbscan.
 Yann> diff --git a/package/dvb-apps/dvb-apps.mk b/package/dvb-apps/dvb-apps.mk
 Yann> index f914799..a1ad0c4 100644
 Yann> --- a/package/dvb-apps/dvb-apps.mk
 Yann> +++ b/package/dvb-apps/dvb-apps.mk
 Yann> @@ -20,10 +20,11 @@ DVB_APPS_LICENSE        = unknown (probably public domain)
 
 Yann>  ifeq ($(BR2_PACKAGE_DVB_APPS_UTILS),y)
 Yann>  # Utilitiess are selected, build and install everything
 Yann> +DVB_APPS_DEPENDENCIES    = $(if $(BR2_ENABLE_LOCALE),,libiconv)
 Yann>  DVB_APPS_INSTALL_STAGING = YES
 
 Yann>  define DVB_APPS_BUILD_CMDS
 Yann> -	$(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) V=1
 Yann> +	$(TARGET_CONFIGURE_OPTS) LDFLAGS="$(TARGET_LDFLAGS) -liconv" $(MAKE) -C $(@D) V=1

Ehh, that's wrong. You should only link against libiconv if we've built
it.

Care to fix and resend?


-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-01-11 18:08 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-08 19:11 [Buildroot] [pull request v2] Pull request for branch yem-misc-fixes Yann E. MORIN
2013-01-08 19:11 ` [Buildroot] [PATCH 1/2] package/dvb-apps: requires largefiles Yann E. MORIN
2013-01-11 18:08   ` Peter Korsgaard
2013-01-08 19:11 ` [Buildroot] [PATCH 2/2] package/dvb-apps: requires iconv Yann E. MORIN
2013-01-11 18:08   ` Peter Korsgaard
  -- strict thread matches above, loose matches on Subject: below --
2013-01-08 12:06 [Buildroot] [pull request] Pull request for branch yem-misc-fixes Yann E. MORIN
2013-01-08 12:06 ` [Buildroot] [PATCH 1/2] package/dvb-apps: requires largefiles Yann E. MORIN

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox