[Buildroot] [git commit] boot: get rid of toplevel submenus

[Buildroot] [git commit] boot: get rid of toplevel submenus

[Peter Korsgaard]

commit: http://git.buildroot.net/buildroot/commit/?id=ec9ec06b56bcc38f7a5ed98ff8b076e864e74c5d
branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master

Sub options are indented anyway, so no need for empty menus / force people
to enter sub menus to see configuration options.

Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
---
 boot/at91bootstrap/Config.in |    2 +-
 boot/barebox/Config.in       |    2 +-
 boot/grub/Config.in          |    2 +-
 boot/uboot/Config.in         |    2 +-
 boot/xloader/Config.in       |    2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/boot/at91bootstrap/Config.in b/boot/at91bootstrap/Config.in
index f022dd5..ff968cd 100644
--- a/boot/at91bootstrap/Config.in
+++ b/boot/at91bootstrap/Config.in
@@ -1,4 +1,4 @@
-menuconfig BR2_TARGET_AT91BOOTSTRAP
+config BR2_TARGET_AT91BOOTSTRAP
 	depends on BR2_arm
 	bool "AT91 Bootstrap"
 	help
diff --git a/boot/barebox/Config.in b/boot/barebox/Config.in
index 87bf39b..71d530f 100644
--- a/boot/barebox/Config.in
+++ b/boot/barebox/Config.in
@@ -1,4 +1,4 @@
-menuconfig BR2_TARGET_BAREBOX
+config BR2_TARGET_BAREBOX
 	bool "Barebox"
 	help
 	  The Barebox bootloader, formerly known as U-Boot v2.
diff --git a/boot/grub/Config.in b/boot/grub/Config.in
index bc7a73e..ec48d17 100644
--- a/boot/grub/Config.in
+++ b/boot/grub/Config.in
@@ -9,7 +9,7 @@ config BR2_TARGET_GRUB_SPLASH
 	depends on BR2_TARGET_GRUB
 	help
 	  Add support for splashimage.
-	
+
 	  A splashimage is a 14-color indexed .xpm picture which
 	  is displayed as background for the grub menu.
 
diff --git a/boot/uboot/Config.in b/boot/uboot/Config.in
index a0b2bfc..3608cd4 100644
--- a/boot/uboot/Config.in
+++ b/boot/uboot/Config.in
@@ -1,4 +1,4 @@
-menuconfig BR2_TARGET_UBOOT
+config BR2_TARGET_UBOOT
 	bool "U-Boot"
 	help
 	  Build "Das U-Boot" Boot Monitor
diff --git a/boot/xloader/Config.in b/boot/xloader/Config.in
index d295b45..c411be4 100644
--- a/boot/xloader/Config.in
+++ b/boot/xloader/Config.in
@@ -1,4 +1,4 @@
-menuconfig BR2_TARGET_XLOADER
+config BR2_TARGET_XLOADER
 	bool "X-loader"
 	depends on BR2_cortex_a8 || BR2_cortex_a9
 	help

[Buildroot] [git commit] boot: get rid of toplevel submenus

[Thomas Petazzoni]

Hello,

Le Sun, 18 Sep 2011 22:09:42 +0200,
Peter Korsgaard <jacmet@sunsite.dk> a ?crit :

> Sub options are indented anyway, so no need for empty menus / force
> people to enter sub menus to see configuration options.

My preference was the old way. Even if suboptions are indented,  I
think it's a mess in menuconfig to have the U-Boot suboptions in the
middle of the bootloader list.

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[Buildroot] [git commit] boot: get rid of toplevel submenus

[Peter Korsgaard]

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

Hi,

 >> Sub options are indented anyway, so no need for empty menus / force
 >> people to enter sub menus to see configuration options.

 Thomas> My preference was the old way. Even if suboptions are indented,  I
 Thomas> think it's a mess in menuconfig to have the U-Boot suboptions in the
 Thomas> middle of the bootloader list.

I find the empty submenus when E.G. u-boot isn't enabled pretty ugly,
and use of a normal config is by far the most used option - E.G:

git grep '^menuconfig '|wc -l
10

Out of ~700 packages, bootloaders, filesystems, ..

-- 
Bye, Peter Korsgaard

[Buildroot] [git commit] boot: get rid of toplevel submenus

[Thomas Petazzoni]

Le Mon, 19 Sep 2011 08:54:29 +0200,
Peter Korsgaard <jacmet@uclibc.org> a ?crit :

>  Thomas> My preference was the old way. Even if suboptions are
>  Thomas> indented,  I think it's a mess in menuconfig to have the
>  Thomas> U-Boot suboptions in the middle of the bootloader list.
> 
> I find the empty submenus when E.G. u-boot isn't enabled pretty ugly,

That could probably be fixed at the kconfig level, though I admit
making changes to this code is always a challenge.

> and use of a normal config is by far the most used option - E.G:
> 
> git grep '^menuconfig '|wc -l
> 10
> 
> Out of ~700 packages, bootloaders, filesystems, ..

It's not because it's the most commonly used option that I like it :)

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com