[Buildroot] [PATCH] buildroot:package: Remove configure target parameter in Makefile.autotools.in

[Buildroot] [PATCH] buildroot:package: Remove configure target parameter in Makefile.autotools.in

[Sonic Zhang]

From: Sonic Zhang <sonic.zhang@analog.com>

configure parameter --target has different meaning from buildroot environment
parameter GNU_TARGET_NAME. GNU_TARGET_NAME is actually equal to --host.

  --build=BUILD     configure for building on BUILD [guessed]
  --host=HOST       cross-compile to build programs to run on HOST [BUILD]
  --target=TARGET   configure for building compilers for TARGET [HOST]

--target is rarely used by most packages and is redundant in configure line.
If some packages do need --target, they can append it to buildroot environment
parameter INETUTILS_CONF_OPT in packages' makefile.

Signed-off-by: Sonic Zhang <sonic.zhang@analog.com>
---
 package/Makefile.autotools.in |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/package/Makefile.autotools.in b/package/Makefile.autotools.in
index d445348..151e5cf 100644
--- a/package/Makefile.autotools.in
+++ b/package/Makefile.autotools.in
@@ -87,7 +87,6 @@ define $(2)_CONFIGURE_CMDS
 	$$(TARGET_CONFIGURE_ARGS) \
 	$$($$(PKG)_CONF_ENV) \
 	./configure \
-		--target=$$(GNU_TARGET_NAME) \
 		--host=$$(GNU_TARGET_NAME) \
 		--build=$$(GNU_HOST_NAME) \
 		--prefix=/usr \
-- 
1.7.0.4

[Buildroot] [uclinux-dist-devel] [PATCH] buildroot:package: Remove configure target parameter in Makefile.autotools.in

[Mike Frysinger]

On Mon, Jan 31, 2011 at 22:52, Sonic Zhang wrote:
> configure parameter --target has different meaning from buildroot environment
> parameter GNU_TARGET_NAME. GNU_TARGET_NAME is actually equal to --host.
>
> ?--build=BUILD ? ? configure for building on BUILD [guessed]
> ?--host=HOST ? ? ? cross-compile to build programs to run on HOST [BUILD]
> ?--target=TARGET ? configure for building compilers for TARGET [HOST]
>
> --target is rarely used by most packages and is redundant in configure line.
> If some packages do need --target, they can append it to buildroot environment
> parameter INETUTILS_CONF_OPT in packages' makefile.

not really ... the usage is harmless.  it might be a little redundant
since target tends to default to host, but that's about it.  what are
you actually trying to address here ?

[resending with buildroot subscription]
-mike

[Buildroot] [uclinux-dist-devel] [PATCH] buildroot:package: Remove configure target parameter in Makefile.autotools.in

[Sonic Zhang]

Some autotools based software packages generate prefix name to the
binary after running install if you set --target parameter.

For example:

--target=arm

rcp is rename to "linux-arm-rcp" after running install


Sonic


On Tue, Feb 1, 2011 at 12:02 PM, Mike Frysinger <vapier.adi@gmail.com> wrote:
> On Mon, Jan 31, 2011 at 22:52, Sonic Zhang wrote:
>> configure parameter --target has different meaning from buildroot environment
>> parameter GNU_TARGET_NAME. GNU_TARGET_NAME is actually equal to --host.
>>
>> ?--build=BUILD ? ? configure for building on BUILD [guessed]
>> ?--host=HOST ? ? ? cross-compile to build programs to run on HOST [BUILD]
>> ?--target=TARGET ? configure for building compilers for TARGET [HOST]
>>
>> --target is rarely used by most packages and is redundant in configure line.
>> If some packages do need --target, they can append it to buildroot environment
>> parameter INETUTILS_CONF_OPT in packages' makefile.
>
> not really ... the usage is harmless. ?it might be a little redundant
> since target tends to default to host, but that's about it. ?what are
> you actually trying to address here ?
> -mike
>

[Buildroot] [uclinux-dist-devel] [PATCH] buildroot:package: Remove configure target parameter in Makefile.autotools.in

[Mike Frysinger]

On Mon, Jan 31, 2011 at 23:43, Sonic Zhang wrote:

please dont top post

> Some autotools based software packages generate prefix name to the
> binary after running install if you set --target parameter.
>
> For example:
>
> --target=arm
>
> rcp is rename to "linux-arm-rcp" after running install

this is due to program_transform_name which is easily disabled:
    program_transform_name=

alternatively, inetutils should be fixed to not have a --target in the
first place.  a "target" makes no sense for applications that dont
generate anything, and since inetutils falls into that category, it
should have AC_CANONICAL_SYSTEM changed to AC_CANONICAL_HOST in its
configure.ac.
-mike

[Buildroot] [uclinux-dist-devel] [PATCH] buildroot:package: Remove configure target parameter in Makefile.autotools.in

[Mike Frysinger]

On Tue, Feb 1, 2011 at 02:48, Zhang, Sonic wrote:
>Mike Frysinger:
>>On Mon, Jan 31, 2011 at 23:43, Sonic Zhang wrote:
>>> Some autotools based software packages generate prefix name to the
>>> binary after running install if you set --target parameter.
>>>
>>> For example:
>>> --target=arm
>>> rcp is rename to "linux-arm-rcp" after running install
>>
>>this is due to program_transform_name which is easily disabled:
>> ? ?program_transform_name=
>
> Not only inetutils, but many other packages need "program_transform_name=" in this case. Because rare packages require --target to be set, why not do something to ease many?

personally, i prefer the route of fixing the underlying problem --
these packages should not have a --target unless they actually need
it.
-mike

[Buildroot] [uclinux-dist-devel] [PATCH] buildroot:package: Remove configure target parameter in Makefile.autotools.in

[Peter Korsgaard]

>>>>> "Sonic" == Sonic Zhang <sonic.adi@gmail.com> writes:

 Sonic> Some autotools based software packages generate prefix name to the
 Sonic> binary after running install if you set --target parameter.

 Sonic> For example:

 Sonic> --target=arm

 Sonic> rcp is rename to "linux-arm-rcp" after running install

These packages typically accept the configure options
--program-transform-name to make them not do that.

-- 
Bye, Peter Korsgaard

[Buildroot] [uclinux-dist-devel] [PATCH] buildroot:package: Remove configure target parameter in Makefile.autotools.in

[Sonic Zhang]

On Tue, Feb 1, 2011 at 3:45 PM, Peter Korsgaard <jacmet@uclibc.org> wrote:
>>>>>> "Sonic" == Sonic Zhang <sonic.adi@gmail.com> writes:
>
> ?Sonic> Some autotools based software packages generate prefix name to the
> ?Sonic> binary after running install if you set --target parameter.
>
> ?Sonic> For example:
>
> ?Sonic> --target=arm
>
> ?Sonic> rcp is rename to "linux-arm-rcp" after running install
>
> These packages typically accept the configure options
> --program-transform-name to make them not do that.
>

Yes, but for some packages, --host and --target are not the same as
defined in buildroot.

For example, to build on x86, run on arm and generate binary for mips.


Sonic

> --
> Bye, Peter Korsgaard
>

[Buildroot] [uclinux-dist-devel] [PATCH] buildroot:package: Remove configure target parameter in Makefile.autotools.in

[Mike Frysinger]

On Tue, Feb 1, 2011 at 23:49, Sonic Zhang wrote:
> On Tue, Feb 1, 2011 at 3:45 PM, Peter Korsgaard wrote:
>>>>>>> "Sonic" == Sonic Zhang writes:
>>
>> ?Sonic> Some autotools based software packages generate prefix name to the
>> ?Sonic> binary after running install if you set --target parameter.
>>
>> ?Sonic> For example:
>>
>> ?Sonic> --target=arm
>>
>> ?Sonic> rcp is rename to "linux-arm-rcp" after running install
>>
>> These packages typically accept the configure options
>> --program-transform-name to make them not do that.
>
> Yes, but for some packages, --host and --target are not the same as
> defined in buildroot.

yes they are

> For example, to build on x86, run on arm and generate binary for mips.

but that is what we're doing.  we build on x86, run on arm, and
generate for arm.
-mike

[Buildroot] [uclinux-dist-devel] [PATCH] buildroot:package: Remove configure target parameter in Makefile.autotools.in

[Sonic Zhang]

On Wed, Feb 2, 2011 at 2:40 PM, Mike Frysinger <vapier.adi@gmail.com> wrote:
> On Tue, Feb 1, 2011 at 23:49, Sonic Zhang wrote:
>> On Tue, Feb 1, 2011 at 3:45 PM, Peter Korsgaard wrote:
>>>>>>>> "Sonic" == Sonic Zhang writes:
>>>
>>> ?Sonic> Some autotools based software packages generate prefix name to the
>>> ?Sonic> binary after running install if you set --target parameter.
>>>
>>> ?Sonic> For example:
>>>
>>> ?Sonic> --target=arm
>>>
>>> ?Sonic> rcp is rename to "linux-arm-rcp" after running install
>>>
>>> These packages typically accept the configure options
>>> --program-transform-name to make them not do that.
>>
>> Yes, but for some packages, --host and --target are not the same as
>> defined in buildroot.
>
> yes they are
>
>> For example, to build on x86, run on arm and generate binary for mips.
>
> but that is what we're doing. ?we build on x86, run on arm, and
> generate for arm.
> -mike
>
Are you sure buildroot should be limited to the same --host and --target only?


Sonic

[Buildroot] [uclinux-dist-devel] [PATCH] buildroot:package: Remove configure target parameter in Makefile.autotools.in

[Mike Frysinger]

On Tuesday, February 08, 2011 22:01:52 Sonic Zhang wrote:
> On Wed, Feb 2, 2011 at 2:40 PM, Mike Frysinger <vapier.adi@gmail.com> wrote:
> > On Tue, Feb 1, 2011 at 23:49, Sonic Zhang wrote:
> >> On Tue, Feb 1, 2011 at 3:45 PM, Peter Korsgaard wrote:
> >>>>>>>> "Sonic" == Sonic Zhang writes:
> >>>  Sonic> Some autotools based software packages generate prefix name to
> >>> the Sonic> binary after running install if you set --target parameter.
> >>> 
> >>>  Sonic> For example:
> >>> 
> >>>  Sonic> --target=arm
> >>> 
> >>>  Sonic> rcp is rename to "linux-arm-rcp" after running install
> >>> 
> >>> These packages typically accept the configure options
> >>> --program-transform-name to make them not do that.
> >> 
> >> Yes, but for some packages, --host and --target are not the same as
> >> defined in buildroot.
> > 
> > yes they are
> > 
> >> For example, to build on x86, run on arm and generate binary for mips.
> > 
> > but that is what we're doing.  we build on x86, run on arm, and
> > generate for arm.
> 
> Are you sure buildroot should be limited to the same --host and --target
> only?

until buildroot grows support to let users specify a --target, it is already 
limited to that.

i already sent a patch to upstream inetutils to fix their autoconf and they 
accepted it.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20110215/af62dc0c/attachment.asc>