Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Add i830 graphics driver to DirectFB
Date: Thu, 24 Sep 2009 12:23:58 +0200	[thread overview]
Message-ID: <87vdj863pd.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <1253754832.451.92.camel@station1.ormlab.com> (Ormund Williams's message of "Wed\, 23 Sep 2009 21\:13\:52 -0400")

>>>>> "Ormund" == Ormund Williams <ormundw@panix.com> writes:

Hi,

Thanks, committed with minor changes. There's a few things to keep in
mind for next time though:

1: You didn't have a signed-off-by: line - Please use git commit -s to
add it automatically when you commit.

2: You seem to be missing a -- seperator here, making the diffstat
output part of the commit message (which it shouldn't be). Did you send
the patch with git send-email?

 Ormund>  package/directfb/Config.in   |    6 ++++++
 Ormund>  package/directfb/directfb.mk |    3 +++
 Ormund>  2 files changed, 9 insertions(+), 0 deletions(-)

 Ormund> +config BR2_PACKAGE_DIRECTFB_I830
 Ormund> +	bool "compile i830 graphics driver"
 Ormund> +	default n
 
'n' is the default anyway, so there's no need to add it explicitly.

-- 
Bye, Peter Korsgaard

      reply	other threads:[~2009-09-24 10:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-24  1:13 [Buildroot] [PATCH] Add i830 graphics driver to DirectFB Ormund Williams
2009-09-24 10:23 ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vdj863pd.fsf@macbook.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox