Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] Add i830 graphics driver to DirectFB
@ 2009-09-24  1:13 Ormund Williams
  2009-09-24 10:23 ` Peter Korsgaard
  0 siblings, 1 reply; 2+ messages in thread
From: Ormund Williams @ 2009-09-24  1:13 UTC (permalink / raw)
  To: buildroot

 package/directfb/Config.in   |    6 ++++++
 package/directfb/directfb.mk |    3 +++
 2 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/package/directfb/Config.in b/package/directfb/Config.in
index 487faf4..8f4beb8 100644
--- a/package/directfb/Config.in
+++ b/package/directfb/Config.in
@@ -61,6 +61,12 @@ config BR2_PACKAGE_DIRECTFB_UNICHROME
 	depends on BR2_PACKAGE_DIRECTFB
 	depends on BR2_i386 || BR2_x86_64
 
+config BR2_PACKAGE_DIRECTFB_I830
+	bool "compile i830 graphics driver"
+	default n
+	depends on BR2_PACKAGE_DIRECTFB
+	depends on BR2_i386 || BR2_x86_64
+
 config BR2_PACKAGE_DIRECTFB_LINUXINPUT
 	bool "compile /dev/input/eventX input driver"
 	default y
diff --git a/package/directfb/directfb.mk b/package/directfb/directfb.mk
index 4212a4a..409f791 100644
--- a/package/directfb/directfb.mk
+++ b/package/directfb/directfb.mk
@@ -63,6 +63,9 @@ endif
 ifeq ($(BR2_PACKAGE_DIRECTFB_UNICHROME),y)
 DIRECTFB_GFX+= unichrome
 endif
+ifeq ($(BR2_PACKAGE_DIRECTFB_I830),y)
+DIRECTFB_GFX+= i830
+endif
 ifeq ($(DIRECTFB_GFX),)
 DIRECTFB_GFX:=none
 else
-- 
1.5.6.5

_____________________________________________________
Does this look right?
-- 
Ormund Williams
OrmLab LLC

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Buildroot] [PATCH] Add i830 graphics driver to DirectFB
  2009-09-24  1:13 [Buildroot] [PATCH] Add i830 graphics driver to DirectFB Ormund Williams
@ 2009-09-24 10:23 ` Peter Korsgaard
  0 siblings, 0 replies; 2+ messages in thread
From: Peter Korsgaard @ 2009-09-24 10:23 UTC (permalink / raw)
  To: buildroot

>>>>> "Ormund" == Ormund Williams <ormundw@panix.com> writes:

Hi,

Thanks, committed with minor changes. There's a few things to keep in
mind for next time though:

1: You didn't have a signed-off-by: line - Please use git commit -s to
add it automatically when you commit.

2: You seem to be missing a -- seperator here, making the diffstat
output part of the commit message (which it shouldn't be). Did you send
the patch with git send-email?

 Ormund>  package/directfb/Config.in   |    6 ++++++
 Ormund>  package/directfb/directfb.mk |    3 +++
 Ormund>  2 files changed, 9 insertions(+), 0 deletions(-)

 Ormund> +config BR2_PACKAGE_DIRECTFB_I830
 Ormund> +	bool "compile i830 graphics driver"
 Ormund> +	default n
 
'n' is the default anyway, so there's no need to add it explicitly.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-09-24 10:23 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-09-24  1:13 [Buildroot] [PATCH] Add i830 graphics driver to DirectFB Ormund Williams
2009-09-24 10:23 ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox