From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] directive without effect
Date: Sun, 07 Sep 2008 20:57:10 +0200 [thread overview]
Message-ID: <87vdx7pywp.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <200809071913.19696.markus.heidelberg@web.de> (Markus Heidelberg's message of "Sun\, 7 Sep 2008 19\:13\:19 +0200")
>>>>> "Markus" == Markus Heidelberg <markus.heidelberg@web.de> writes:
Markus> Hello,
Markus> revision r19279 from 27.07.2007 uses an invalid variable name
Markus> CONFIG_BR2_PACKAGE_LINUX, so that the if-statement is always
Markus> false. I don't know the state, when the change was commited,
Markus> so I'm not sure what to do.
Markus> a) remove CONFIG_ because BR2_PACKAGE_LINUX does exist
Markus> b) revert the commit as it apparently didn't cause problems
Markus> without setting HOST_SOURCE
A seems to me to be the correct thing to do - The reason why there
haven't been any bug reports is that the line is only used when 'make
source' is used (E.G. for downloading all package sources in advance
so you can do the rest of the work offline), which is probably not a
really common thing to do ..
I'll commit a fix.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2008-09-07 18:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-07 17:13 [Buildroot] directive without effect Markus Heidelberg
2008-09-07 18:57 ` Peter Korsgaard [this message]
2008-09-07 21:59 ` Bernhard Reutner-Fischer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vdx7pywp.fsf@macbook.be.48ers.dk \
--to=jacmet@uclibc.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox