[Buildroot] directive without effect

[Buildroot] directive without effect

[Markus Heidelberg]

Hello,

revision r19279 from 27.07.2007 uses an invalid variable name
CONFIG_BR2_PACKAGE_LINUX, so that the if-statement is always false. I don't
know the state, when the change was commited, so I'm not sure what to do.

a) remove CONFIG_ because BR2_PACKAGE_LINUX does exist
b) revert the commit as it apparently didn't cause problems without setting
   HOST_SOURCE

Markus

[Buildroot] directive without effect

[Peter Korsgaard]

>>>>> "Markus" == Markus Heidelberg <markus.heidelberg@web.de> writes:

 Markus> Hello,

 Markus> revision r19279 from 27.07.2007 uses an invalid variable name
 Markus> CONFIG_BR2_PACKAGE_LINUX, so that the if-statement is always
 Markus> false. I don't know the state, when the change was commited,
 Markus> so I'm not sure what to do.

 Markus> a) remove CONFIG_ because BR2_PACKAGE_LINUX does exist
 Markus> b) revert the commit as it apparently didn't cause problems
 Markus> without setting HOST_SOURCE

A seems to me to be the correct thing to do - The reason why there
haven't been any bug reports is that the line is only used when 'make
source' is used (E.G. for downloading all package sources in advance
so you can do the rest of the work offline), which is probably not a
really common thing to do ..

I'll commit a fix.

-- 
Bye, Peter Korsgaard

[Buildroot] directive without effect

[Bernhard Reutner-Fischer]

On Sun, Sep 07, 2008 at 07:13:19PM +0200, Markus Heidelberg wrote:
>Hello,
>
>revision r19279 from 27.07.2007 uses an invalid variable name
>CONFIG_BR2_PACKAGE_LINUX, so that the if-statement is always false. I don't
>know the state, when the change was commited, so I'm not sure what to do.
>
>a) remove CONFIG_ because BR2_PACKAGE_LINUX does exist

indeed. Thanks for noticing it!