* [Buildroot] [PATCH 1/1] package/redis-plus-plus: needs threads
@ 2024-02-24 21:46 Fabrice Fontaine
2024-02-25 7:53 ` Peter Korsgaard
2024-03-17 19:44 ` Peter Korsgaard
0 siblings, 2 replies; 3+ messages in thread
From: Fabrice Fontaine @ 2024-02-24 21:46 UTC (permalink / raw)
To: buildroot; +Cc: Prabhu Sannachi, Fabrice Fontaine
redis-plus-plus unconditonally uses mutex and so needs threads since its
addition in commit c46df9de21e718a9ed6a2df2bb945c386695d3bf and
https://github.com/sewenew/redis-plus-plus/commit/1fa8f6bbfb24c8f328aa23ee1dd3c3f99c1b4caf:
In file included from /home/autobuild/autobuild/instance-5/output-1/build/redis-plus-plus-1.3.10/src/sw/redis++/connection_pool.h:27,
from /home/autobuild/autobuild/instance-5/output-1/build/redis-plus-plus-1.3.10/src/sw/redis++/connection_pool.cpp:17:
/home/autobuild/autobuild/instance-5/output-1/build/redis-plus-plus-1.3.10/src/sw/redis++/sentinel.h:95:10: error: 'mutex' in namespace 'std' does not name a type
95 | std::mutex _mutex;
| ^~~~~
Fixes: c46df9de21e718a9ed6a2df2bb945c386695d3bf
- http://autobuild.buildroot.org/results/cc4c54134e8a522b4c028aab4266f47cf862e2a9
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/redis-plus-plus/Config.in | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/package/redis-plus-plus/Config.in b/package/redis-plus-plus/Config.in
index 6a21aee2b3..64a84102d4 100644
--- a/package/redis-plus-plus/Config.in
+++ b/package/redis-plus-plus/Config.in
@@ -1,6 +1,7 @@
config BR2_PACKAGE_REDIS_PLUS_PLUS
bool "redis-plus-plus"
depends on BR2_INSTALL_LIBSTDCPP
+ depends on BR2_TOOLCHAIN_HAS_THREADS
select BR2_PACKAGE_HIREDIS
help
Redis client written in C++
@@ -11,5 +12,5 @@ config BR2_PACKAGE_REDIS_PLUS_PLUS
https://github.com/sewenew/redis-plus-plus
-comment "redis-plus-plus needs a toolchain w/ C++"
- depends on !BR2_INSTALL_LIBSTDCPP
+comment "redis-plus-plus needs a toolchain w/ C++, threads"
+ depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS
--
2.43.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/redis-plus-plus: needs threads
2024-02-24 21:46 [Buildroot] [PATCH 1/1] package/redis-plus-plus: needs threads Fabrice Fontaine
@ 2024-02-25 7:53 ` Peter Korsgaard
2024-03-17 19:44 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2024-02-25 7:53 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: Prabhu Sannachi, buildroot
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> redis-plus-plus unconditonally uses mutex and so needs threads since its
> addition in commit c46df9de21e718a9ed6a2df2bb945c386695d3bf and
> https://github.com/sewenew/redis-plus-plus/commit/1fa8f6bbfb24c8f328aa23ee1dd3c3f99c1b4caf:
> In file included from /home/autobuild/autobuild/instance-5/output-1/build/redis-plus-plus-1.3.10/src/sw/redis++/connection_pool.h:27,
> from /home/autobuild/autobuild/instance-5/output-1/build/redis-plus-plus-1.3.10/src/sw/redis++/connection_pool.cpp:17:
> /home/autobuild/autobuild/instance-5/output-1/build/redis-plus-plus-1.3.10/src/sw/redis++/sentinel.h:95:10: error: 'mutex' in namespace 'std' does not name a type
> 95 | std::mutex _mutex;
> | ^~~~~
> Fixes: c46df9de21e718a9ed6a2df2bb945c386695d3bf
> - http://autobuild.buildroot.org/results/cc4c54134e8a522b4c028aab4266f47cf862e2a9
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Committed, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/redis-plus-plus: needs threads
2024-02-24 21:46 [Buildroot] [PATCH 1/1] package/redis-plus-plus: needs threads Fabrice Fontaine
2024-02-25 7:53 ` Peter Korsgaard
@ 2024-03-17 19:44 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2024-03-17 19:44 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: Prabhu Sannachi, buildroot
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> redis-plus-plus unconditonally uses mutex and so needs threads since its
> addition in commit c46df9de21e718a9ed6a2df2bb945c386695d3bf and
> https://github.com/sewenew/redis-plus-plus/commit/1fa8f6bbfb24c8f328aa23ee1dd3c3f99c1b4caf:
> In file included from /home/autobuild/autobuild/instance-5/output-1/build/redis-plus-plus-1.3.10/src/sw/redis++/connection_pool.h:27,
> from /home/autobuild/autobuild/instance-5/output-1/build/redis-plus-plus-1.3.10/src/sw/redis++/connection_pool.cpp:17:
> /home/autobuild/autobuild/instance-5/output-1/build/redis-plus-plus-1.3.10/src/sw/redis++/sentinel.h:95:10: error: 'mutex' in namespace 'std' does not name a type
> 95 | std::mutex _mutex;
> | ^~~~~
> Fixes: c46df9de21e718a9ed6a2df2bb945c386695d3bf
> - http://autobuild.buildroot.org/results/cc4c54134e8a522b4c028aab4266f47cf862e2a9
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Committed to 2023.11.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-03-17 19:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-24 21:46 [Buildroot] [PATCH 1/1] package/redis-plus-plus: needs threads Fabrice Fontaine
2024-02-25 7:53 ` Peter Korsgaard
2024-03-17 19:44 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox