* [Buildroot] [PATCH 1/1] font-awesome compatible with fontconfig @ 2018-09-21 3:16 Benjamin Calderon 2018-09-21 3:56 ` Baruch Siach 0 siblings, 1 reply; 6+ messages in thread From: Benjamin Calderon @ 2018-09-21 3:16 UTC (permalink / raw) To: buildroot This commit installs font-awesome in the standard fonts directory making it available systemwide. Signed-off-by: Benjamin Calderon <benj.calderon@gmail.com> --- package/font-awesome/font-awesome.mk | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/package/font-awesome/font-awesome.mk b/package/font-awesome/font-awesome.mk index f39401041a..b1026b3c4d 100644 --- a/package/font-awesome/font-awesome.mk +++ b/package/font-awesome/font-awesome.mk @@ -7,12 +7,10 @@ FONT_AWESOME_VERSION = v4.7.0 FONT_AWESOME_SITE = $(call github,FortAwesome,Font-Awesome,$(FONT_AWESOME_VERSION)) FONT_AWESOME_LICENSE = OFL-1.1 (font), MIT (CSS, LESS and Sass files) -FONT_AWESOME_DIRECTORIES_LIST = css fonts less scss define FONT_AWESOME_INSTALL_TARGET_CMDS - mkdir -p $(TARGET_DIR)/usr/share/font-awesome/ - $(foreach d,$(FONT_AWESOME_DIRECTORIES_LIST),\ - cp -dpfr $(@D)/$(d) $(TARGET_DIR)/usr/share/font-awesome$(sep)) + mkdir -p $(TARGET_DIR)/usr/share/fonts/font-awesome/ + cp $(@D)/fonts/FontAwesome.otf $(TARGET_DIR)/usr/share/fonts/font-awesome endef $(eval $(generic-package)) -- 2.19.0 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] font-awesome compatible with fontconfig 2018-09-21 3:16 [Buildroot] [PATCH 1/1] font-awesome compatible with fontconfig Benjamin Calderon @ 2018-09-21 3:56 ` Baruch Siach 2018-09-21 4:02 ` Benjamín Calderón 0 siblings, 1 reply; 6+ messages in thread From: Baruch Siach @ 2018-09-21 3:56 UTC (permalink / raw) To: buildroot Hi Benjamin, Benjamin Calderon writes: > This commit installs font-awesome in the standard fonts directory > making it available systemwide. > > Signed-off-by: Benjamin Calderon <benj.calderon@gmail.com> > --- > package/font-awesome/font-awesome.mk | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/package/font-awesome/font-awesome.mk b/package/font-awesome/font-awesome.mk > index f39401041a..b1026b3c4d 100644 > --- a/package/font-awesome/font-awesome.mk > +++ b/package/font-awesome/font-awesome.mk > @@ -7,12 +7,10 @@ > FONT_AWESOME_VERSION = v4.7.0 > FONT_AWESOME_SITE = $(call github,FortAwesome,Font-Awesome,$(FONT_AWESOME_VERSION)) > FONT_AWESOME_LICENSE = OFL-1.1 (font), MIT (CSS, LESS and Sass files) > -FONT_AWESOME_DIRECTORIES_LIST = css fonts less scss > > define FONT_AWESOME_INSTALL_TARGET_CMDS > - mkdir -p $(TARGET_DIR)/usr/share/font-awesome/ > - $(foreach d,$(FONT_AWESOME_DIRECTORIES_LIST),\ > - cp -dpfr $(@D)/$(d) $(TARGET_DIR)/usr/share/font-awesome$(sep)) > + mkdir -p $(TARGET_DIR)/usr/share/fonts/font-awesome/ > + cp $(@D)/fonts/FontAwesome.otf $(TARGET_DIR)/usr/share/fonts/font-awesome What does this patch fix? What about the fonts in other directories? > endef > > $(eval $(generic-package)) baruch -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il - ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] font-awesome compatible with fontconfig 2018-09-21 3:56 ` Baruch Siach @ 2018-09-21 4:02 ` Benjamín Calderón 2018-09-21 5:03 ` Baruch Siach 0 siblings, 1 reply; 6+ messages in thread From: Benjamín Calderón @ 2018-09-21 4:02 UTC (permalink / raw) To: buildroot the standard location for fonts is /usr/share/fonts/* and whatever is there can be used by other programs that use fontconfig (Qt5 in my case) This patch fixed the directory where font-awesome is installed from /usr/share/font-awesome to /usr/share/fonts/font-awesome thus it can be accessed by other applications and appears when running fc-list. I have tested it with Qt5 in rpi3 and with fc-list on qemu_x86_64 ____ *Benjam?n C. Calder?n* On Thu, Sep 20, 2018 at 11:56 PM Baruch Siach <baruch@tkos.co.il> wrote: > Hi Benjamin, > > Benjamin Calderon writes: > > This commit installs font-awesome in the standard fonts directory > > making it available systemwide. > > > > Signed-off-by: Benjamin Calderon <benj.calderon@gmail.com> > > --- > > package/font-awesome/font-awesome.mk | 6 ++---- > > 1 file changed, 2 insertions(+), 4 deletions(-) > > > > diff --git a/package/font-awesome/font-awesome.mk > b/package/font-awesome/font-awesome.mk > > index f39401041a..b1026b3c4d 100644 > > --- a/package/font-awesome/font-awesome.mk > > +++ b/package/font-awesome/font-awesome.mk > > @@ -7,12 +7,10 @@ > > FONT_AWESOME_VERSION = v4.7.0 > > FONT_AWESOME_SITE = $(call > github,FortAwesome,Font-Awesome,$(FONT_AWESOME_VERSION)) > > FONT_AWESOME_LICENSE = OFL-1.1 (font), MIT (CSS, LESS and Sass files) > > -FONT_AWESOME_DIRECTORIES_LIST = css fonts less scss > > > > define FONT_AWESOME_INSTALL_TARGET_CMDS > > - mkdir -p $(TARGET_DIR)/usr/share/font-awesome/ > > - $(foreach d,$(FONT_AWESOME_DIRECTORIES_LIST),\ > > - cp -dpfr $(@D)/$(d) > $(TARGET_DIR)/usr/share/font-awesome$(sep)) > > + mkdir -p $(TARGET_DIR)/usr/share/fonts/font-awesome/ > > + cp $(@D)/fonts/FontAwesome.otf > $(TARGET_DIR)/usr/share/fonts/font-awesome > > What does this patch fix? What about the fonts in other directories? > > > endef > > > > $(eval $(generic-package)) > > baruch > > -- > http://baruch.siach.name/blog/ ~. .~ Tk Open > Systems > =}------------------------------------------------ooO--U--Ooo------------{= > - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il - > -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180921/f99f4c66/attachment.html> ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] font-awesome compatible with fontconfig 2018-09-21 4:02 ` Benjamín Calderón @ 2018-09-21 5:03 ` Baruch Siach [not found] ` <CAOt0XSc31keNicgWfc4jcn=-z43D8Vdb=0SCnVtL4POJz1QzoQ@mail.gmail.com> 0 siblings, 1 reply; 6+ messages in thread From: Baruch Siach @ 2018-09-21 5:03 UTC (permalink / raw) To: buildroot Hi Benjam?n, Benjam?n Calder?n writes: > the standard location for fonts is /usr/share/fonts/* and whatever is there > can be used by other programs that use fontconfig (Qt5 in my case) > This patch fixed the directory where font-awesome is installed from > /usr/share/font-awesome to /usr/share/fonts/font-awesome thus it can be > accessed by other applications and appears when running fc-list. > > I have tested it with Qt5 in rpi3 and with fc-list on qemu_x86_64 > > On Thu, Sep 20, 2018 at 11:56 PM Baruch Siach <baruch@tkos.co.il> wrote: >> Benjamin Calderon writes: >> > This commit installs font-awesome in the standard fonts directory >> > making it available systemwide. >> > >> > Signed-off-by: Benjamin Calderon <benj.calderon@gmail.com> >> > --- >> > package/font-awesome/font-awesome.mk | 6 ++---- >> > 1 file changed, 2 insertions(+), 4 deletions(-) >> > >> > diff --git a/package/font-awesome/font-awesome.mk >> b/package/font-awesome/font-awesome.mk >> > index f39401041a..b1026b3c4d 100644 >> > --- a/package/font-awesome/font-awesome.mk >> > +++ b/package/font-awesome/font-awesome.mk >> > @@ -7,12 +7,10 @@ >> > FONT_AWESOME_VERSION = v4.7.0 >> > FONT_AWESOME_SITE = $(call >> github,FortAwesome,Font-Awesome,$(FONT_AWESOME_VERSION)) >> > FONT_AWESOME_LICENSE = OFL-1.1 (font), MIT (CSS, LESS and Sass files) >> > -FONT_AWESOME_DIRECTORIES_LIST = css fonts less scss >> > >> > define FONT_AWESOME_INSTALL_TARGET_CMDS >> > - mkdir -p $(TARGET_DIR)/usr/share/font-awesome/ >> > - $(foreach d,$(FONT_AWESOME_DIRECTORIES_LIST),\ >> > - cp -dpfr $(@D)/$(d) >> $(TARGET_DIR)/usr/share/font-awesome$(sep)) >> > + mkdir -p $(TARGET_DIR)/usr/share/fonts/font-awesome/ So why do we need this directory? And what about fonts in the directories listed in FONT_AWESOME_DIRECTORIES_LIST? Aren't they useful anymore? If so, please update the license. baruch >> > + cp $(@D)/fonts/FontAwesome.otf >> $(TARGET_DIR)/usr/share/fonts/font-awesome >> >> What does this patch fix? What about the fonts in other directories? >> >> > endef >> > >> > $(eval $(generic-package)) -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il - ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <CAOt0XSc31keNicgWfc4jcn=-z43D8Vdb=0SCnVtL4POJz1QzoQ@mail.gmail.com>]
* [Buildroot] [PATCH 1/1] font-awesome compatible with fontconfig [not found] ` <CAOt0XSc31keNicgWfc4jcn=-z43D8Vdb=0SCnVtL4POJz1QzoQ@mail.gmail.com> @ 2018-09-21 14:46 ` Baruch Siach 2018-09-21 14:50 ` Benjamín Calderón 0 siblings, 1 reply; 6+ messages in thread From: Baruch Siach @ 2018-09-21 14:46 UTC (permalink / raw) To: buildroot Hi Benjam?n, Please keep the list on Cc. Benjam?n Calder?n writes: > The directory font-awesome inside /usr/share/fonts is just for separation > of concerns. That's the practice of other font packages and if we where to > upgrade to font-awesome 5 which includes more than one file it would all be > contained in one folder. But this folder is empty after you commit. Why create it? > The other folders are not necessary because they are actually useless in > this context. CSS needs to be in a server root to be used together with > HTML pages. Less and scss would need processing and thus are more of > "source code" than anything else for web development, again, very unlikely > to be used on an embedded system. > > Will modify the path to fix the license. Please also mention the information about the other directories in the commit log. baruch > On Fri, Sep 21, 2018 at 1:03 AM Baruch Siach <baruch@tkos.co.il> wrote: > >> Hi Benjam?n, >> >> Benjam?n Calder?n writes: >> > the standard location for fonts is /usr/share/fonts/* and whatever is >> there >> > can be used by other programs that use fontconfig (Qt5 in my case) >> > This patch fixed the directory where font-awesome is installed from >> > /usr/share/font-awesome to /usr/share/fonts/fontawesome thus it can be >> > accessed by other applications and appears when running fc-list. >> > >> > I have tested it with Qt5 in rpi3 and with fc-list on qemu_x86_64 >> > >> > On Thu, Sep 20, 2018 at 11:56 PM Baruch Siach <baruch@tkos.co.il> wrote: >> >> Benjamin Calderon writes: >> >> > This commit installs font-awesome in the standard fonts directory >> >> > making it available systemwide. >> >> > >> >> > Signed-off-by: Benjamin Calderon <benj.calderon@gmail.com> >> >> > --- >> >> > package/font-awesome/font-awesome.mk | 6 ++---- >> >> > 1 file changed, 2 insertions(+), 4 deletions(-) >> >> > >> >> > diff --git a/package/font-awesome/font-awesome.mk >> >> b/package/font-awesome/font-awesome.mk >> >> > index f39401041a..b1026b3c4d 100644 >> >> > --- a/package/font-awesome/font-awesome.mk >> >> > +++ b/package/font-awesome/font-awesome.mk >> >> > @@ -7,12 +7,10 @@ >> >> > FONT_AWESOME_VERSION = v4.7.0 >> >> > FONT_AWESOME_SITE = $(call >> >> github,FortAwesome,Font-Awesome,$(FONT_AWESOME_VERSION)) >> >> > FONT_AWESOME_LICENSE = OFL-1.1 (font), MIT (CSS, LESS and Sass files) >> >> > -FONT_AWESOME_DIRECTORIES_LIST = css fonts less scss >> >> > >> >> > define FONT_AWESOME_INSTALL_TARGET_CMDS >> >> > - mkdir -p $(TARGET_DIR)/usr/share/font-awesome/ >> >> > - $(foreach d,$(FONT_AWESOME_DIRECTORIES_LIST),\ >> >> > - cp -dpfr $(@D)/$(d) >> >> $(TARGET_DIR)/usr/share/font-awesome$(sep)) >> >> > + mkdir -p $(TARGET_DIR)/usr/share/fonts/font-awesome/ >> >> So why do we need this directory? And what about fonts in the >> directories listed in FONT_AWESOME_DIRECTORIES_LIST? Aren't they useful >> anymore? If so, please update the license. >> >> baruch >> >> >> > + cp $(@D)/fonts/FontAwesome.otf >> >> $(TARGET_DIR)/usr/share/fonts/font-awesome >> >> >> >> What does this patch fix? What about the fonts in other directories? >> >> >> >> > endef >> >> > >> >> > $(eval $(generic-package)) -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il - ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] font-awesome compatible with fontconfig 2018-09-21 14:46 ` Baruch Siach @ 2018-09-21 14:50 ` Benjamín Calderón 0 siblings, 0 replies; 6+ messages in thread From: Benjamín Calderón @ 2018-09-21 14:50 UTC (permalink / raw) To: buildroot Baruch, sorry for missing the list. Need to get myself a better email client. Just noticed what you mentioned about /usr/share/fonts/font-awesome being empty, my mistake. Will add the information about the other directories in the commit message Thanks ____ *Benjam?n C. Calder?n* On Fri, Sep 21, 2018 at 10:46 AM Baruch Siach <baruch@tkos.co.il> wrote: > Hi Benjam?n, > > Please keep the list on Cc. > > Benjam?n Calder?n writes: > > The directory font-awesome inside /usr/share/fonts is just for separation > > of concerns. That's the practice of other font packages and if we where > to > > upgrade to font-awesome 5 which includes more than one file it would all > be > > contained in one folder. > > But this folder is empty after you commit. Why create it? > > > The other folders are not necessary because they are actually useless in > > this context. CSS needs to be in a server root to be used together with > > HTML pages. Less and scss would need processing and thus are more of > > "source code" than anything else for web development, again, very > unlikely > > to be used on an embedded system. > > > > Will modify the path to fix the license. > > Please also mention the information about the other directories in the > commit log. > > baruch > > > On Fri, Sep 21, 2018 at 1:03 AM Baruch Siach <baruch@tkos.co.il> wrote: > > > >> Hi Benjam?n, > >> > >> Benjam?n Calder?n writes: > >> > the standard location for fonts is /usr/share/fonts/* and whatever is > >> there > >> > can be used by other programs that use fontconfig (Qt5 in my case) > >> > This patch fixed the directory where font-awesome is installed from > >> > /usr/share/font-awesome to /usr/share/fonts/fontawesome thus it can be > >> > accessed by other applications and appears when running fc-list. > >> > > >> > I have tested it with Qt5 in rpi3 and with fc-list on qemu_x86_64 > >> > > >> > On Thu, Sep 20, 2018 at 11:56 PM Baruch Siach <baruch@tkos.co.il> > wrote: > >> >> Benjamin Calderon writes: > >> >> > This commit installs font-awesome in the standard fonts directory > >> >> > making it available systemwide. > >> >> > > >> >> > Signed-off-by: Benjamin Calderon <benj.calderon@gmail.com> > >> >> > --- > >> >> > package/font-awesome/font-awesome.mk | 6 ++---- > >> >> > 1 file changed, 2 insertions(+), 4 deletions(-) > >> >> > > >> >> > diff --git a/package/font-awesome/font-awesome.mk > >> >> b/package/font-awesome/font-awesome.mk > >> >> > index f39401041a..b1026b3c4d 100644 > >> >> > --- a/package/font-awesome/font-awesome.mk > >> >> > +++ b/package/font-awesome/font-awesome.mk > >> >> > @@ -7,12 +7,10 @@ > >> >> > FONT_AWESOME_VERSION = v4.7.0 > >> >> > FONT_AWESOME_SITE = $(call > >> >> github,FortAwesome,Font-Awesome,$(FONT_AWESOME_VERSION)) > >> >> > FONT_AWESOME_LICENSE = OFL-1.1 (font), MIT (CSS, LESS and Sass > files) > >> >> > -FONT_AWESOME_DIRECTORIES_LIST = css fonts less scss > >> >> > > >> >> > define FONT_AWESOME_INSTALL_TARGET_CMDS > >> >> > - mkdir -p $(TARGET_DIR)/usr/share/font-awesome/ > >> >> > - $(foreach d,$(FONT_AWESOME_DIRECTORIES_LIST),\ > >> >> > - cp -dpfr $(@D)/$(d) > >> >> $(TARGET_DIR)/usr/share/font-awesome$(sep)) > >> >> > + mkdir -p $(TARGET_DIR)/usr/share/fonts/font-awesome/ > >> > >> So why do we need this directory? And what about fonts in the > >> directories listed in FONT_AWESOME_DIRECTORIES_LIST? Aren't they useful > >> anymore? If so, please update the license. > >> > >> baruch > >> > >> >> > + cp $(@D)/fonts/FontAwesome.otf > >> >> $(TARGET_DIR)/usr/share/fonts/font-awesome > >> >> > >> >> What does this patch fix? What about the fonts in other directories? > >> >> > >> >> > endef > >> >> > > >> >> > $(eval $(generic-package)) > > -- > http://baruch.siach.name/blog/ ~. .~ Tk Open > Systems > =}------------------------------------------------ooO--U--Ooo------------{= > - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il - > -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180921/3ef59117/attachment.html> ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-09-21 14:50 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-21 3:16 [Buildroot] [PATCH 1/1] font-awesome compatible with fontconfig Benjamin Calderon
2018-09-21 3:56 ` Baruch Siach
2018-09-21 4:02 ` Benjamín Calderón
2018-09-21 5:03 ` Baruch Siach
[not found] ` <CAOt0XSc31keNicgWfc4jcn=-z43D8Vdb=0SCnVtL4POJz1QzoQ@mail.gmail.com>
2018-09-21 14:46 ` Baruch Siach
2018-09-21 14:50 ` Benjamín Calderón
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox