Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/2] prosody: fix build with musl libc
@ 2018-04-03  4:45 Baruch Siach
  2018-04-03  4:45 ` [Buildroot] [PATCH 2/2] prosody: needs MMU Baruch Siach
  2018-04-03 13:50 ` [Buildroot] [PATCH 1/2] prosody: fix build with musl libc Peter Korsgaard
  0 siblings, 2 replies; 4+ messages in thread
From: Baruch Siach @ 2018-04-03  4:45 UTC (permalink / raw)
  To: buildroot

musl libc does not provide the mallinfo() API. Define WITHOUT_MALLINFO
to skip the code using it.

Fixes:
http://autobuild.buildroot.net/results/42c/42cd6e3be761d1cb358bc50acd7fa58c8aa1c750/
http://autobuild.buildroot.net/results/29d/29d8dcbe013e549a865c0c5953272dab1fe5f777/
http://autobuild.buildroot.net/results/a6d/a6deb7440f80b072432c0f9c048e59abe4edf1c0/

Cc: Dushara Jayasinghe <nidujay@gmail.com>
Cc: Francois Perrad <francois.perrad@gadz.org>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 package/prosody/prosody.mk | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/package/prosody/prosody.mk b/package/prosody/prosody.mk
index c5a83081dcfa..d95578253d6d 100644
--- a/package/prosody/prosody.mk
+++ b/package/prosody/prosody.mk
@@ -10,12 +10,15 @@ PROSODY_LICENSE = MIT
 PROSODY_LICENSE_FILES = COPYING
 PROSODY_DEPENDENCIES = host-luainterpreter luainterpreter libidn openssl
 
+PROSODY_CFLAGS = $(TARGET_CFLAGS) -fPIC -std=c99 \
+	$(if BR2_TOOLCHAIN_USES_MUSL,-DWITHOUT_MALLINFO)
+
 PROSODY_CONF_OPTS = \
 	--with-lua-bin=$(HOST_DIR)/usr/bin \
 	--with-lua=$(STAGING_DIR)/usr \
 	--lua-version=$(LUAINTERPRETER_ABIVER) \
 	--c-compiler=$(TARGET_CC) \
-	--cflags="$(TARGET_CFLAGS) -fPIC -std=c99" \
+	--cflags="$(PROSODY_CFLAGS)" \
 	--linker=$(TARGET_CC) \
 	--ldflags="$(TARGET_LDFLAGS) -shared" \
 	--sysconfdir=/etc/prosody \
-- 
2.16.2

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH 2/2] prosody: needs MMU
  2018-04-03  4:45 [Buildroot] [PATCH 1/2] prosody: fix build with musl libc Baruch Siach
@ 2018-04-03  4:45 ` Baruch Siach
  2018-04-03 13:51   ` Peter Korsgaard
  2018-04-03 13:50 ` [Buildroot] [PATCH 1/2] prosody: fix build with musl libc Peter Korsgaard
  1 sibling, 1 reply; 4+ messages in thread
From: Baruch Siach @ 2018-04-03  4:45 UTC (permalink / raw)
  To: buildroot

prosody POSIX support code calls fork() unconditionally.

prosody also uses the mallinfo() API, but uClibc does not provide that
for no-MMU targets.

Fixes:
http://autobuild.buildroot.net/results/2d0/2d0f97e41cc1d4c9c7a0eacd4eec8bad6f00bcff/
http://autobuild.buildroot.net/results/f69/f69dfb1a7d1163b402b1f9bef045891c229539e5/

Cc: Dushara Jayasinghe <nidujay@gmail.com>
Cc: Francois Perrad <francois.perrad@gadz.org>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 package/prosody/Config.in | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/package/prosody/Config.in b/package/prosody/Config.in
index 1bc79b7f2a78..ef26e2750b66 100644
--- a/package/prosody/Config.in
+++ b/package/prosody/Config.in
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_PROSODY
 	bool "prosody"
+	depends on BR2_USE_MMU # fork
 	depends on BR2_PACKAGE_HAS_LUAINTERPRETER
 	select BR2_PACKAGE_LUAEXPAT # runtime
 	select BR2_PACKAGE_LUASEC # runtime
@@ -16,3 +17,4 @@ config BR2_PACKAGE_PROSODY
 
 comment "prosody needs the lua interpreter"
 	depends on !BR2_PACKAGE_HAS_LUAINTERPRETER
+	depends on BR2_USE_MMU
-- 
2.16.2

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH 1/2] prosody: fix build with musl libc
  2018-04-03  4:45 [Buildroot] [PATCH 1/2] prosody: fix build with musl libc Baruch Siach
  2018-04-03  4:45 ` [Buildroot] [PATCH 2/2] prosody: needs MMU Baruch Siach
@ 2018-04-03 13:50 ` Peter Korsgaard
  1 sibling, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2018-04-03 13:50 UTC (permalink / raw)
  To: buildroot

>>>>> "Baruch" == Baruch Siach <baruch@tkos.co.il> writes:

 > musl libc does not provide the mallinfo() API. Define WITHOUT_MALLINFO
 > to skip the code using it.

 > Fixes:
 > http://autobuild.buildroot.net/results/42c/42cd6e3be761d1cb358bc50acd7fa58c8aa1c750/
 > http://autobuild.buildroot.net/results/29d/29d8dcbe013e549a865c0c5953272dab1fe5f777/
 > http://autobuild.buildroot.net/results/a6d/a6deb7440f80b072432c0f9c048e59abe4edf1c0/

 > Cc: Dushara Jayasinghe <nidujay@gmail.com>
 > Cc: Francois Perrad <francois.perrad@gadz.org>
 > Signed-off-by: Baruch Siach <baruch@tkos.co.il>

Committed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH 2/2] prosody: needs MMU
  2018-04-03  4:45 ` [Buildroot] [PATCH 2/2] prosody: needs MMU Baruch Siach
@ 2018-04-03 13:51   ` Peter Korsgaard
  0 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2018-04-03 13:51 UTC (permalink / raw)
  To: buildroot

>>>>> "Baruch" == Baruch Siach <baruch@tkos.co.il> writes:

 > prosody POSIX support code calls fork() unconditionally.
 > prosody also uses the mallinfo() API, but uClibc does not provide that
 > for no-MMU targets.

 > Fixes:
 > http://autobuild.buildroot.net/results/2d0/2d0f97e41cc1d4c9c7a0eacd4eec8bad6f00bcff/
 > http://autobuild.buildroot.net/results/f69/f69dfb1a7d1163b402b1f9bef045891c229539e5/

 > Cc: Dushara Jayasinghe <nidujay@gmail.com>
 > Cc: Francois Perrad <francois.perrad@gadz.org>
 > Signed-off-by: Baruch Siach <baruch@tkos.co.il>

Committed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-04-03 13:51 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-04-03  4:45 [Buildroot] [PATCH 1/2] prosody: fix build with musl libc Baruch Siach
2018-04-03  4:45 ` [Buildroot] [PATCH 2/2] prosody: needs MMU Baruch Siach
2018-04-03 13:51   ` Peter Korsgaard
2018-04-03 13:50 ` [Buildroot] [PATCH 1/2] prosody: fix build with musl libc Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox