Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] rabbitmq-c: openssl/popt sub-options don't work in stat_ic linking
Date: Wed, 17 May 2017 10:57:13 +0200	[thread overview]
Message-ID: <87wp9f6ety.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1494796962-24132-1-git-send-email-thomas.petazzoni@free-electrons.com> (Thomas Petazzoni's message of "Sun, 14 May 2017 23:22:42 +0200")

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 > rabbitmq-c currently fails to build in a number of static linking
 > situations, due to two issues:

 >  - CMake FindOpenSSL module is buggy. Even though it uses pkg-config,
 >    it doesn't use the information returned by pkg-config, and
 >    therefore doesn't know about second order libraries that need be
 >    part of the link for static linking to succeed. Due to this, -lz is
 >    not passed, and therefore rabbitmq-c fails when linking against
 >    libssl/libcrypto. This issue has been reported to upstream CMake at
 >    https://gitlab.kitware.com/cmake/cmake/issues/16885.

 >  - popt might use libintl, but CMake doesn't know about that. For
 >    autotools based packages, we typically work around this by passing
 >    LIBS=, but CMake apparently has no equivalent to LIBS=.

 > To workaround this, we only use the OpenSSL and Popt optional
 > dependencies in dynamic linking situations.

I was hesitating if it wasn't better to just make rabbitmq-c depend on
!static, but OK.

Committed after fixing subject, thanks.

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2017-05-17  8:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-14 21:22 [Buildroot] [PATCH] rabbitmq-c: openssl/popt sub-options don't work in stat_ic linking Thomas Petazzoni
2017-05-17  8:57 ` Peter Korsgaard [this message]
2017-05-17 20:43 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wp9f6ety.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox