From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4 01/12] toolchain/gcc: Add host-{flex, bison} dependencies for GCC 4.2, 4.3, 4.4
Date: Sat, 04 May 2013 22:58:20 +0200 [thread overview]
Message-ID: <87wqreqx77.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1367524293-32081-2-git-send-email-mjonker@synopsys.com> (Mischa Jonker's message of "Thu, 2 May 2013 21:51:22 +0200")
>>>>> "Mischa" == Mischa Jonker <Mischa.Jonker@synopsys.com> writes:
Mischa> Note that gcc doesn't use the package infrastructure, and needs proper
Mischa> $(HOST_MAKE_ENV) and $(TARGET_MAKE_ENV) to be able to find host-flex/
Mischa> host-bison.
Mischa> Original patch by Thomas Petazzoni.
Mischa> Signed-off-by: Mischa Jonker <mjonker@synopsys.com>
Mischa> ---
Mischa> toolchain/gcc/gcc-uclibc-4.x.mk | 32 ++++++++++++++++++++------------
Mischa> 1 files changed, 20 insertions(+), 12 deletions(-)
Mischa> diff --git a/toolchain/gcc/gcc-uclibc-4.x.mk b/toolchain/gcc/gcc-uclibc-4.x.mk
Mischa> index fc11ad4..0a96211 100644
Mischa> --- a/toolchain/gcc/gcc-uclibc-4.x.mk
Mischa> +++ b/toolchain/gcc/gcc-uclibc-4.x.mk
Mischa> @@ -170,6 +170,14 @@ endif
Mischa> GCC_HOST_PREREQ += host-mpc
Mischa> endif
Mischa> +ifneq ($(findstring x4.2.,x$(GCC_VERSION)),x4.2.)
Mischa> +ifneq ($(findstring x4.3.,x$(GCC_VERSION)),x4.3.)
Mischa> +ifneq ($(findstring x4.4.,x$(GCC_VERSION)),x4.4.)
Mischa> +GCC_HOST_PREREQ = host-flex host-bison
Ehh, two things:
- This implements the opposite logic of what the commit message says
(E.G. adds flex/bison if the version ISN'T 4.2/4.3/4.4)
- It overrides GCC_HOST_PREREQ instead of appending to it even though
the line just above already appends something.
It isn't clear to me what the gcc version logic should be, and if it is
somehow related to ARC - I don't recall any autobuilder failures
regarding missing flex/bison.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2013-05-04 20:58 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-02 19:51 [Buildroot] [PATCH v4 00/12] ARC port Mischa Jonker
2013-05-02 19:51 ` [Buildroot] [PATCH v4 01/12] toolchain/gcc: Add host-{flex, bison} dependencies for GCC 4.2, 4.3, 4.4 Mischa Jonker
2013-05-04 20:58 ` Peter Korsgaard [this message]
2013-05-07 7:54 ` Thomas Petazzoni
2013-05-02 19:51 ` [Buildroot] [PATCH v4 02/12] arc: Add ARC and ARC BE architecture Mischa Jonker
2013-05-04 21:02 ` Peter Korsgaard
2013-05-02 19:51 ` [Buildroot] [PATCH v4 03/12] arc: Add option for ARC-specific download site Mischa Jonker
2013-05-04 21:04 ` Peter Korsgaard
2013-05-02 19:51 ` [Buildroot] [PATCH v4 04/12] arc: Add support for ARC-specific binutils Mischa Jonker
2013-05-04 21:08 ` Peter Korsgaard
2013-05-02 19:51 ` [Buildroot] [PATCH v4 05/12] arc: disable Crosstool-NG for ARC Mischa Jonker
2013-05-04 21:09 ` Peter Korsgaard
2013-05-02 19:51 ` [Buildroot] [PATCH v4 06/12] arc: add gcc " Mischa Jonker
2013-05-04 21:11 ` Peter Korsgaard
2013-05-02 19:51 ` [Buildroot] [PATCH v4 07/12] arc: Add support for ARC-specific uClibc Mischa Jonker
2013-05-04 21:21 ` Peter Korsgaard
2013-05-02 19:51 ` [Buildroot] [PATCH v4 08/12] arc: Make sure that libgcc doesn't get included when it doesn't exist yet Mischa Jonker
2013-05-04 21:22 ` Peter Korsgaard
2013-05-02 19:51 ` [Buildroot] [PATCH v4 09/12] toolchain/gcc: Only enable --with-float when it makes sense Mischa Jonker
2013-05-04 21:22 ` Peter Korsgaard
2013-05-02 19:51 ` [Buildroot] [PATCH v4 10/12] toolchain/toolchain-buildroot: Disable NPTL for ARC Mischa Jonker
2013-05-04 21:23 ` Peter Korsgaard
2013-05-02 19:51 ` [Buildroot] [PATCH v4 11/12] arc: Add arc, arcbe to gnuconfig Mischa Jonker
2013-05-04 21:23 ` Peter Korsgaard
2013-05-02 19:51 ` [Buildroot] [PATCH v4 12/12] kernel-headers: Add support for ARC kernel headers Mischa Jonker
2013-05-04 21:24 ` Peter Korsgaard
2013-05-03 18:41 ` [Buildroot] [PATCH v4 00/12] ARC port Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wqreqx77.fsf@dell.be.48ers.dk \
--to=jacmet@uclibc.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox