From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/1] libplayer: fix cflags
Date: Sun, 10 Jun 2012 22:23:10 +0200 [thread overview]
Message-ID: <87wr3ehq6p.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <1339328813-6269-2-git-send-email-s.martin49@gmail.com> (Samuel Martin's message of "Sun, 10 Jun 2012 13:46:46 +0200")
>>>>> "Samuel" == Samuel Martin <s.martin49@gmail.com> writes:
Samuel> Explicitly run pkg-config to add some include directories to the cflags
Samuel> when gstreamer support is enabled.
Samuel> This patch fixes the following unfound headers:
Samuel> - glib.h
Samuel> - glibconfig.h
Samuel> - gst/gst.h
What problem is this solving exactly? I don't recall seeing any failures
on the autobuilders, and host-pkg-config + libglib2 are already
dependencies of gstreamer, so it shouldn't be needed to list them
explicitly.
From a quick look at the (handwritten) configure script, is seem to get
cflags / libs from pkg-config as well.
Samuel> diff --git a/package/libplayer/libplayer.mk b/package/libplayer/libplayer.mk
Samuel> index 093821e..643c7bb 100644
Samuel> --- a/package/libplayer/libplayer.mk
Samuel> +++ b/package/libplayer/libplayer.mk
Samuel> @@ -30,8 +30,10 @@ else
Samuel> endif
Samuel> ifeq ($(BR2_PACKAGE_LIBPLAYER_GSTREAMER),y)
Samuel> - LIBPLAYER_DEPENDENCIES += gstreamer
Samuel> + LIBPLAYER_DEPENDENCIES += host-pkg-config libglib2 gstreamer
Samuel> LIBPLAYER_CONF_OPT += --enable-gstreamer
Samuel> + LIBPLAYER_MAKE_OPT += \
Samuel> + CFLAGS+="`$(PKG_CONFIG_HOST_BINARY) --cflags glib-2.0 gstreamer-0.10`"
Samuel> else
Samuel> LIBPLAYER_CONF_OPT += --disable-gstreamer
Samuel> endif
Samuel> --
Samuel> 1.7.10.4
Samuel> _______________________________________________
Samuel> buildroot mailing list
Samuel> buildroot at busybox.net
Samuel> http://lists.busybox.net/mailman/listinfo/buildroot
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2012-06-10 20:23 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-10 11:46 [Buildroot] [PATCH 1/1] omap-u-boot-utils: fix visibility in menuconfig Samuel Martin
2012-06-10 11:46 ` [Buildroot] [PATCH v2 1/1] libplayer: fix cflags Samuel Martin
2012-06-10 20:23 ` Peter Korsgaard [this message]
2012-06-12 19:27 ` Samuel Martin
2012-06-13 6:41 ` Peter Korsgaard
2012-06-10 11:46 ` [Buildroot] [PATCH v3 0/6] OpenCV update and CPU fetures Samuel Martin
2012-06-10 11:46 ` [Buildroot] [PATCH v3 1/6] target: add symbols for i386/x86_64 cpu features Samuel Martin
2012-06-12 6:02 ` Arnout Vandecappelle
2012-06-12 6:05 ` Arnout Vandecappelle
2012-06-13 22:38 ` Samuel Martin
2012-06-10 11:46 ` [Buildroot] [PATCH v3 2/6] target: add symbols for PowerPC " Samuel Martin
2012-06-12 6:15 ` Arnout Vandecappelle
2012-06-12 9:48 ` Gustavo Zacarias
2012-06-13 22:44 ` Samuel Martin
2012-06-10 11:46 ` [Buildroot] [PATCH v3 3/6] libevas: refactor *_CONF_OPT assignment with cpu-feature options Samuel Martin
2012-06-10 11:46 ` [Buildroot] [PATCH v3 4/6] sdl_gfx: " Samuel Martin
2012-06-10 11:46 ` [Buildroot] [PATCH v3 5/6] sdl_sound: " Samuel Martin
2012-06-10 11:46 ` [Buildroot] [PATCH v3 6/6] opencv: bump to version 2.4.1 Samuel Martin
2012-06-10 14:41 ` Samuel Martin
2012-06-10 13:04 ` [Buildroot] [PATCH 1/1] omap-u-boot-utils: fix visibility in menuconfig Thomas Petazzoni
2012-06-10 20:14 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wr3ehq6p.fsf@macbook.be.48ers.dk \
--to=jacmet@uclibc.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox