* [Buildroot] [PATCH] Fix problem with undefined umode_t type in 3.3 kernel headers
@ 2012-03-24 9:14 spdawson at gmail.com
2012-03-29 8:47 ` Peter Korsgaard
0 siblings, 1 reply; 2+ messages in thread
From: spdawson at gmail.com @ 2012-03-24 9:14 UTC (permalink / raw)
To: buildroot
From: Simon Dawson <spdawson@gmail.com>
The 3.3 kernel headers define the umode_t type within a __KERNEL__
preprocessor ifdef region. This results in a broken kernel header in the
buildroot toolchain.
Signed-off-by: Simon Dawson <spdawson@gmail.com>
---
| 22 ++++++++++++++++++++
1 files changed, 22 insertions(+), 0 deletions(-)
create mode 100644 toolchain/kernel-headers/linux-3.3-fix-umode_t.patch
--git a/toolchain/kernel-headers/linux-3.3-fix-umode_t.patch b/toolchain/kernel-headers/linux-3.3-fix-umode_t.patch
new file mode 100644
index 0000000..9663662
--- /dev/null
+++ b/toolchain/kernel-headers/linux-3.3-fix-umode_t.patch
@@ -0,0 +1,22 @@
+Fix a problem with the 3.3 kernel headers. Specifically, the umode_t type
+is defined within a __KERNEL__ preprocessor ifdef region, and so the type
+is not usable by non-kernel code. Visit the following URL for more details.
+
+* http://www.spinics.net/lists/linux-fsdevel/msg52638.html
+
+The commit that created the problem can be seen at the following URL.
+
+* http://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=commitdiff;h=0583fcc96bb117763c0fa74c123573c0112dec65
+
+diff -Nur a/include/linux/ext2_fs.h b/include/linux/ext2_fs.h
+--- a/include/linux/ext2_fs.h 2012-03-18 23:15:34.000000000 +0000
++++ b/include/linux/ext2_fs.h 2012-03-21 11:47:53.015548437 +0000
+@@ -209,7 +209,7 @@
+ #define EXT2_OTHER_FLMASK (EXT2_NODUMP_FL | EXT2_NOATIME_FL)
+
+ /* Mask out flags that are inappropriate for the given type of inode. */
+-static inline __u32 ext2_mask_flags(umode_t mode, __u32 flags)
++static inline __u32 ext2_mask_flags(unsigned short mode, __u32 flags)
+ {
+ if (S_ISDIR(mode))
+ return flags;
--
1.7.5.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Buildroot] [PATCH] Fix problem with undefined umode_t type in 3.3 kernel headers
2012-03-24 9:14 [Buildroot] [PATCH] Fix problem with undefined umode_t type in 3.3 kernel headers spdawson at gmail.com
@ 2012-03-29 8:47 ` Peter Korsgaard
0 siblings, 0 replies; 2+ messages in thread
From: Peter Korsgaard @ 2012-03-29 8:47 UTC (permalink / raw)
To: buildroot
>>>>> "spdawson" == spdawson <spdawson@gmail.com> writes:
spdawson> From: Simon Dawson <spdawson@gmail.com>
spdawson> The 3.3 kernel headers define the umode_t type within a
spdawson> __KERNEL__ preprocessor ifdef region. This results in a
spdawson> broken kernel header in the buildroot toolchain.
Committed, thanks. It seems socat/syslinux should get updated to not
include this header, but as there's no upstream releases fixing this it
makes sense to add it for now.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-03-29 8:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-24 9:14 [Buildroot] [PATCH] Fix problem with undefined umode_t type in 3.3 kernel headers spdawson at gmail.com
2012-03-29 8:47 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox