From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] docs: update DEVELOPERS modification process
Date: Sun, 05 Nov 2017 08:43:05 +0100 [thread overview]
Message-ID: <87y3nl2mt2.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20171104231427.3b3f436a@windsurf> (Thomas Petazzoni's message of "Sat, 4 Nov 2017 23:14:27 +0100")
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
Hi,
>> Not sure about "or modifying". Mixing a DEVELOPERS update into a random
>> package update does not always make sense. The manual only refers to new
>> packages/boards. I suggest to drop this sentence entirely, and leave the
>> details for the manual.
> Joseph is modifying the manual here, so I'm not sure what your last
> sentence means.
> However, I agree that doing the DEVELOPERS change in a patch just
> modifying the package is perhaps not desirable. When adding a new
> package, yes, definitely, the DEVELOPERS entry should be added as part
> of the same patch. However, when a package is being modified, that's a
> different story, and the package change should be in a separate patch
> than the DEVELOPERS addition.
I'm not sure it really matters much. A package change with a
modification of DEVELOPERS would most likely be for a version bump of an
unmaintained package where the person bumping wants to take over
ownership, or similar.
I don't think it is a problem to update DEVELOPERS together with the
package in such cases, but keeping it separately is also fine.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2017-11-05 7:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-03 21:10 [Buildroot] [PATCH 1/1] docs: update DEVELOPERS modification process Joseph Kogut
2017-11-04 18:53 ` Baruch Siach
2017-11-04 22:14 ` Thomas Petazzoni
2017-11-05 6:07 ` Baruch Siach
2017-11-05 8:55 ` Thomas Petazzoni
2017-11-05 7:43 ` Peter Korsgaard [this message]
2017-11-05 8:55 ` Thomas Petazzoni
2017-11-05 20:14 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y3nl2mt2.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox