* [Buildroot] [PATCH 0/2] Add lightweight Zile editor @ 2014-04-07 11:00 Alex Bennée 2014-04-07 11:00 ` [Buildroot] [PATCH 1/2] package/libgc: add Boehm-Demers-Weiser gc library Alex Bennée 2014-04-07 11:00 ` [Buildroot] [PATCH 2/2] package/zile: add Zile is Lossy Emacs editor Alex Bennée 0 siblings, 2 replies; 9+ messages in thread From: Alex Bennée @ 2014-04-07 11:00 UTC (permalink / raw) To: buildroot From: Alex Benn?e <alex@bennee.com> Hi, The following two patches enable the addition of Zile to the roster of available editors in buildroot. Zile is a lightweight Emacs-a-like implementation. It requires libgc which will also be useful for a number of other packages if they get added to Buildroot. There is nothing especially complex in the build descriptions although libgc requires another source tree (lib_atomic) merging in the build and Zile needs help2man disabling. Cheers, -- Alex Benn?e QEMU/KVM Hacker for Linaro Alex Benn?e (2): package/libgc: add Boehm-Demers-Weiser gc library package/zile: add Zile is Lossy Emacs editor package/Config.in | 2 ++ package/libgc/Config.in | 9 +++++++++ package/libgc/libgc.mk | 23 +++++++++++++++++++++++ package/zile/Config.in | 14 ++++++++++++++ package/zile/remove-help2man.patch | 28 ++++++++++++++++++++++++++++ package/zile/zile.mk | 13 +++++++++++++ 6 files changed, 89 insertions(+) create mode 100644 package/libgc/Config.in create mode 100644 package/libgc/libgc.mk create mode 100644 package/zile/Config.in create mode 100644 package/zile/remove-help2man.patch create mode 100644 package/zile/zile.mk -- 1.9.1 ^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 1/2] package/libgc: add Boehm-Demers-Weiser gc library 2014-04-07 11:00 [Buildroot] [PATCH 0/2] Add lightweight Zile editor Alex Bennée @ 2014-04-07 11:00 ` Alex Bennée 2014-04-07 20:26 ` Yann E. MORIN 2014-04-07 21:39 ` Thomas Petazzoni 2014-04-07 11:00 ` [Buildroot] [PATCH 2/2] package/zile: add Zile is Lossy Emacs editor Alex Bennée 1 sibling, 2 replies; 9+ messages in thread From: Alex Bennée @ 2014-04-07 11:00 UTC (permalink / raw) To: buildroot This is needed for applications like Zile Signed-off-by: Alex Benn?e <alex.bennee@linaro.org> Signed-off-by: Alex Benn?e <alex@bennee.com> --- package/Config.in | 1 + package/libgc/Config.in | 9 +++++++++ package/libgc/libgc.mk | 23 +++++++++++++++++++++++ 3 files changed, 33 insertions(+) create mode 100644 package/libgc/Config.in create mode 100644 package/libgc/libgc.mk diff --git a/package/Config.in b/package/Config.in index e816603..5cdf72b 100644 --- a/package/Config.in +++ b/package/Config.in @@ -786,6 +786,7 @@ source "package/libev/Config.in" source "package/libevdev/Config.in" source "package/libevent/Config.in" source "package/libffi/Config.in" +source "package/libgc/Config.in" source "package/libglib2/Config.in" source "package/libical/Config.in" source "package/libnspr/Config.in" diff --git a/package/libgc/Config.in b/package/libgc/Config.in new file mode 100644 index 0000000..bac636c --- /dev/null +++ b/package/libgc/Config.in @@ -0,0 +1,9 @@ +config BR2_PACKAGE_LIBGC + bool "libgc" + help + The Boehm-Demers-Weiser conservative garbage collector can be used + as a garbage collecting replacement for C malloc or C++ new. It allows + you to allocate memory basically as you normally would, without + explicitly deallocating memory that is no longer useful. + + http://www.hboehm.info/gc/ diff --git a/package/libgc/libgc.mk b/package/libgc/libgc.mk new file mode 100644 index 0000000..e5c4609 --- /dev/null +++ b/package/libgc/libgc.mk @@ -0,0 +1,23 @@ +################################################################################ +# +# Boehm-Demers-Weiser's GC +# +################################################################################ + +LIBGC_VERSION = 7.4.0 +LIBGC_SOURCE = gc-${LIBGC_VERSION}.tar.gz +LIBGC_SITE = http://www.hboehm.info/gc/gc_source/ +LIBGC_EXTRA_DOWNLOADS = libatomic_ops-${LIBGC_VERSION}.tar.gz +LIBGC_LICENSE = GPLv1+ +LIBGC_LICENSE_FILES = COPYING +LIBGC_INSTALL_STAGING = YES + +define LIBGC_POST_EXTRACT_INC_LIBATOMIC + env + mkdir -p $(@D)/libatomic_ops + tar -xvf ${BR2_DL_DIR}/libatomic_ops-${LIBGC_VERSION}.tar.gz --strip-components=1 -C $(@D)/libatomic_ops +endef + +LIBGC_POST_EXTRACT_HOOKS += LIBGC_POST_EXTRACT_INC_LIBATOMIC + +$(eval $(autotools-package)) -- 1.9.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 1/2] package/libgc: add Boehm-Demers-Weiser gc library 2014-04-07 11:00 ` [Buildroot] [PATCH 1/2] package/libgc: add Boehm-Demers-Weiser gc library Alex Bennée @ 2014-04-07 20:26 ` Yann E. MORIN 2014-04-08 10:20 ` Alex Bennée 2014-04-07 21:39 ` Thomas Petazzoni 1 sibling, 1 reply; 9+ messages in thread From: Yann E. MORIN @ 2014-04-07 20:26 UTC (permalink / raw) To: buildroot Alex, Alex, All, On 2014-04-07 12:00 +0100, Alex Benn?e spake thusly: > This is needed for applications like Zile > > Signed-off-by: Alex Benn?e <alex.bennee@linaro.org> > Signed-off-by: Alex Benn?e <alex@bennee.com> Woot! It's not that often with have a schizophrenic contributor! ;-) [--SNIP--] > diff --git a/package/libgc/libgc.mk b/package/libgc/libgc.mk > new file mode 100644 > index 0000000..e5c4609 > --- /dev/null > +++ b/package/libgc/libgc.mk > @@ -0,0 +1,23 @@ > +################################################################################ > +# > +# Boehm-Demers-Weiser's GC > +# > +################################################################################ > + > +LIBGC_VERSION = 7.4.0 > +LIBGC_SOURCE = gc-${LIBGC_VERSION}.tar.gz Use parenthesis when evaluating variables, not curly-braces: LIBGC_SOURCE = gc-$(LIBGC_VERSION).tar.gz > +LIBGC_SITE = http://www.hboehm.info/gc/gc_source/ > +LIBGC_EXTRA_DOWNLOADS = libatomic_ops-${LIBGC_VERSION}.tar.gz Ditto, parenthesis. > +LIBGC_LICENSE = GPLv1+ > +LIBGC_LICENSE_FILES = COPYING > +LIBGC_INSTALL_STAGING = YES > + > +define LIBGC_POST_EXTRACT_INC_LIBATOMIC > + env This is not needed. > + mkdir -p $(@D)/libatomic_ops > + tar -xvf ${BR2_DL_DIR}/libatomic_ops-${LIBGC_VERSION}.tar.gz --strip-components=1 -C $(@D)/libatomic_ops > +endef > + > +LIBGC_POST_EXTRACT_HOOKS += LIBGC_POST_EXTRACT_INC_LIBATOMIC I know this is how upstream suggests building, but I can refrain from finding this really ugly... Yuck! :-( Anyway: can't use you use something like: LIBGC_LIBATOMIC_OPS = libatomic_ops-${LIBGC_VERSION}.tar.gz LIBGC_EXTRA_DOWNLOADS = $(LIBGC_LIBATOMIC_OPS) define LIBGC_POST_EXTRACT_INC_LIBATOMIC $(INSTALL) -d -m 0755 $(LSOF_DIR)/libatomic_ops && \ $(call suitable-extractor,$(LIBGC_LIBATOMIC_OPS)) $(DL_DIR)/$(LIBGC_LIBATOMIC_OPS) |\ $(TAR) $(TAR_STRIP_COMPONENTS)=1 -C $(LSOF_DIR)/libatomic_opsi $(TAR_OPTIONS) - endef LIBGC_POST_EXTRACT_HOOKS += LIBGC_POST_EXTRACT_INC_LIBATOMIC Note LIBGC_LIBATOMIC_OPS is not strictly required, but I find it cleaner to use, rather than call suitabel-extract on _EXTRA_DOWNLOADS, which is a plual and could contain more than one file. That's purely for aesthetics. > +$(eval $(autotools-package)) Regards, Yann E. MORIN. -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' ^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 1/2] package/libgc: add Boehm-Demers-Weiser gc library 2014-04-07 20:26 ` Yann E. MORIN @ 2014-04-08 10:20 ` Alex Bennée 0 siblings, 0 replies; 9+ messages in thread From: Alex Bennée @ 2014-04-08 10:20 UTC (permalink / raw) To: buildroot Yann E. MORIN <yann.morin.1998@free.fr> writes: > Alex, Alex, All, > > On 2014-04-07 12:00 +0100, Alex Benn?e spake thusly: >> This is needed for applications like Zile >> >> Signed-off-by: Alex Benn?e <alex.bennee@linaro.org> >> Signed-off-by: Alex Benn?e <alex@bennee.com> > > Woot! It's not that often with have a schizophrenic contributor! ;-) Yeah I blame format-patch for that one! > > [--SNIP--] >> diff --git a/package/libgc/libgc.mk b/package/libgc/libgc.mk >> new file mode 100644 >> index 0000000..e5c4609 >> --- /dev/null >> +++ b/package/libgc/libgc.mk >> @@ -0,0 +1,23 @@ >> +################################################################################ >> +# >> +# Boehm-Demers-Weiser's GC >> +# >> +################################################################################ >> + >> +LIBGC_VERSION = 7.4.0 >> +LIBGC_SOURCE = gc-${LIBGC_VERSION}.tar.gz > > Use parenthesis when evaluating variables, not curly-braces: > LIBGC_SOURCE = gc-$(LIBGC_VERSION).tar.gz > >> +LIBGC_SITE = http://www.hboehm.info/gc/gc_source/ >> +LIBGC_EXTRA_DOWNLOADS = libatomic_ops-${LIBGC_VERSION}.tar.gz > > Ditto, parenthesis. > >> +LIBGC_LICENSE = GPLv1+ >> +LIBGC_LICENSE_FILES = COPYING >> +LIBGC_INSTALL_STAGING = YES >> + >> +define LIBGC_POST_EXTRACT_INC_LIBATOMIC >> + env > > This is not needed. > >> + mkdir -p $(@D)/libatomic_ops >> + tar -xvf ${BR2_DL_DIR}/libatomic_ops-${LIBGC_VERSION}.tar.gz --strip-components=1 -C $(@D)/libatomic_ops >> +endef >> + >> +LIBGC_POST_EXTRACT_HOOKS += LIBGC_POST_EXTRACT_INC_LIBATOMIC > > I know this is how upstream suggests building, but I can refrain from > finding this really ugly... Yuck! :-( > > Anyway: can't use you use something like: > > LIBGC_LIBATOMIC_OPS = libatomic_ops-${LIBGC_VERSION}.tar.gz > LIBGC_EXTRA_DOWNLOADS = $(LIBGC_LIBATOMIC_OPS) > > define LIBGC_POST_EXTRACT_INC_LIBATOMIC > $(INSTALL) -d -m 0755 $(LSOF_DIR)/libatomic_ops && \ > $(call suitable-extractor,$(LIBGC_LIBATOMIC_OPS)) $(DL_DIR)/$(LIBGC_LIBATOMIC_OPS) |\ > $(TAR) $(TAR_STRIP_COMPONENTS)=1 -C $(LSOF_DIR)/libatomic_opsi $(TAR_OPTIONS) - > endef > LIBGC_POST_EXTRACT_HOOKS += LIBGC_POST_EXTRACT_INC_LIBATOMIC > > Note LIBGC_LIBATOMIC_OPS is not strictly required, but I find it cleaner > to use, rather than call suitabel-extract on _EXTRA_DOWNLOADS, which is > a plual and could contain more than one file. That's purely for > aesthetics. I'll look at using the buildroot defined one. > >> +$(eval $(autotools-package)) > > Regards, > Yann E. MORIN. -- Alex Benn?e ^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 1/2] package/libgc: add Boehm-Demers-Weiser gc library 2014-04-07 11:00 ` [Buildroot] [PATCH 1/2] package/libgc: add Boehm-Demers-Weiser gc library Alex Bennée 2014-04-07 20:26 ` Yann E. MORIN @ 2014-04-07 21:39 ` Thomas Petazzoni 1 sibling, 0 replies; 9+ messages in thread From: Thomas Petazzoni @ 2014-04-07 21:39 UTC (permalink / raw) To: buildroot Dear Alex Benn?e, On Mon, 7 Apr 2014 12:00:21 +0100, Alex Benn?e wrote: > diff --git a/package/libgc/Config.in b/package/libgc/Config.in > new file mode 100644 > index 0000000..bac636c > --- /dev/null > +++ b/package/libgc/Config.in > @@ -0,0 +1,9 @@ > +config BR2_PACKAGE_LIBGC > + bool "libgc" > + help > + The Boehm-Demers-Weiser conservative garbage collector can be used > + as a garbage collecting replacement for C malloc or C++ new. It allows > + you to allocate memory basically as you normally would, without > + explicitly deallocating memory that is no longer useful. > + > + http://www.hboehm.info/gc/ Indentation for the help text should be one tab + two spaces. > +################################################################################ > +# > +# Boehm-Demers-Weiser's GC We normally just want the package name here, i.e the same as the directory name. > +# > +################################################################################ > + > +LIBGC_VERSION = 7.4.0 > +LIBGC_SOURCE = gc-${LIBGC_VERSION}.tar.gz > +LIBGC_SITE = http://www.hboehm.info/gc/gc_source/ > +LIBGC_EXTRA_DOWNLOADS = libatomic_ops-${LIBGC_VERSION}.tar.gz > +LIBGC_LICENSE = GPLv1+ > +LIBGC_LICENSE_FILES = COPYING > +LIBGC_INSTALL_STAGING = YES > + > +define LIBGC_POST_EXTRACT_INC_LIBATOMIC > + env > + mkdir -p $(@D)/libatomic_ops > + tar -xvf ${BR2_DL_DIR}/libatomic_ops-${LIBGC_VERSION}.tar.gz --strip-components=1 -C $(@D)/libatomic_ops > +endef We have a libatomic_ops package in Buildroot. Wouldn't it be possible to use it instead? Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com ^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 2/2] package/zile: add Zile is Lossy Emacs editor 2014-04-07 11:00 [Buildroot] [PATCH 0/2] Add lightweight Zile editor Alex Bennée 2014-04-07 11:00 ` [Buildroot] [PATCH 1/2] package/libgc: add Boehm-Demers-Weiser gc library Alex Bennée @ 2014-04-07 11:00 ` Alex Bennée 2014-04-07 20:33 ` Yann E. MORIN 1 sibling, 1 reply; 9+ messages in thread From: Alex Bennée @ 2014-04-07 11:00 UTC (permalink / raw) To: buildroot This is a lightweight Emacs clone useful for embedded systems. I nabbed the help2man disable patch from OpenEmbedded. Signed-off-by: Alex Benn?e <alex.bennee@linaro.org> Signed-off-by: Alex Benn?e <alex@bennee.com> --- package/Config.in | 1 + package/zile/Config.in | 14 ++++++++++++++ package/zile/remove-help2man.patch | 28 ++++++++++++++++++++++++++++ package/zile/zile.mk | 13 +++++++++++++ 4 files changed, 56 insertions(+) create mode 100644 package/zile/Config.in create mode 100644 package/zile/remove-help2man.patch create mode 100644 package/zile/zile.mk diff --git a/package/Config.in b/package/Config.in index 5cdf72b..99b0b96 100644 --- a/package/Config.in +++ b/package/Config.in @@ -1115,6 +1115,7 @@ source "package/uemacs/Config.in" if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS source "package/vim/Config.in" endif +source "package/zile/Config.in" endmenu endmenu diff --git a/package/zile/Config.in b/package/zile/Config.in new file mode 100644 index 0000000..29fb0fc --- /dev/null +++ b/package/zile/Config.in @@ -0,0 +1,14 @@ +config BR2_PACKAGE_ZILE + bool "zile" + select BR2_PACKAGE_LIBGC + depends on BR2_USE_MMU # fork() + help + Zile is Lossy Emacs + + GNU Zile (Zile Is Lossy Emacs) is a lightweight Emacs clone. Every + Emacs user should feel at home with Zile. Zile is aimed at small + footprint systems (a typical binary is about 100Kb) and quick editing + sessions (it starts up and shuts down instantly). + + http://www.gnu.org/software/zile/ + diff --git a/package/zile/remove-help2man.patch b/package/zile/remove-help2man.patch new file mode 100644 index 0000000..c1a63f4 --- /dev/null +++ b/package/zile/remove-help2man.patch @@ -0,0 +1,28 @@ +Upstream-Status: Inappropriate [configuration] + +diff --git a/Makefile.am b/Makefile.am +index 54bc59f..46c2650 100644 +--- a/Makefile.am ++++ b/Makefile.am +@@ -36,7 +36,6 @@ PERL_BUILDTIME = \ + + EXTRA_DIST = \ + FAQ \ +- build-aux/zile-help2man-wrapper \ + $(PERL_BUILDTIME) + + doc_DATA = AUTHORS FAQ NEWS +diff --git a/doc/Makefile.am b/doc/Makefile.am +index 639f59c..8c5123e 100644 +--- a/doc/Makefile.am ++++ b/doc/Makefile.am +@@ -33,9 +33,3 @@ doc/zile.1: $(srcdir)/doc/zile.1.in doc/Makefile.am config.status + $(edit) $(abs_srcdir)/doc/zile.1.in >$@.tmp + mv $@.tmp $@ + +-$(srcdir)/doc/zile.1.in: doc/man-extras build-aux/zile-help2man-wrapper configure.ac $(builddir)/src/zile$(EXEEXT) +- @test -d doc || mkdir doc +-## Exit gracefully if zile.1.in is not writeable, such as during distcheck! +- $(AM_V_GEN)if ( touch $@.w && rm -f $@.w; ) >/dev/null 2>&1; then \ +- $(srcdir)/build-aux/missing --run $(HELP2MAN) --output=$@ --no-info --name="Zile Is Lossy Emacs" --include $(srcdir)/doc/man-extras $(srcdir)/build-aux/zile-help2man-wrapper; \ +- fi diff --git a/package/zile/zile.mk b/package/zile/zile.mk new file mode 100644 index 0000000..024595c --- /dev/null +++ b/package/zile/zile.mk @@ -0,0 +1,13 @@ +################################################################################ +# +# Zile +# +################################################################################ + +ZILE_VERSION = 2.4.11 +ZILE_SITE = http://ftp.gnu.org/gnu/zile/ +ZILE_LICENSE = GPLv1+ +ZILE_LICENSE_FILES = COPYING +ZILE_CONF_OPT += --without-help2man + +$(eval $(autotools-package)) -- 1.9.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 2/2] package/zile: add Zile is Lossy Emacs editor 2014-04-07 11:00 ` [Buildroot] [PATCH 2/2] package/zile: add Zile is Lossy Emacs editor Alex Bennée @ 2014-04-07 20:33 ` Yann E. MORIN 2014-04-08 10:19 ` Alex Bennée 0 siblings, 1 reply; 9+ messages in thread From: Yann E. MORIN @ 2014-04-07 20:33 UTC (permalink / raw) To: buildroot Alex, All, On 2014-04-07 12:00 +0100, Alex Benn?e spake thusly: > This is a lightweight Emacs clone useful for embedded systems. I nabbed > the help2man disable patch from OpenEmbedded. [--SNIP--] > diff --git a/package/zile/Config.in b/package/zile/Config.in > new file mode 100644 > index 0000000..29fb0fc > --- /dev/null > +++ b/package/zile/Config.in > @@ -0,0 +1,14 @@ > +config BR2_PACKAGE_ZILE > + bool "zile" > + select BR2_PACKAGE_LIBGC > + depends on BR2_USE_MMU # fork() > + help > + Zile is Lossy Emacs > + > + GNU Zile (Zile Is Lossy Emacs) is a lightweight Emacs clone. Every > + Emacs user should feel at home with Zile. Zile is aimed at small > + footprint systems (a typical binary is about 100Kb) and quick editing > + sessions (it starts up and shuts down instantly). > + > + http://www.gnu.org/software/zile/ There is space damage above: - use one tab in front of options parameters (type, select, depends...) - use one tab and two spaces in front of the help text The above mixes spaces and tabs. > diff --git a/package/zile/remove-help2man.patch b/package/zile/remove-help2man.patch > new file mode 100644 > index 0000000..c1a63f4 > --- /dev/null > +++ b/package/zile/remove-help2man.patch > @@ -0,0 +1,28 @@ > +Upstream-Status: Inappropriate [configuration] Please add a complete commit log, and your SoB lines too, in this patch. Could you also add a pointer to the upstream refusal (bug -tracker or ML archive), please? > diff --git a/package/zile/zile.mk b/package/zile/zile.mk > new file mode 100644 > index 0000000..024595c > --- /dev/null > +++ b/package/zile/zile.mk > @@ -0,0 +1,13 @@ > +################################################################################ > +# > +# Zile > +# > +################################################################################ > + > +ZILE_VERSION = 2.4.11 > +ZILE_SITE = http://ftp.gnu.org/gnu/zile/ > +ZILE_LICENSE = GPLv1+ > +ZILE_LICENSE_FILES = COPYING > +ZILE_CONF_OPT += --without-help2man In the previous patch, you added libgc, stating that it was a dependency of Zile, but you forgot to add it here. Probably it is working for you since libgz sorts alphabetically before zile, but that's not guaranteed with parallel builds. Regards, Yann E. MORIN. -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' ^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 2/2] package/zile: add Zile is Lossy Emacs editor 2014-04-07 20:33 ` Yann E. MORIN @ 2014-04-08 10:19 ` Alex Bennée 2014-04-08 16:16 ` Yann E. MORIN 0 siblings, 1 reply; 9+ messages in thread From: Alex Bennée @ 2014-04-08 10:19 UTC (permalink / raw) To: buildroot Yann E. MORIN <yann.morin.1998@free.fr> writes: > Alex, All, > > On 2014-04-07 12:00 +0100, Alex Benn?e spake thusly: <snip> >> + http://www.gnu.org/software/zile/ > > There is space damage above: > - use one tab in front of options parameters (type, select, depends...) > - use one tab and two spaces in front of the help text > > The above mixes spaces and tabs. I'll get that cleaned up >> diff --git a/package/zile/remove-help2man.patch b/package/zile/remove-help2man.patch >> new file mode 100644 >> index 0000000..c1a63f4 >> --- /dev/null >> +++ b/package/zile/remove-help2man.patch >> @@ -0,0 +1,28 @@ >> +Upstream-Status: Inappropriate [configuration] > > Please add a complete commit log, and your SoB lines too, in this patch. > > Could you also add a pointer to the upstream refusal (bug -tracker or ML > archive), please? I'll see if I can find it. > >> diff --git a/package/zile/zile.mk b/package/zile/zile.mk >> new file mode 100644 >> index 0000000..024595c >> --- /dev/null >> +++ b/package/zile/zile.mk >> @@ -0,0 +1,13 @@ >> +################################################################################ >> +# >> +# Zile >> +# >> +################################################################################ >> + >> +ZILE_VERSION = 2.4.11 >> +ZILE_SITE = http://ftp.gnu.org/gnu/zile/ >> +ZILE_LICENSE = GPLv1+ >> +ZILE_LICENSE_FILES = COPYING >> +ZILE_CONF_OPT += --without-help2man > > In the previous patch, you added libgc, stating that it was a dependency > of Zile, but you forgot to add it here. Ahh I thought it was enforced by the Config.in select but of course you need to ensure it's built as well. I'll fix that up. > > Probably it is working for you since libgz sorts alphabetically before > zile, but that's not guaranteed with parallel builds. > > Regards, > Yann E. MORIN. -- Alex Benn?e ^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 2/2] package/zile: add Zile is Lossy Emacs editor 2014-04-08 10:19 ` Alex Bennée @ 2014-04-08 16:16 ` Yann E. MORIN 0 siblings, 0 replies; 9+ messages in thread From: Yann E. MORIN @ 2014-04-08 16:16 UTC (permalink / raw) To: buildroot Alex, All, On 2014-04-08 11:19 +0100, Alex Benn?e spake thusly: > Yann E. MORIN <yann.morin.1998@free.fr> writes: [--SNIP--] > >> diff --git a/package/zile/zile.mk b/package/zile/zile.mk > >> new file mode 100644 > >> index 0000000..024595c > >> --- /dev/null > >> +++ b/package/zile/zile.mk > >> @@ -0,0 +1,13 @@ > >> +################################################################################ > >> +# > >> +# Zile > >> +# > >> +################################################################################ > >> + > >> +ZILE_VERSION = 2.4.11 > >> +ZILE_SITE = http://ftp.gnu.org/gnu/zile/ > >> +ZILE_LICENSE = GPLv1+ > >> +ZILE_LICENSE_FILES = COPYING > >> +ZILE_CONF_OPT += --without-help2man > > > > In the previous patch, you added libgc, stating that it was a dependency > > of Zile, but you forgot to add it here. > > Ahh I thought it was enforced by the Config.in select but of course you > need to ensure it's built as well. I'll fix that up. THere are two types of dependencies: - build-time dependencies, and - run-time dependencies. The run-time dependencies (eg. I need *that* program to be present) are handled purely in the Config.in. The build-time dependencies (eg. I need to link to *that* library) are handled both in Config.in and the .mk. The dependencies in Config.in will ensure that the package is present in the target, while the dependencies in the .mk guarantee the build order. Regards, Yann E. MORIN. -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2014-04-08 16:16 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-04-07 11:00 [Buildroot] [PATCH 0/2] Add lightweight Zile editor Alex Bennée 2014-04-07 11:00 ` [Buildroot] [PATCH 1/2] package/libgc: add Boehm-Demers-Weiser gc library Alex Bennée 2014-04-07 20:26 ` Yann E. MORIN 2014-04-08 10:20 ` Alex Bennée 2014-04-07 21:39 ` Thomas Petazzoni 2014-04-07 11:00 ` [Buildroot] [PATCH 2/2] package/zile: add Zile is Lossy Emacs editor Alex Bennée 2014-04-07 20:33 ` Yann E. MORIN 2014-04-08 10:19 ` Alex Bennée 2014-04-08 16:16 ` Yann E. MORIN
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox