Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [git commit master] buildroot; move defconfigs to configs/ and print in help
Date: Wed, 25 Nov 2009 23:16:11 +0100	[thread overview]
Message-ID: <87y6lu9ro4.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <20091125230213.27e7b090@surf> (Thomas Petazzoni's message of "Wed\, 25 Nov 2009 23\:02\:13 +0100")

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

Hi,

 >> I'm sorry to hear. I do kind of like it ;)

 Thomas> Argh, I still don't like it ;)

:/

I'll get back to you on this in more detail tomorrow, but just wanted to
reply to one thing now:

 >> With a find-all-files-ending-in-_defconfig-under-here thing? Could be
 >> done, but is kind of ugly - Same for make <foo>_defconfig.

 Thomas> Come on, kind of ugly ? It's a one liner for <foo>_defconfig (something
 Thomas> we already had) :

 Thomas> %_defconfig: $(CONFIG)/conf
 Thomas> 	cp $(shell find ./target/ -name $@) .config

But that's without error handling! If the user mistypes the defconfig
name he gets a very odd error:

make blah_defconfig
cp .config
cp: missing destination file operand after `.config'
Try `cp --help' for more information.

Whereas with a real dest: target rule like what we have now you get a
sensible error message:

make blah_defconfig
make: *** No rule to make target `blah_defconfig'.  Stop.

That's what I mean about ugly.

-- 
Bye, Peter Korsgaard

      reply	other threads:[~2009-11-25 22:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-04 20:20 [Buildroot] [git commit master] buildroot; move defconfigs to configs/ and print in help Peter Korsgaard
2009-10-05  6:48 ` Thomas Petazzoni
2009-10-05  7:09   ` Peter Korsgaard
2009-11-11 14:03     ` Thomas Petazzoni
2009-11-11 18:36       ` Thiago A. Corrêa
2009-11-22 21:05       ` Peter Korsgaard
2009-11-25 22:02         ` Thomas Petazzoni
2009-11-25 22:16           ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y6lu9ro4.fsf@macbook.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox