From: Peter Korsgaard <peter@korsgaard.com>
To: Cherniaev Andrei <dungeonlords789@naver.com>
Cc: buildroot@buildroot.org,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [Buildroot] [PATCH] boot/grub2/readme.txt: fix script
Date: Fri, 16 May 2025 11:35:53 +0200 [thread overview]
Message-ID: <87zffcc2yu.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20250515144241.3082079-1-dungeonlords789@naver.com> (Cherniaev Andrei's message of "Thu, 15 May 2025 23:42:40 +0900")
>>>>> "Cherniaev" == Cherniaev Andrei <dungeonlords789@naver.com> writes:
> Fix regression of commit 552ba600eef0884bb7bf7f09a67cd66747d1efa8
> Without `--show` loop_dev variable will be empty so script never
> works... Sorry, it was my mistake...
Thanks for the patch. Can you please add your signed-off-by and resend
(E.G. git commit --amend -s)?
> ---
> boot/grub2/readme.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> diff --git a/boot/grub2/readme.txt b/boot/grub2/readme.txt
> index d0999ec390..3b7df3a47d 100644
> --- a/boot/grub2/readme.txt
> +++ b/boot/grub2/readme.txt
> @@ -10,7 +10,7 @@ Notes on using Grub2 for BIOS-based platforms
> is enough free space *before* the first partition to
> store Grub2. Leaving 1 MB of free space is safe.
> 3. Setup loop device and loop partitions
> - loop_dev=$(sudo losetup -f disk.img)
> + loop_dev=$(sudo losetup -f --show disk.img)
> sudo partx -a "$loop_dev"
> 4. Prepare the root partition
> sudo mkfs.ext3 -L root "${loop_dev}p1"
> @@ -65,7 +65,7 @@ Notes on using Grub2 for x86/x86_64 EFI-based platforms
> - Create a second partition, type 8300, for the root
> filesystem.
> 3. Setup loop device and loop partitions
> - loop_dev=$(sudo losetup -f disk.img)
> + loop_dev=$(sudo losetup -f --show disk.img)
> sudo partx -a "$loop_dev"
> 4. Prepare the boot partition
> sudo mkfs.vfat -n boot "${loop_dev}p1"
> --
> 2.45.2
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2025-05-16 9:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-15 14:42 [Buildroot] [PATCH] boot/grub2/readme.txt: fix script Cherniaev Andrei
2025-05-16 9:19 ` Thomas Petazzoni via buildroot
2025-05-16 9:35 ` Peter Korsgaard [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-05-16 15:08 Cherniaev Andrei
2025-05-16 20:00 ` Peter Korsgaard
2025-05-31 16:53 ` Arnout Vandecappelle via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zffcc2yu.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
--cc=dungeonlords789@naver.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox