* [Buildroot] [PATCH] package/rtl8189fs: en/disable runtime debug according to BR2_ENABLE_RUNTIME_DEBUG
@ 2023-06-12 16:53 Giulio Benetti
2023-06-15 15:28 ` Indrek Kruusa
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Giulio Benetti @ 2023-06-12 16:53 UTC (permalink / raw)
To: buildroot; +Cc: Giulio Benetti, Indrek Kruusa, Sergey Matyukevich
Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
package/rtl8189fs/rtl8189fs.mk | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/package/rtl8189fs/rtl8189fs.mk b/package/rtl8189fs/rtl8189fs.mk
index dd35a166e5..6b0585073b 100644
--- a/package/rtl8189fs/rtl8189fs.mk
+++ b/package/rtl8189fs/rtl8189fs.mk
@@ -13,6 +13,10 @@ RTL8189FS_MODULE_MAKE_OPTS = \
KVER=$(LINUX_VERSION_PROBED) \
KSRC=$(LINUX_DIR)
+ifeq ($(BR2_ENABLE_RUNTIME_DEBUG),)
+RTL8189FS_MODULE_MAKE_OPTS += CONFIG_RTW_DEBUG=n
+endif
+
define RTL8189FS_LINUX_CONFIG_FIXUPS
$(call KCONFIG_ENABLE_OPT,CONFIG_WIRELESS)
$(call KCONFIG_ENABLE_OPT,CONFIG_CFG80211)
--
2.34.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH] package/rtl8189fs: en/disable runtime debug according to BR2_ENABLE_RUNTIME_DEBUG
2023-06-12 16:53 [Buildroot] [PATCH] package/rtl8189fs: en/disable runtime debug according to BR2_ENABLE_RUNTIME_DEBUG Giulio Benetti
@ 2023-06-15 15:28 ` Indrek Kruusa
2023-06-15 15:42 ` Indrek Kruusa
2023-07-26 21:22 ` Thomas Petazzoni via buildroot
2023-08-30 10:38 ` Peter Korsgaard
2 siblings, 1 reply; 5+ messages in thread
From: Indrek Kruusa @ 2023-06-15 15:28 UTC (permalink / raw)
To: Giulio Benetti; +Cc: Sergey Matyukevich, buildroot
Kontakt Giulio Benetti (<giulio.benetti@benettiengineering.com>)
kirjutas kuupäeval E, 12. juuni 2023 kell 19:53:
>
Yes, this patch turns off the debug mode for rtl8189fs.
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
Tested-by: Indrek Kruusa <indrek.kruusa@gmail.com>
Thanks,
Indrek
>
> ---
> package/rtl8189fs/rtl8189fs.mk | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/package/rtl8189fs/rtl8189fs.mk b/package/rtl8189fs/rtl8189fs.mk
> index dd35a166e5..6b0585073b 100644
> --- a/package/rtl8189fs/rtl8189fs.mk
> +++ b/package/rtl8189fs/rtl8189fs.mk
> @@ -13,6 +13,10 @@ RTL8189FS_MODULE_MAKE_OPTS = \
> KVER=$(LINUX_VERSION_PROBED) \
> KSRC=$(LINUX_DIR)
>
> +ifeq ($(BR2_ENABLE_RUNTIME_DEBUG),)
> +RTL8189FS_MODULE_MAKE_OPTS += CONFIG_RTW_DEBUG=n
> +endif
> +
> define RTL8189FS_LINUX_CONFIG_FIXUPS
> $(call KCONFIG_ENABLE_OPT,CONFIG_WIRELESS)
> $(call KCONFIG_ENABLE_OPT,CONFIG_CFG80211)
> --
> 2.34.1
>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH] package/rtl8189fs: en/disable runtime debug according to BR2_ENABLE_RUNTIME_DEBUG
2023-06-15 15:28 ` Indrek Kruusa
@ 2023-06-15 15:42 ` Indrek Kruusa
0 siblings, 0 replies; 5+ messages in thread
From: Indrek Kruusa @ 2023-06-15 15:42 UTC (permalink / raw)
To: Giulio Benetti; +Cc: Sergey Matyukevich, buildroot
Kontakt Indrek Kruusa (<indrek.kruusa@gmail.com>) kirjutas kuupäeval
N, 15. juuni 2023 kell 18:28:
>
> Kontakt Giulio Benetti (<giulio.benetti@benettiengineering.com>)
> kirjutas kuupäeval E, 12. juuni 2023 kell 19:53:
> >
>
> Yes, this patch turns off the debug mode for rtl8189fs.
>
> > Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
>
> Tested-by: Indrek Kruusa <indrek.kruusa@gmail.com>
>
Oh, the testing is incomplete without turning on
BR2_ENABLE_RUNTIME_DEBUG also. Yes, turning it on works as expected
too.
Indrek
> Thanks,
> Indrek
>
> >
> > ---
> > package/rtl8189fs/rtl8189fs.mk | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/package/rtl8189fs/rtl8189fs.mk b/package/rtl8189fs/rtl8189fs.mk
> > index dd35a166e5..6b0585073b 100644
> > --- a/package/rtl8189fs/rtl8189fs.mk
> > +++ b/package/rtl8189fs/rtl8189fs.mk
> > @@ -13,6 +13,10 @@ RTL8189FS_MODULE_MAKE_OPTS = \
> > KVER=$(LINUX_VERSION_PROBED) \
> > KSRC=$(LINUX_DIR)
> >
> > +ifeq ($(BR2_ENABLE_RUNTIME_DEBUG),)
> > +RTL8189FS_MODULE_MAKE_OPTS += CONFIG_RTW_DEBUG=n
> > +endif
> > +
> > define RTL8189FS_LINUX_CONFIG_FIXUPS
> > $(call KCONFIG_ENABLE_OPT,CONFIG_WIRELESS)
> > $(call KCONFIG_ENABLE_OPT,CONFIG_CFG80211)
> > --
> > 2.34.1
> >
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH] package/rtl8189fs: en/disable runtime debug according to BR2_ENABLE_RUNTIME_DEBUG
2023-06-12 16:53 [Buildroot] [PATCH] package/rtl8189fs: en/disable runtime debug according to BR2_ENABLE_RUNTIME_DEBUG Giulio Benetti
2023-06-15 15:28 ` Indrek Kruusa
@ 2023-07-26 21:22 ` Thomas Petazzoni via buildroot
2023-08-30 10:38 ` Peter Korsgaard
2 siblings, 0 replies; 5+ messages in thread
From: Thomas Petazzoni via buildroot @ 2023-07-26 21:22 UTC (permalink / raw)
To: Giulio Benetti; +Cc: Sergey Matyukevich, Indrek Kruusa, buildroot
On Mon, 12 Jun 2023 18:53:44 +0200
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
> package/rtl8189fs/rtl8189fs.mk | 4 ++++
> 1 file changed, 4 insertions(+)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH] package/rtl8189fs: en/disable runtime debug according to BR2_ENABLE_RUNTIME_DEBUG
2023-06-12 16:53 [Buildroot] [PATCH] package/rtl8189fs: en/disable runtime debug according to BR2_ENABLE_RUNTIME_DEBUG Giulio Benetti
2023-06-15 15:28 ` Indrek Kruusa
2023-07-26 21:22 ` Thomas Petazzoni via buildroot
@ 2023-08-30 10:38 ` Peter Korsgaard
2 siblings, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2023-08-30 10:38 UTC (permalink / raw)
To: Giulio Benetti; +Cc: Sergey Matyukevich, Indrek Kruusa, buildroot
>>>>> "Giulio" == Giulio Benetti <giulio.benetti@benettiengineering.com> writes:
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
> package/rtl8189fs/rtl8189fs.mk | 4 ++++
> 1 file changed, 4 insertions(+)
> diff --git a/package/rtl8189fs/rtl8189fs.mk b/package/rtl8189fs/rtl8189fs.mk
> index dd35a166e5..6b0585073b 100644
> --- a/package/rtl8189fs/rtl8189fs.mk
> +++ b/package/rtl8189fs/rtl8189fs.mk
> @@ -13,6 +13,10 @@ RTL8189FS_MODULE_MAKE_OPTS = \
> KVER=$(LINUX_VERSION_PROBED) \
> KSRC=$(LINUX_DIR)
> +ifeq ($(BR2_ENABLE_RUNTIME_DEBUG),)
> +RTL8189FS_MODULE_MAKE_OPTS += CONFIG_RTW_DEBUG=n
> +endif
> +
Committed to 2023.02.x and 2023.05.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-08-30 10:38 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-12 16:53 [Buildroot] [PATCH] package/rtl8189fs: en/disable runtime debug according to BR2_ENABLE_RUNTIME_DEBUG Giulio Benetti
2023-06-15 15:28 ` Indrek Kruusa
2023-06-15 15:42 ` Indrek Kruusa
2023-07-26 21:22 ` Thomas Petazzoni via buildroot
2023-08-30 10:38 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox