[Buildroot] [PATCH next] libyaml: fix libyaml-legal-info build failure

[Buildroot] [PATCH next] libyaml: fix libyaml-legal-info build failure

[Giulio Benetti]

LICENSE file hash is wrong, this leads to libyaml-legal-info build
failure. This is probably due to version bump.

Recalculate it locally and substitute it in libyaml.hash file.

Fixes:
http://autobuild.buildroot.net/results/c10/c10baf6e9bae92d515264b677eeb1ce6c98c793d//
http://autobuild.buildroot.net/results/c66/c66ddb56fecf1570a8669bd9d8824cd2132f9776//
http://autobuild.buildroot.net/results/84e/84e9530aff0c981a009416f31470133fb2114421//

Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
---
 package/libyaml/libyaml.hash | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/libyaml/libyaml.hash b/package/libyaml/libyaml.hash
index 755ea7bbd8..afc014dfb2 100644
--- a/package/libyaml/libyaml.hash
+++ b/package/libyaml/libyaml.hash
@@ -1,3 +1,3 @@
 # Locally calculated
 sha256 78281145641a080fb32d6e7a87b9c0664d611dcb4d542e90baf731f51cbb59cd  yaml-0.2.1.tar.gz
-sha256 d0d8b09800a45cd982e9568fc7669d9c1a4c330e275a821bbe24d54366d16fe9  LICENSE
+sha256 bfcb6a7dfbfd30e0ccc8bb34ab712bd1568586ad8c5b078ccae443b04e79749e  LICENSE
-- 
2.17.1

[Buildroot] [PATCH next] libyaml: fix libyaml-legal-info build failure

[Baruch Siach]

Hi Giulio,

Giulio Benetti writes:
> LICENSE file hash is wrong, this leads to libyaml-legal-info build
> failure. This is probably due to version bump.

What are the changes in the LICENSE file in this version bump? Does it
affect the license? Please mention these details in the commit log.

baruch

> Recalculate it locally and substitute it in libyaml.hash file.
>
> Fixes:
> http://autobuild.buildroot.net/results/c10/c10baf6e9bae92d515264b677eeb1ce6c98c793d//
> http://autobuild.buildroot.net/results/c66/c66ddb56fecf1570a8669bd9d8824cd2132f9776//
> http://autobuild.buildroot.net/results/84e/84e9530aff0c981a009416f31470133fb2114421//
>
> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
> ---
>  package/libyaml/libyaml.hash | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/libyaml/libyaml.hash b/package/libyaml/libyaml.hash
> index 755ea7bbd8..afc014dfb2 100644
> --- a/package/libyaml/libyaml.hash
> +++ b/package/libyaml/libyaml.hash
> @@ -1,3 +1,3 @@
>  # Locally calculated
>  sha256 78281145641a080fb32d6e7a87b9c0664d611dcb4d542e90baf731f51cbb59cd  yaml-0.2.1.tar.gz
> -sha256 d0d8b09800a45cd982e9568fc7669d9c1a4c330e275a821bbe24d54366d16fe9  LICENSE
> +sha256 bfcb6a7dfbfd30e0ccc8bb34ab712bd1568586ad8c5b078ccae443b04e79749e  LICENSE

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

[Buildroot] [PATCH next] libyaml: fix libyaml-legal-info build failure

[Giulio Benetti]

Hi Baruch,

Il 29/08/2018 20:23, Baruch Siach ha scritto:
> Hi Giulio,
> 
> Giulio Benetti writes:
>> LICENSE file hash is wrong, this leads to libyaml-legal-info build
>> failure. This is probably due to version bump.
> 
> What are the changes in the LICENSE file in this version bump? Does it
> affect the license? Please mention these details in the commit log.

Ah right, if hash changed, file changed.
Basically they've updated copyright, I'm going to send v2 patch with 
this in commit log.

Thank you
Giulio

[Buildroot] [PATCH next v2] libyaml: fix libyaml-legal-info build failure

[Giulio Benetti]

LICENSE file changed and hash hasn't been recalculated, this leads to
libyaml-legal-info build failure.

Kirill Simonov Copyright now covers 2006-2016.
Ingy d?t Net Copyright has been added instead for 2017-2018.

Recalculate sha256 locally and substitute it in libyaml.hash file.

Fixes:
http://autobuild.buildroot.net/results/c10/c10baf6e9bae92d515264b677eeb1ce6c98c793d//
http://autobuild.buildroot.net/results/c66/c66ddb56fecf1570a8669bd9d8824cd2132f9776//
http://autobuild.buildroot.net/results/84e/84e9530aff0c981a009416f31470133fb2114421//

Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
---
 package/libyaml/libyaml.hash | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/libyaml/libyaml.hash b/package/libyaml/libyaml.hash
index 755ea7bbd8..afc014dfb2 100644
--- a/package/libyaml/libyaml.hash
+++ b/package/libyaml/libyaml.hash
@@ -1,3 +1,3 @@
 # Locally calculated
 sha256 78281145641a080fb32d6e7a87b9c0664d611dcb4d542e90baf731f51cbb59cd  yaml-0.2.1.tar.gz
-sha256 d0d8b09800a45cd982e9568fc7669d9c1a4c330e275a821bbe24d54366d16fe9  LICENSE
+sha256 bfcb6a7dfbfd30e0ccc8bb34ab712bd1568586ad8c5b078ccae443b04e79749e  LICENSE
-- 
2.17.1

[Buildroot] [PATCH next v2] libyaml: fix libyaml-legal-info build failure

[Thomas Petazzoni]

Hello,

On Wed, 29 Aug 2018 20:36:35 +0200, Giulio Benetti wrote:
> LICENSE file changed and hash hasn't been recalculated, this leads to
> libyaml-legal-info build failure.
> 
> Kirill Simonov Copyright now covers 2006-2016.
> Ingy d?t Net Copyright has been added instead for 2017-2018.
> 
> Recalculate sha256 locally and substitute it in libyaml.hash file.
> 
> Fixes:
> http://autobuild.buildroot.net/results/c10/c10baf6e9bae92d515264b677eeb1ce6c98c793d//
> http://autobuild.buildroot.net/results/c66/c66ddb56fecf1570a8669bd9d8824cd2132f9776//
> http://autobuild.buildroot.net/results/84e/84e9530aff0c981a009416f31470133fb2114421//
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
> ---
>  package/libyaml/libyaml.hash | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to next, thanks. An additional thing that would have been nice
in the commit log is something like this:

"""
Commit a4633a53ae1592ad2f4ea6f931c061382cf44b7f ("libyaml: bump to
version 0.2.1") forgot to update the hash of the license file.
"""

or any other wording that references the commit that introduced the
problem. It is sometimes useful later on to figure out when a given
problem was introduced.

But that wasn't important enough for this one, so I've applied as-is.
Something to keep in mind for future contributions, though.

Thanks again!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH next v2] libyaml: fix libyaml-legal-info build failure

[Giulio Benetti]

Hello,

Il 29/08/2018 20:57, Thomas Petazzoni ha scritto:
> Applied to next, thanks. An additional thing that would have been nice
> in the commit log is something like this:
> 
> """
> Commit a4633a53ae1592ad2f4ea6f931c061382cf44b7f ("libyaml: bump to
> version 0.2.1") forgot to update the hash of the license file.
> """
> 
> or any other wording that references the commit that introduced the
> problem. It is sometimes useful later on to figure out when a given
> problem was introduced.
> 
> But that wasn't important enough for this one, so I've applied as-is.
> Something to keep in mind for future contributions, though.

Sure I will, thank you.

Giulio Benetti