[Buildroot] [git commit] crosstool-ng: fix ccache dependencies order

[Buildroot] [git commit] crosstool-ng: fix ccache dependencies order

[Peter Korsgaard]

commit: http://git.buildroot.net/buildroot/commit/?id=934fb90437e06209145387d9bdfe8a8b5426d31d
branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master

avoid gawk complaining when running 'make ctng-menuconfig' in a
clean/distclean tree in which ccache and crosstool-ng are enabled

Signed-off-by: Samuel Martin <s.martin49@gmail.com>
Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
---
 package/crosstool-ng/crosstool-ng.mk |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/package/crosstool-ng/crosstool-ng.mk b/package/crosstool-ng/crosstool-ng.mk
index 8f53a77..84e218e 100644
--- a/package/crosstool-ng/crosstool-ng.mk
+++ b/package/crosstool-ng/crosstool-ng.mk
@@ -4,6 +4,6 @@ CROSSTOOL_NG_SITE              = http://crosstool-ng.org/download/crosstool-ng/
 CROSSTOOL_NG_INSTALL_STAGING   = NO
 CROSSTOOL_NG_INSTALL_TARGET    = NO
 CROSSTOOL_NG_MAKE              = $(MAKE1)
-HOST_CROSSTOOL_NG_DEPENDENCIES = host-gawk host-automake $(if $(BR2_CCACHE),host-ccache)
+HOST_CROSSTOOL_NG_DEPENDENCIES = $(if $(BR2_CCACHE),host-ccache) host-gawk host-automake
 
 $(eval $(call AUTOTARGETS,host))

[Buildroot] [git commit] crosstool-ng: fix ccache dependencies order

[Thomas Petazzoni]

Le Fri, 28 Oct 2011 14:41:26 +0200,
Peter Korsgaard <jacmet@sunsite.dk> a ?crit :

> avoid gawk complaining

about what ?

> when running 'make ctng-menuconfig' in a
> clean/distclean tree in which ccache and crosstool-ng are enabled

This sounds like a workaround. The ordering of dependencies inside a
_DEPENDENCIES variable shouldn't matter. Isn't it a missing dependency
somewhere else ?

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[Buildroot] [git commit] crosstool-ng: fix ccache dependencies order

[Peter Korsgaard]

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 Thomas> Le Fri, 28 Oct 2011 14:41:26 +0200,
 Thomas> Peter Korsgaard <jacmet@sunsite.dk> a ?crit :

 >> avoid gawk complaining

 Thomas> about what ?

Not finding host-ccache as it isn't built yet.

 >> when running 'make ctng-menuconfig' in a
 >> clean/distclean tree in which ccache and crosstool-ng are enabled

 Thomas> This sounds like a workaround. The ordering of dependencies inside a
 Thomas> _DEPENDENCIES variable shouldn't matter. Isn't it a missing dependency
 Thomas> somewhere else ?

Well, yes - but host-ccache is special as it needs to be built before
anything else. I don't think it makes sense to add a bunch of

ifeq ($(BR2_CCACHE),y)
FOO_DEPENDENCIES += host-ccache
endif

to the packages.

-- 
Bye, Peter Korsgaard

[Buildroot] [git commit] crosstool-ng: fix ccache dependencies order

[Thomas De Schampheleire]

On Sat, Oct 29, 2011 at 8:54 AM, Peter Korsgaard <jacmet@uclibc.org> wrote:
>>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
>
> ?Thomas> Le Fri, 28 Oct 2011 14:41:26 +0200,
> ?Thomas> Peter Korsgaard <jacmet@sunsite.dk> a ?crit :
>
> ?>> avoid gawk complaining
>
> ?Thomas> about what ?
>
> Not finding host-ccache as it isn't built yet.
>
> ?>> when running 'make ctng-menuconfig' in a
> ?>> clean/distclean tree in which ccache and crosstool-ng are enabled
>
> ?Thomas> This sounds like a workaround. The ordering of dependencies inside a
> ?Thomas> _DEPENDENCIES variable shouldn't matter. Isn't it a missing dependency
> ?Thomas> somewhere else ?
>
> Well, yes - but host-ccache is special as it needs to be built before
> anything else. I don't think it makes sense to add a bunch of
>
> ifeq ($(BR2_CCACHE),y)
> FOO_DEPENDENCIES += host-ccache
> endif
>
> to the packages.

In that case, you could move the dependency to
toolchain/dependencies/dependencies.mk.

Best regards,
Thomas