Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] libarchive: add conditional dependency on zlib
@ 2009-10-22 21:14 Sven Neumann
  2009-10-23  7:37 ` Peter Korsgaard
  0 siblings, 1 reply; 4+ messages in thread
From: Sven Neumann @ 2009-10-22 21:14 UTC (permalink / raw)
  To: buildroot

If zlib is selected, then it should be built before libarchive so that
libarchive picks up the headers and includes support for zlib
compression.

Signed-off-by: Sven Neumann <s.neumann@raumfeld.com>
---
 package/libarchive/libarchive.mk |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/package/libarchive/libarchive.mk b/package/libarchive/libarchive.mk
index 32f68f7..6a2706f 100644
--- a/package/libarchive/libarchive.mk
+++ b/package/libarchive/libarchive.mk
@@ -10,6 +10,9 @@ LIBARCHIVE_LIBTOOL_PATCH = NO
 LIBARCHIVE_INSTALL_STAGING = YES
 LIBARCHIVE_INSTALL_TARGET = YES
 
+ifeq ($(BR2_PACKAGE_ZLIB),y)
+LIBARCHIVE_DEPENDENCIES = zlib
+
 LIBARCHIVE_CONF_OPT = \
 	$(if $(BR2_PACKAGE_LIBARCHIVE_BSDTAR),--enable-bsdtar,--disable-bsdtar) \
 	$(if $(BR2_PACKAGE_LIBARCHIVE_BSDCPIO),--enable-bsdcpio,--disable-bsdcpio)
-- 
1.6.5

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH] libarchive: add conditional dependency on zlib
  2009-10-22 21:14 [Buildroot] [PATCH] libarchive: add conditional dependency on zlib Sven Neumann
@ 2009-10-23  7:37 ` Peter Korsgaard
  2009-10-23  7:53   ` Sven Neumann
  0 siblings, 1 reply; 4+ messages in thread
From: Peter Korsgaard @ 2009-10-23  7:37 UTC (permalink / raw)
  To: buildroot

>>>>> "Sven" == Sven Neumann <s.neumann@raumfeld.com> writes:

 Sven> If zlib is selected, then it should be built before libarchive so that
 Sven> libarchive picks up the headers and includes support for zlib
 Sven> compression.

 Sven> Signed-off-by: Sven Neumann <s.neumann@raumfeld.com>
 Sven> ---
 Sven>  package/libarchive/libarchive.mk |    3 +++
 Sven>  1 files changed, 3 insertions(+), 0 deletions(-)

 Sven> diff --git a/package/libarchive/libarchive.mk b/package/libarchive/libarchive.mk
 Sven> index 32f68f7..6a2706f 100644
 Sven> --- a/package/libarchive/libarchive.mk
 Sven> +++ b/package/libarchive/libarchive.mk
 Sven> @@ -10,6 +10,9 @@ LIBARCHIVE_LIBTOOL_PATCH = NO
 Sven>  LIBARCHIVE_INSTALL_STAGING = YES
 Sven>  LIBARCHIVE_INSTALL_TARGET = YES
 
 Sven> +ifeq ($(BR2_PACKAGE_ZLIB),y)
 Sven> +LIBARCHIVE_DEPENDENCIES = zlib
 Sven> +

Where's the endif?


-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH] libarchive: add conditional dependency on zlib
  2009-10-23  7:37 ` Peter Korsgaard
@ 2009-10-23  7:53   ` Sven Neumann
  2009-10-23  8:15     ` Peter Korsgaard
  0 siblings, 1 reply; 4+ messages in thread
From: Sven Neumann @ 2009-10-23  7:53 UTC (permalink / raw)
  To: buildroot

If zlib is selected, then it should be built before libarchive so that
libarchive picks up the headers and includes support for zlib
compression.

Signed-off-by: Sven Neumann <s.neumann@raumfeld.com>
---
 package/libarchive/libarchive.mk |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/package/libarchive/libarchive.mk b/package/libarchive/libarchive.mk
index 32f68f7..efd1656 100644
--- a/package/libarchive/libarchive.mk
+++ b/package/libarchive/libarchive.mk
@@ -10,6 +10,10 @@ LIBARCHIVE_LIBTOOL_PATCH = NO
 LIBARCHIVE_INSTALL_STAGING = YES
 LIBARCHIVE_INSTALL_TARGET = YES
 
+ifeq ($(BR2_PACKAGE_ZLIB),y)
+LIBARCHIVE_DEPENDENCIES = zlib
+endif
+
 LIBARCHIVE_CONF_OPT = \
 	$(if $(BR2_PACKAGE_LIBARCHIVE_BSDTAR),--enable-bsdtar,--disable-bsdtar) \
 	$(if $(BR2_PACKAGE_LIBARCHIVE_BSDCPIO),--enable-bsdcpio,--disable-bsdcpio)
-- 
1.6.5

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH] libarchive: add conditional dependency on zlib
  2009-10-23  7:53   ` Sven Neumann
@ 2009-10-23  8:15     ` Peter Korsgaard
  0 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2009-10-23  8:15 UTC (permalink / raw)
  To: buildroot

>>>>> "Sven" == Sven Neumann <s.neumann@raumfeld.com> writes:

 Sven> If zlib is selected, then it should be built before libarchive so that
 Sven> libarchive picks up the headers and includes support for zlib
 Sven> compression.

Committed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2009-10-23  8:15 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-22 21:14 [Buildroot] [PATCH] libarchive: add conditional dependency on zlib Sven Neumann
2009-10-23  7:37 ` Peter Korsgaard
2009-10-23  7:53   ` Sven Neumann
2009-10-23  8:15     ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox