Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/sdl3: fix X11 dependencies
@ 2026-09-08  8:06 Bernd Kuhls
  2026-09-22 19:22 ` Julien Olivain via buildroot
  0 siblings, 1 reply; 2+ messages in thread
From: Bernd Kuhls @ 2026-09-08  8:06 UTC (permalink / raw)
  To: buildroot; +Cc: Michael Fischer

Add handling for optional X11 dependencies to fix configure errors:

CMake Error at cmake/macros.cmake:433 (message):
  Couldn't find dependency package for XCURSOR.  Please install the needed
  packages or configure with -DSDL_X11_XCURSOR=OFF

CMake Error at cmake/macros.cmake:433 (message):
  Couldn't find dependency package for XINPUT.  Please install the needed
  packages or configure with -DSDL_X11_XINPUT=OFF

CMake Error at cmake/macros.cmake:433 (message):
  Couldn't find dependency package for XSCRNSAVER.  Please install the needed
  packages or configure with -DSDL_X11_XSCRNSAVER=OFF

CMake Error at cmake/macros.cmake:433 (message):
  Couldn't find dependency package for XTEST.  Please install the needed
  packages or configure with -DSDL_X11_XTEST=OFF

Please note that SDL3 only checks for these dependencies when X11
support is enabled so we do not need to add =OFF options to the else-
clause -DSDL_X11=OFF:
https://github.com/libsdl-org/SDL/blob/release-3.4.12/cmake/sdlchecks.cmake#L325

Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
---
 package/sdl3/sdl3.mk | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/package/sdl3/sdl3.mk b/package/sdl3/sdl3.mk
index ecbcbf4bc2..83c28b1b04 100644
--- a/package/sdl3/sdl3.mk
+++ b/package/sdl3/sdl3.mk
@@ -59,6 +59,30 @@ endif
 ifeq ($(BR2_PACKAGE_SDL3_X11),y)
 SDL3_DEPENDENCIES += xlib_libX11 xlib_libXext
 SDL3_CONF_OPTS += -DSDL_X11=ON
+ifeq ($(BR2_PACKAGE_XAPP_XINPUT),y)
+SDL3_DEPENDENCIES += xapp_xinput
+SDL3_CONF_OPTS += -DSDL_X11_XINPUT=ON
+else
+SDL3_CONF_OPTS += -DSDL_X11_XINPUT=OFF
+endif
+ifeq ($(BR2_PACKAGE_XLIB_LIBXCURSOR),y)
+SDL3_DEPENDENCIES += xlib_libXcursor
+SDL3_CONF_OPTS += -DSDL_X11_XCURSOR=ON
+else
+SDL3_CONF_OPTS += -DSDL_X11_XCURSOR=OFF
+endif
+ifeq ($(BR2_PACKAGE_XLIB_LIBXSCRNSAVER),y)
+SDL3_DEPENDENCIES += xlib_libXScrnSaver
+SDL3_CONF_OPTS += -DSDL_X11_XSCRNSAVER=ON
+else
+SDL3_CONF_OPTS += -DSDL_X11_XSCRNSAVER=OFF
+endif
+ifeq ($(BR2_PACKAGE_XLIB_LIBXTST),y)
+SDL3_DEPENDENCIES += xlib_libXtst
+SDL3_CONF_OPTS += -DSDL_X11_XTEST=ON
+else
+SDL3_CONF_OPTS += -DSDL_X11_XTEST=OFF
+endif
 else
 SDL3_CONF_OPTS += -DSDL_X11=OFF
 endif
-- 
2.47.3

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/sdl3: fix X11 dependencies
  2026-09-08  8:06 [Buildroot] [PATCH 1/1] package/sdl3: fix X11 dependencies Bernd Kuhls
@ 2026-09-22 19:22 ` Julien Olivain via buildroot
  0 siblings, 0 replies; 2+ messages in thread
From: Julien Olivain via buildroot @ 2026-09-22 19:22 UTC (permalink / raw)
  To: Bernd Kuhls; +Cc: buildroot, Michael Fischer

Hi Bernd,

Thanks for the patch.

On 08/09/2026 10:06, Bernd Kuhls wrote:
> Add handling for optional X11 dependencies to fix configure errors:
> 
> CMake Error at cmake/macros.cmake:433 (message):
>   Couldn't find dependency package for XCURSOR.  Please install the 
> needed
>   packages or configure with -DSDL_X11_XCURSOR=OFF
> 
> CMake Error at cmake/macros.cmake:433 (message):
>   Couldn't find dependency package for XINPUT.  Please install the 
> needed
>   packages or configure with -DSDL_X11_XINPUT=OFF
> 
> CMake Error at cmake/macros.cmake:433 (message):
>   Couldn't find dependency package for XSCRNSAVER.  Please install the 
> needed
>   packages or configure with -DSDL_X11_XSCRNSAVER=OFF
> 
> CMake Error at cmake/macros.cmake:433 (message):
>   Couldn't find dependency package for XTEST.  Please install the 
> needed
>   packages or configure with -DSDL_X11_XTEST=OFF

While trying this patch with the following commands:

cat >.config <<EOF
BR2_aarch64=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_PACKAGE_SDL3=y
BR2_PACKAGE_SDL3_X11=y
BR2_PACKAGE_XORG7=y
EOF
make olddefconfig
make sdl3

I had the following error:

CMake Error at cmake/macros.cmake:433 (message):
   Couldn't find dependency package for XFIXES.  Please install the 
needed
   packages or configure with -DSDL_X11_XFIXES=OFF

Could you have a look, please?

I did not checked if there is other instances of those dependency 
checks.

> Please note that SDL3 only checks for these dependencies when X11
> support is enabled so we do not need to add =OFF options to the else-
> clause -DSDL_X11=OFF:
> https://github.com/libsdl-org/SDL/blob/release-3.4.12/cmake/sdlchecks.cmake#L325
> 
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>

Best regards,

Julien.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-09-22 19:22 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-08  8:06 [Buildroot] [PATCH 1/1] package/sdl3: fix X11 dependencies Bernd Kuhls
2026-09-22 19:22 ` Julien Olivain via buildroot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox