Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] package/pahole: bump to version 1.28
@ 2025-04-15  7:19 Alexis Lothoré via buildroot
  2025-04-15 17:23 ` Julien Olivain
  0 siblings, 1 reply; 5+ messages in thread
From: Alexis Lothoré via buildroot @ 2025-04-15  7:19 UTC (permalink / raw)
  To: buildroot; +Cc: Thomas Petazzoni, Francis Laniel, Alexis Lothoré

On hosts with a recent version of cmake (eg: 4.0.0), builds involving
host-pahole fail with the following error:

CMake Deprecation Warning at CMakeLists.txt:1 (cmake_minimum_required):
  Compatibility with CMake < 3.5 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.

The issue has already fixed in the upstream project with commit
12ca11281912 ("CMakeLists.txt: Require cmake 3.5 or higher"), which is
part of version 1.28.

Upgrade pahole to get rid of this error.

https://git.kernel.org/pub/scm/devel/pahole/pahole.git/tree/NEWS?h=v1.28

Signed-off-by: Alexis Lothoré <alexis.lothore@bootlin.com>
---
The issue is reproducible with this defconfig:

BR2_arm=y
BR2_cortex_a7=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_TOOLCHAIN_EXTERNAL_BOOTLIN=y
BR2_LINUX_KERNEL=y
BR2_LINUX_KERNEL_DEFCONFIG="versatile"
BR2_LINUX_KERNEL_NEEDS_HOST_PAHOLE=y

It has originaly been detected on an older buildroot release branch. The
issue is also present on 2025.02.x, do you want me to send the patch
backport fixing the issue on the current release branch ?
---
 package/pahole/pahole.hash | 2 +-
 package/pahole/pahole.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/pahole/pahole.hash b/package/pahole/pahole.hash
index a2d3d044da85fefa365a2973bc3703fa3cb3e1da..efa12184687e5faae5092515db1489bb52f7db50 100644
--- a/package/pahole/pahole.hash
+++ b/package/pahole/pahole.hash
@@ -1,3 +1,3 @@
 # Locally computed
-sha256  87223298d4f8f9ada9b3cc5cef1bedd7aeb447cd8295abc466e009a26accff13  pahole-1.27.tar.gz
+sha256  9a319c214b38554be8430a672043d85735564e8e1e78db5a41cba7a03d038056  pahole-1.28.tar.gz
 sha256  ab15fd526bd8dd18a9e77ebc139656bf4d33e97fc7238cd11bf60e2b9b8666c6  COPYING
diff --git a/package/pahole/pahole.mk b/package/pahole/pahole.mk
index ffbe4ff925871d31c30ef5b406103caae9461dd9..150373fd7e17999d52b36e99837f349476c6116f 100644
--- a/package/pahole/pahole.mk
+++ b/package/pahole/pahole.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-PAHOLE_VERSION = 1.27
+PAHOLE_VERSION = 1.28
 PAHOLE_SITE = https://git.kernel.org/pub/scm/devel/pahole/pahole.git/snapshot
 HOST_PAHOLE_DEPENDENCIES = \
 	host-elfutils \

---
base-commit: 76b4fd159bcdba97eefdbc4299a7ae9b0a4cd423
change-id: 20250414-bump_pahole-9d6148493b0b

Best regards,
-- 
Alexis Lothoré, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [Buildroot] [PATCH] package/pahole: bump to version 1.28
  2025-04-15  7:19 [Buildroot] [PATCH] package/pahole: bump to version 1.28 Alexis Lothoré via buildroot
@ 2025-04-15 17:23 ` Julien Olivain
  2025-04-15 21:07   ` Alexis Lothoré via buildroot
  0 siblings, 1 reply; 5+ messages in thread
From: Julien Olivain @ 2025-04-15 17:23 UTC (permalink / raw)
  To: Alexis Lothoré; +Cc: buildroot, Thomas Petazzoni, Francis Laniel

On 15/04/2025 09:19, Alexis Lothoré via buildroot wrote:
> On hosts with a recent version of cmake (eg: 4.0.0), builds involving
> host-pahole fail with the following error:
> 
> CMake Deprecation Warning at CMakeLists.txt:1 (cmake_minimum_required):
>   Compatibility with CMake < 3.5 will be removed from a future version 
> of
>   CMake.
> 
>   Update the VERSION argument <min> value or use a ...<max> suffix to 
> tell
>   CMake that the project does not need compatibility with older 
> versions.
> 
> The issue has already fixed in the upstream project with commit
> 12ca11281912 ("CMakeLists.txt: Require cmake 3.5 or higher"), which is
> part of version 1.28.
> 
> Upgrade pahole to get rid of this error.
> 
> https://git.kernel.org/pub/scm/devel/pahole/pahole.git/tree/NEWS?h=v1.28
> 
> Signed-off-by: Alexis Lothoré <alexis.lothore@bootlin.com>

Applied to master, thanks.

I also added in the commit log your example config which
reproduces the issue.

Best regards,

Julien.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Buildroot] [PATCH] package/pahole: bump to version 1.28
  2025-04-15 17:23 ` Julien Olivain
@ 2025-04-15 21:07   ` Alexis Lothoré via buildroot
  2025-04-18 10:37     ` Thomas Petazzoni via buildroot
  0 siblings, 1 reply; 5+ messages in thread
From: Alexis Lothoré via buildroot @ 2025-04-15 21:07 UTC (permalink / raw)
  To: Julien Olivain; +Cc: buildroot, Thomas Petazzoni, Francis Laniel

Hello Julien,

On Tue Apr 15, 2025 at 7:23 PM CEST, Julien Olivain wrote:
> On 15/04/2025 09:19, Alexis Lothoré via buildroot wrote:
>> On hosts with a recent version of cmake (eg: 4.0.0), builds involving
>> host-pahole fail with the following error:
>> 
>> CMake Deprecation Warning at CMakeLists.txt:1 (cmake_minimum_required):
>>   Compatibility with CMake < 3.5 will be removed from a future version 
>> of
>>   CMake.
>> 
>>   Update the VERSION argument <min> value or use a ...<max> suffix to 
>> tell
>>   CMake that the project does not need compatibility with older 
>> versions.
>> 
>> The issue has already fixed in the upstream project with commit
>> 12ca11281912 ("CMakeLists.txt: Require cmake 3.5 or higher"), which is
>> part of version 1.28.
>> 
>> Upgrade pahole to get rid of this error.
>> 
>> https://git.kernel.org/pub/scm/devel/pahole/pahole.git/tree/NEWS?h=v1.28
>> 
>> Signed-off-by: Alexis Lothoré <alexis.lothore@bootlin.com>
>
> Applied to master, thanks.
>
> I also added in the commit log your example config which
> reproduces the issue.

Nice, thanks.

In case it has slipped through: as the issue also exists on the current
release branch, do you want me to send a patch targeting the 2025.02.x
branch to backport the upstream patch fixing the issue ? (because I guess
bumping the package version on the release branch is not an option ?)

Thanks,

Alexis
>
> Best regards,
>
> Julien.
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot




-- 
Alexis Lothoré, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Buildroot] [PATCH] package/pahole: bump to version 1.28
  2025-04-15 21:07   ` Alexis Lothoré via buildroot
@ 2025-04-18 10:37     ` Thomas Petazzoni via buildroot
  2025-04-18 18:28       ` Alexis Lothoré via buildroot
  0 siblings, 1 reply; 5+ messages in thread
From: Thomas Petazzoni via buildroot @ 2025-04-18 10:37 UTC (permalink / raw)
  To: Alexis Lothoré
  Cc: Julien Olivain, buildroot, Francis Laniel, Thomas Perale

On Tue, 15 Apr 2025 23:07:39 +0200
Alexis Lothoré <alexis.lothore@bootlin.com> wrote:

> In case it has slipped through: as the issue also exists on the current
> release branch, do you want me to send a patch targeting the 2025.02.x
> branch to backport the upstream patch fixing the issue ? (because I guess
> bumping the package version on the release branch is not an option ?)

In fact ideally in this situation my personal preference is that from
the start the thing gets submitted as two patches:

1. One doing the backport of the fix, without bumping the version

2. One doing the version bump, dropping the fix backport along the way

This way, we can easily backport (1) to our current LTS/stable branch.

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Buildroot] [PATCH] package/pahole: bump to version 1.28
  2025-04-18 10:37     ` Thomas Petazzoni via buildroot
@ 2025-04-18 18:28       ` Alexis Lothoré via buildroot
  0 siblings, 0 replies; 5+ messages in thread
From: Alexis Lothoré via buildroot @ 2025-04-18 18:28 UTC (permalink / raw)
  To: Thomas Petazzoni; +Cc: Julien Olivain, buildroot, Francis Laniel, Thomas Perale

Hi Thomas,

On Fri Apr 18, 2025 at 12:37 PM CEST, Thomas Petazzoni via buildroot wrote:
> On Tue, 15 Apr 2025 23:07:39 +0200
> Alexis Lothoré <alexis.lothore@bootlin.com> wrote:
>
>> In case it has slipped through: as the issue also exists on the current
>> release branch, do you want me to send a patch targeting the 2025.02.x
>> branch to backport the upstream patch fixing the issue ? (because I guess
>> bumping the package version on the release branch is not an option ?)
>
> In fact ideally in this situation my personal preference is that from
> the start the thing gets submitted as two patches:
>
> 1. One doing the backport of the fix, without bumping the version
>
> 2. One doing the version bump, dropping the fix backport along the way
>
> This way, we can easily backport (1) to our current LTS/stable branch.

ACK, noted for next time.

Alexis

-- 
Alexis Lothoré, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2025-04-18 18:28 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-15  7:19 [Buildroot] [PATCH] package/pahole: bump to version 1.28 Alexis Lothoré via buildroot
2025-04-15 17:23 ` Julien Olivain
2025-04-15 21:07   ` Alexis Lothoré via buildroot
2025-04-18 10:37     ` Thomas Petazzoni via buildroot
2025-04-18 18:28       ` Alexis Lothoré via buildroot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox