Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Gary Bisson <gary.bisson@boundarydevices.com>
To: Christian Hitz <christian@klarinett.li>
Cc: Gary Bisson <bisson.gary@gmail.com>,
	Christian Hitz <christian.hitz@bbv.ch>,
	Refik Tuzakli <tuzakli.refik@gmail.com>,
	thomas.petazzoni@bootlin.com, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/freescale-imx/firmware-imx: fix installation with merged usr dirs
Date: Wed, 21 Dec 2022 09:32:32 +0100	[thread overview]
Message-ID: <Y6LEoC1iXjhW77XR@p1g2> (raw)
In-Reply-To: <20221220133454.1931855-1-christian@klarinett.li>

Hi Christian,

On Tue, Dec 20, 2022 at 02:34:53PM +0100, Christian Hitz wrote:
> From: Christian Hitz <christian.hitz@bbv.ch>
> 
> Currently, the firmware files are installed to /lib/firmware/imx. With
> BR2_ROOTFS_MERGED_USR=y /lib is replaced with a symlink to /usr/lib
> effectively deleting the installed firmware files.
> 
> Install the firmware files into the /usr/lib/firmware/imx prefix instead.
> 
> Signed-off-by: Christian Hitz <christian.hitz@bbv.ch>
> ---
> Backport to: 2022.02.x, 2022.11.x
> ---

Thanks for your contribution, looks good to me! That brings the question
about linux-firmware that doesn't seem to handle that case either.
Thomas, should we have a generic TARGET_FIRMWARE_DIR that switches from
/lib/firmware to /usr/lib/firmware automatically? That way it would fix
it for all packages at once.

Otherwise:
Reviewed-by: Gary Bisson <gary.bisson@boundarydevices.com>

Regards,
Gary
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-12-21  8:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-20 13:34 [Buildroot] [PATCH] package/freescale-imx/firmware-imx: fix installation with merged usr dirs Christian Hitz
2022-12-21  8:32 ` Gary Bisson [this message]
2022-12-21  9:54   ` Yann E. MORIN
2022-12-21  9:57     ` Gary Bisson
2022-12-21  9:48 ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y6LEoC1iXjhW77XR@p1g2 \
    --to=gary.bisson@boundarydevices.com \
    --cc=bisson.gary@gmail.com \
    --cc=buildroot@buildroot.org \
    --cc=christian.hitz@bbv.ch \
    --cc=christian@klarinett.li \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=tuzakli.refik@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox