From: Gary Bisson <gary.bisson@boundarydevices.com>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Gary Bisson <bisson.gary@gmail.com>,
Christian Hitz <christian@klarinett.li>,
Refik Tuzakli <tuzakli.refik@gmail.com>,
thomas.petazzoni@bootlin.com, buildroot@buildroot.org,
Christian Hitz <christian.hitz@bbv.ch>
Subject: Re: [Buildroot] [PATCH] package/freescale-imx/firmware-imx: fix installation with merged usr dirs
Date: Wed, 21 Dec 2022 10:57:23 +0100 [thread overview]
Message-ID: <Y6LYg4Z22P1320e8@p1g2> (raw)
In-Reply-To: <20221221095431.GK2909@scaer>
Hi Yann,
On Wed, Dec 21, 2022 at 10:54:31AM +0100, Yann E. MORIN wrote:
> Gary, All,
>
> On 2022-12-21 09:32 +0100, Gary Bisson spake thusly:
> > On Tue, Dec 20, 2022 at 02:34:53PM +0100, Christian Hitz wrote:
> > > From: Christian Hitz <christian.hitz@bbv.ch>
> > >
> > > Currently, the firmware files are installed to /lib/firmware/imx. With
> > > BR2_ROOTFS_MERGED_USR=y /lib is replaced with a symlink to /usr/lib
> > > effectively deleting the installed firmware files.
> > >
> > > Install the firmware files into the /usr/lib/firmware/imx prefix instead.
> > >
> > > Signed-off-by: Christian Hitz <christian.hitz@bbv.ch>
> > > ---
> > > Backport to: 2022.02.x, 2022.11.x
> > > ---
> > Thanks for your contribution, looks good to me! That brings the question
> > about linux-firmware that doesn't seem to handle that case either.
> > Thomas, should we have a generic TARGET_FIRMWARE_DIR that switches from
> > /lib/firmware to /usr/lib/firmware automatically? That way it would fix
> > it for all packages at once.
>
> As I explained in my reply to Christian: this should not be needed,
> because the /lib symlink is created by the skeleton, which are installed
> before any other package. So, all packages should see the proper /lib
> symlink.
>
> Note that we've introduced merged-usr quite a long time ago now (more
> than 7 years ago!), and it has been used by many people (I included)
> without that issue surfacing so far for linux-firmware, so I'd be
> surprised that there is an actual issue for any of the (well behaved!)
> firmware packages... ;-)
Indeed it makes sense. I wasn't aware of that option so I never tried
it. So my suggestion was only applicable if the problem does exist
indeed. Next time I'll make sure to give it a try ;)
Thanks,
Gary
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-12-21 9:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-20 13:34 [Buildroot] [PATCH] package/freescale-imx/firmware-imx: fix installation with merged usr dirs Christian Hitz
2022-12-21 8:32 ` Gary Bisson
2022-12-21 9:54 ` Yann E. MORIN
2022-12-21 9:57 ` Gary Bisson [this message]
2022-12-21 9:48 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y6LYg4Z22P1320e8@p1g2 \
--to=gary.bisson@boundarydevices.com \
--cc=bisson.gary@gmail.com \
--cc=buildroot@buildroot.org \
--cc=christian.hitz@bbv.ch \
--cc=christian@klarinett.li \
--cc=thomas.petazzoni@bootlin.com \
--cc=tuzakli.refik@gmail.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox