From: Sergey Matyukevich <geomatsi@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] configs/solidrun_macchiatobin_defconfig: include for Singleshot DTS
Date: Fri, 23 Apr 2021 11:04:20 +0300 [thread overview]
Message-ID: <YIJ/hCCHwdpMG1DN@curiosity> (raw)
In-Reply-To: <20210420231650.0d34ce07@windsurf.home>
Hi Vadym, Thomas,
> > > BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.10.5"
> > > BR2_LINUX_KERNEL_USE_ARCH_DEFAULT_CONFIG=y
> > > BR2_LINUX_KERNEL_DTS_SUPPORT=y
> > > -BR2_LINUX_KERNEL_INTREE_DTS_NAME="marvell/armada-8040-mcbin"
> > > +BR2_LINUX_KERNEL_INTREE_DTS_NAME="marvell/armada-8040-mcbin marvell/armada-8040-mcbin-singleshot"
> > > BR2_LINUX_KERNEL_CONFIG_FRAGMENT_FILES="board/solidrun/macchiatobin/linux-extras.config"
> > > BR2_LINUX_KERNEL_INSTALL_TARGET=y
> > > BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y
> >
> > I do not have access to MacchiatoBin hardware anymore, but I have been using
> > current defconfig with DoubleShot boards. If this defconfig does not work
> > well for SingleShot boards, then it makes sense to add a separate defconfig
> > for such boards rather then remove DoubleShot support completely. Probably
> > linux-extras.config in board/solidrun/macchiatobin worth another look to
> > make sure that features for both boards are included.
>
> I am confused: the only change proposed here is to build two DTBs
> instead of one, leaving up to the user to use one or the other
> depending on the board variant. Why would two defconfigs be needed here?
>
> However, one thing is needed: an update to
> board/solidrun/macchiatobin/readme.txt to indicate when to use which
> DTB.
My apologies - I totally misread this patch. Indeed, it does not replace
DoubleShot by SingleShot board, but adds yet another dts option. In this
case readme.txt needs an update. Besides, another extlinux menu entry
can be added, probably with some notes in readme.txt on how to select
default boot option.
Regards,
Sergey
prev parent reply other threads:[~2021-04-23 8:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 7:33 [Buildroot] [PATCH] configs/solidrun_macchiatobin_defconfig: include for Singleshot DTS Vadym Kochan
2021-04-08 8:18 ` Sergey Matyukevich
2021-04-09 12:45 ` Vadym Kochan
2021-04-09 18:53 ` Sergey Matyukevich
2021-04-09 18:58 ` Vadym Kochan
2021-04-14 15:59 ` Vadym Kochan
2021-04-14 18:27 ` Sergey Matyukevich
2021-04-15 11:07 ` Vadym Kochan
2021-04-20 21:16 ` Thomas Petazzoni
2021-04-23 8:04 ` Sergey Matyukevich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YIJ/hCCHwdpMG1DN@curiosity \
--to=geomatsi@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox