From: Petr Vorel <petr.vorel@gmail.com>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: James Hilliard <james.hilliard1@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/libtirpc: add missing !BR2_STATIC_LIBS dependency
Date: Sun, 25 Jul 2021 23:18:48 +0200 [thread overview]
Message-ID: <YP3VOL6D4qfc8CUo@pevik> (raw)
In-Reply-To: <20210725231524.512d0549@windsurf>
Hi James, Thomas,
> On Sun, 25 Jul 2021 14:46:24 -0600
> James Hilliard <james.hilliard1@gmail.com> wrote:
> > Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> > ---
> > package/libtirpc/Config.in | 1 +
> > 1 file changed, 1 insertion(+)
> > diff --git a/package/libtirpc/Config.in b/package/libtirpc/Config.in
> > index 1899edefbf..6a900c68c3 100644
> > --- a/package/libtirpc/Config.in
> > +++ b/package/libtirpc/Config.in
> > @@ -10,6 +10,7 @@ config BR2_PACKAGE_LIBTIRPC
> > config BR2_PACKAGE_LIBTIRPC_GSS
> > bool "gss"
> > depends on BR2_USE_MMU # libkrb5
> > + depends on !BR2_STATIC_LIBS # libkrb5
> > depends on BR2_PACKAGE_LIBTIRPC
> > select BR2_PACKAGE_LIBKRB5
> > help
> Thanks, but a bit more than that is needed:
> (1) A Config.in "comment" in package/libtirpc/Config.in
> (2) The propagation of this "depends on" in places where
> BR2_PACKAGE_LIBTIRPC_GSS is selected, i.e in
> BR2_PACKAGE_NFS_UTILS_GSS. A Config.in comment will be needed as
> well.
I'm sorry to not catching these.
Kind regards,
Petr
> Thanks!
> Thomas
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
next prev parent reply other threads:[~2021-07-25 21:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-25 20:46 [Buildroot] [PATCH 1/1] package/libtirpc: add missing !BR2_STATIC_LIBS dependency James Hilliard
2021-07-25 21:15 ` Thomas Petazzoni
2021-07-25 21:18 ` Petr Vorel [this message]
2021-07-25 21:29 ` James Hilliard
2021-07-25 21:17 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YP3VOL6D4qfc8CUo@pevik \
--to=petr.vorel@gmail.com \
--cc=buildroot@buildroot.org \
--cc=james.hilliard1@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox