* [Buildroot] [PATCH 1/1] package/libtirpc: add missing !BR2_STATIC_LIBS dependency
@ 2021-07-25 20:46 James Hilliard
2021-07-25 21:15 ` Thomas Petazzoni
2021-07-25 21:17 ` Petr Vorel
0 siblings, 2 replies; 5+ messages in thread
From: James Hilliard @ 2021-07-25 20:46 UTC (permalink / raw)
To: buildroot; +Cc: James Hilliard, Thomas Petazzoni
Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
---
package/libtirpc/Config.in | 1 +
1 file changed, 1 insertion(+)
diff --git a/package/libtirpc/Config.in b/package/libtirpc/Config.in
index 1899edefbf..6a900c68c3 100644
--- a/package/libtirpc/Config.in
+++ b/package/libtirpc/Config.in
@@ -10,6 +10,7 @@ config BR2_PACKAGE_LIBTIRPC
config BR2_PACKAGE_LIBTIRPC_GSS
bool "gss"
depends on BR2_USE_MMU # libkrb5
+ depends on !BR2_STATIC_LIBS # libkrb5
depends on BR2_PACKAGE_LIBTIRPC
select BR2_PACKAGE_LIBKRB5
help
--
2.25.1
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/libtirpc: add missing !BR2_STATIC_LIBS dependency
2021-07-25 20:46 [Buildroot] [PATCH 1/1] package/libtirpc: add missing !BR2_STATIC_LIBS dependency James Hilliard
@ 2021-07-25 21:15 ` Thomas Petazzoni
2021-07-25 21:18 ` Petr Vorel
2021-07-25 21:29 ` James Hilliard
2021-07-25 21:17 ` Petr Vorel
1 sibling, 2 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2021-07-25 21:15 UTC (permalink / raw)
To: James Hilliard; +Cc: buildroot
On Sun, 25 Jul 2021 14:46:24 -0600
James Hilliard <james.hilliard1@gmail.com> wrote:
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
> package/libtirpc/Config.in | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/package/libtirpc/Config.in b/package/libtirpc/Config.in
> index 1899edefbf..6a900c68c3 100644
> --- a/package/libtirpc/Config.in
> +++ b/package/libtirpc/Config.in
> @@ -10,6 +10,7 @@ config BR2_PACKAGE_LIBTIRPC
> config BR2_PACKAGE_LIBTIRPC_GSS
> bool "gss"
> depends on BR2_USE_MMU # libkrb5
> + depends on !BR2_STATIC_LIBS # libkrb5
> depends on BR2_PACKAGE_LIBTIRPC
> select BR2_PACKAGE_LIBKRB5
> help
Thanks, but a bit more than that is needed:
(1) A Config.in "comment" in package/libtirpc/Config.in
(2) The propagation of this "depends on" in places where
BR2_PACKAGE_LIBTIRPC_GSS is selected, i.e in
BR2_PACKAGE_NFS_UTILS_GSS. A Config.in comment will be needed as
well.
Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Buildroot] [PATCH 1/1] package/libtirpc: add missing !BR2_STATIC_LIBS dependency
2021-07-25 21:15 ` Thomas Petazzoni
@ 2021-07-25 21:18 ` Petr Vorel
2021-07-25 21:29 ` James Hilliard
1 sibling, 0 replies; 5+ messages in thread
From: Petr Vorel @ 2021-07-25 21:18 UTC (permalink / raw)
To: Thomas Petazzoni; +Cc: James Hilliard, buildroot
Hi James, Thomas,
> On Sun, 25 Jul 2021 14:46:24 -0600
> James Hilliard <james.hilliard1@gmail.com> wrote:
> > Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> > ---
> > package/libtirpc/Config.in | 1 +
> > 1 file changed, 1 insertion(+)
> > diff --git a/package/libtirpc/Config.in b/package/libtirpc/Config.in
> > index 1899edefbf..6a900c68c3 100644
> > --- a/package/libtirpc/Config.in
> > +++ b/package/libtirpc/Config.in
> > @@ -10,6 +10,7 @@ config BR2_PACKAGE_LIBTIRPC
> > config BR2_PACKAGE_LIBTIRPC_GSS
> > bool "gss"
> > depends on BR2_USE_MMU # libkrb5
> > + depends on !BR2_STATIC_LIBS # libkrb5
> > depends on BR2_PACKAGE_LIBTIRPC
> > select BR2_PACKAGE_LIBKRB5
> > help
> Thanks, but a bit more than that is needed:
> (1) A Config.in "comment" in package/libtirpc/Config.in
> (2) The propagation of this "depends on" in places where
> BR2_PACKAGE_LIBTIRPC_GSS is selected, i.e in
> BR2_PACKAGE_NFS_UTILS_GSS. A Config.in comment will be needed as
> well.
I'm sorry to not catching these.
Kind regards,
Petr
> Thanks!
> Thomas
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/libtirpc: add missing !BR2_STATIC_LIBS dependency
2021-07-25 21:15 ` Thomas Petazzoni
2021-07-25 21:18 ` Petr Vorel
@ 2021-07-25 21:29 ` James Hilliard
1 sibling, 0 replies; 5+ messages in thread
From: James Hilliard @ 2021-07-25 21:29 UTC (permalink / raw)
To: Thomas Petazzoni; +Cc: buildroot
On Sun, Jul 25, 2021 at 3:15 PM Thomas Petazzoni
<thomas.petazzoni@bootlin.com> wrote:
>
> On Sun, 25 Jul 2021 14:46:24 -0600
> James Hilliard <james.hilliard1@gmail.com> wrote:
>
> > Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> > ---
> > package/libtirpc/Config.in | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/package/libtirpc/Config.in b/package/libtirpc/Config.in
> > index 1899edefbf..6a900c68c3 100644
> > --- a/package/libtirpc/Config.in
> > +++ b/package/libtirpc/Config.in
> > @@ -10,6 +10,7 @@ config BR2_PACKAGE_LIBTIRPC
> > config BR2_PACKAGE_LIBTIRPC_GSS
> > bool "gss"
> > depends on BR2_USE_MMU # libkrb5
> > + depends on !BR2_STATIC_LIBS # libkrb5
> > depends on BR2_PACKAGE_LIBTIRPC
> > select BR2_PACKAGE_LIBKRB5
> > help
>
> Thanks, but a bit more than that is needed:
>
> (1) A Config.in "comment" in package/libtirpc/Config.in
>
> (2) The propagation of this "depends on" in places where
> BR2_PACKAGE_LIBTIRPC_GSS is selected, i.e in
> BR2_PACKAGE_NFS_UTILS_GSS. A Config.in comment will be needed as
> well.
We do already have a dependency on this in nfs-utils via:
depends on BR2_PACKAGE_NFS_UTILS_NFSV4
which itself depends on:
depends on !BR2_STATIC_LIBS # keyutils, lvm2
>
> Thanks!
>
> Thomas
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/libtirpc: add missing !BR2_STATIC_LIBS dependency
2021-07-25 20:46 [Buildroot] [PATCH 1/1] package/libtirpc: add missing !BR2_STATIC_LIBS dependency James Hilliard
2021-07-25 21:15 ` Thomas Petazzoni
@ 2021-07-25 21:17 ` Petr Vorel
1 sibling, 0 replies; 5+ messages in thread
From: Petr Vorel @ 2021-07-25 21:17 UTC (permalink / raw)
To: James Hilliard; +Cc: Thomas Petazzoni, buildroot
Hi James,
Reviewed-by: Petr Vorel <petr.vorel@gmail.com>
Good catch, thanks!
Kind regards,
Petr
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-07-25 21:31 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-07-25 20:46 [Buildroot] [PATCH 1/1] package/libtirpc: add missing !BR2_STATIC_LIBS dependency James Hilliard
2021-07-25 21:15 ` Thomas Petazzoni
2021-07-25 21:18 ` Petr Vorel
2021-07-25 21:29 ` James Hilliard
2021-07-25 21:17 ` Petr Vorel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox