[Buildroot] [RFC] rpcbind: Remove 0001-Remove-yellow-pages-support.patch

[Buildroot] [RFC] rpcbind: Remove 0001-Remove-yellow-pages-support.patch

[Petr Vorel]

Hi Thomas,

I'm thinking about removing
package/rpcbind/0001-Remove-yellow-pages-support.patch patch.

It was originally added in 2012 in 8bc245da21 ("rpcbind: new package").
At the time constants YPBINDPROC_SETDOM, YPPROG, YPPASSWDPROG were missing in
rpcbind (added in 2015 in rpcbind commit 9e0c7ac ("configure.ac: Check for rpcsvc/mount.h").

I'll verify it, but I'll strongly suspect the only problem was in these missing
constants and very old libtirpc. Thus it should be working now.
Probably the best approach would be to disable legacy yellow pages in upstream,
I can ask for some configure switch. But if you're don't require it, I'd just
drop the patch which is not needed any more.

Patch was also somehow related to package/libtirpc/0001-Disable-parts-of-TIRPC-requiring-NIS-support.patch
(originally added as package/libtirpc/libtirpc-0001-Disable-parts-of-TIRPC-requiring-NIS-support.patch),
which was removed in 883a33ece5 ("libtirpc: remove NIS patch") as not needed.

Kind regards,
Petr
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Re: [Buildroot] [RFC] rpcbind: Remove 0001-Remove-yellow-pages-support.patch

[Thomas Petazzoni]

Hello Petr,

On Sun, 25 Jul 2021 22:14:53 +0200
Petr Vorel <petr.vorel@gmail.com> wrote:

> I'm thinking about removing
> package/rpcbind/0001-Remove-yellow-pages-support.patch patch.
> 
> It was originally added in 2012 in 8bc245da21 ("rpcbind: new package").
> At the time constants YPBINDPROC_SETDOM, YPPROG, YPPASSWDPROG were missing in
> rpcbind (added in 2015 in rpcbind commit 9e0c7ac ("configure.ac: Check for rpcsvc/mount.h").
> 
> I'll verify it, but I'll strongly suspect the only problem was in these missing
> constants and very old libtirpc. Thus it should be working now.
> Probably the best approach would be to disable legacy yellow pages in upstream,
> I can ask for some configure switch. But if you're don't require it, I'd just
> drop the patch which is not needed any more.
> 
> Patch was also somehow related to package/libtirpc/0001-Disable-parts-of-TIRPC-requiring-NIS-support.patch
> (originally added as package/libtirpc/libtirpc-0001-Disable-parts-of-TIRPC-requiring-NIS-support.patch),
> which was removed in 883a33ece5 ("libtirpc: remove NIS patch") as not needed.

Sure, if it all builds/works fine with a more recent libtirpc, I'm all
fine with dropping this patch!

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Re: [Buildroot] [RFC] rpcbind: Remove 0001-Remove-yellow-pages-support.patch

[Petr Vorel]

Hi Thomas,

> Hello Petr,

> On Sun, 25 Jul 2021 22:14:53 +0200
> Petr Vorel <petr.vorel@gmail.com> wrote:

> > I'm thinking about removing
> > package/rpcbind/0001-Remove-yellow-pages-support.patch patch.

> > It was originally added in 2012 in 8bc245da21 ("rpcbind: new package").
> > At the time constants YPBINDPROC_SETDOM, YPPROG, YPPASSWDPROG were missing in
> > rpcbind (added in 2015 in rpcbind commit 9e0c7ac ("configure.ac: Check for rpcsvc/mount.h").

> > I'll verify it, but I'll strongly suspect the only problem was in these missing
> > constants and very old libtirpc. Thus it should be working now.
> > Probably the best approach would be to disable legacy yellow pages in upstream,
> > I can ask for some configure switch. But if you're don't require it, I'd just
> > drop the patch which is not needed any more.

> > Patch was also somehow related to package/libtirpc/0001-Disable-parts-of-TIRPC-requiring-NIS-support.patch
> > (originally added as package/libtirpc/libtirpc-0001-Disable-parts-of-TIRPC-requiring-NIS-support.patch),
> > which was removed in 883a33ece5 ("libtirpc: remove NIS patch") as not needed.

> Sure, if it all builds/works fine with a more recent libtirpc, I'm all
> fine with dropping this patch!
Thanks! I'll verify it and send patch or report if still needed.

Kind regards,
Petr

> Best regards,

> Thomas
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot