From: Petr Vorel <petr.vorel@gmail.com>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
buildroot <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH v2 1/1] package/libtirpc: add missing !BR2_STATIC_LIBS dependency
Date: Sun, 25 Jul 2021 23:57:07 +0200 [thread overview]
Message-ID: <YP3eMwPzJSID6dq1@pevik> (raw)
In-Reply-To: <CADvTj4pmrEavk++tgHuLihp56qRBLi+-P7GkKKq9P_rb3CW6MQ@mail.gmail.com>
> On Sun, Jul 25, 2021 at 3:45 PM Petr Vorel <petr.vorel@gmail.com> wrote:
> > Hi James,
> > > Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> > > ---
> > > Changes v1 -> v2:
> > > - add comment requiring dynamic libraries
> > > ---
> > > package/libtirpc/Config.in | 6 ++++++
> > > 1 file changed, 6 insertions(+)
> > > diff --git a/package/libtirpc/Config.in b/package/libtirpc/Config.in
> > > index 1899edefbf..31f1636ef5 100644
> > > --- a/package/libtirpc/Config.in
> > > +++ b/package/libtirpc/Config.in
> > > @@ -10,6 +10,7 @@ config BR2_PACKAGE_LIBTIRPC
> > > config BR2_PACKAGE_LIBTIRPC_GSS
> > > bool "gss"
> > > depends on BR2_USE_MMU # libkrb5
> > > + depends on !BR2_STATIC_LIBS # libkrb5
> > > depends on BR2_PACKAGE_LIBTIRPC
> > > select BR2_PACKAGE_LIBKRB5
> > > help
> > > @@ -17,3 +18,8 @@ config BR2_PACKAGE_LIBTIRPC_GSS
> > > comment "libtirpc needs a toolchain w/ threads"
> > > depends on !BR2_TOOLCHAIN_HAS_THREADS
> > > +
> > > +comment "libtirpc gss support needs a toolchain w/ dynamic library"
> > > + depends on BR2_USE_MMU
> > > + depends on BR2_STATIC_LIBS
> > > + depends on BR2_PACKAGE_LIBTIRPC
> > Shouldn't the last item depend on BR2_PACKAGE_LIBTIRPC_GSS?
> I don't think so, then it would never be shown AFAIU.
Looking into package/apcupsd/Config.in shows 1) comment should be just below
config (problem also on previous patch) and 2) IMHO "depends on
BR2_PACKAGE_LIBTIRPC" should not be there at all. Or am I missing something?
> > I'd also name it "libtirpc GSS support ..." (capitalize GSS)
> I kept it lowercase for consistency with:
> config BR2_PACKAGE_LIBTIRPC_GSS
> bool "gss"
> Maybe we should change both?
Well, probably better to keep it lowercase.
I thought that first is identifier, other is abbreviation in the name,
but again, looking into package/apcupsd/Config.in shows I$m wrong.
Kind regards,
Petr
> > Kind regards,
> > Petr
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
next prev parent reply other threads:[~2021-07-25 21:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-25 21:34 [Buildroot] [PATCH v2 1/1] package/libtirpc: add missing !BR2_STATIC_LIBS dependency James Hilliard
2021-07-25 21:45 ` Petr Vorel
2021-07-25 21:48 ` James Hilliard
2021-07-25 21:57 ` Petr Vorel [this message]
2021-07-25 21:59 ` Petr Vorel
2021-07-26 21:44 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YP3eMwPzJSID6dq1@pevik \
--to=petr.vorel@gmail.com \
--cc=buildroot@buildroot.org \
--cc=james.hilliard1@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox