Re: [Buildroot] [PATCH v2 1/1] package/libtirpc: add missing !BR2_STATIC_LIBS dependency

[Petr Vorel <petr.vorel@gmail.com>]

> > On Sun, Jul 25, 2021 at 3:45 PM Petr Vorel <petr.vorel@gmail.com> wrote:

> > > Hi James,

> > > > Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> > > > ---
> > > > Changes v1 -> v2:
> > > >   - add comment requiring dynamic libraries
> > > > ---
> > > >  package/libtirpc/Config.in | 6 ++++++
> > > >  1 file changed, 6 insertions(+)

> > > > diff --git a/package/libtirpc/Config.in b/package/libtirpc/Config.in
> > > > index 1899edefbf..31f1636ef5 100644
> > > > --- a/package/libtirpc/Config.in
> > > > +++ b/package/libtirpc/Config.in
> > > > @@ -10,6 +10,7 @@ config BR2_PACKAGE_LIBTIRPC
> > > >  config BR2_PACKAGE_LIBTIRPC_GSS
> > > >       bool "gss"
> > > >       depends on BR2_USE_MMU # libkrb5
> > > > +     depends on !BR2_STATIC_LIBS # libkrb5
> > > >       depends on BR2_PACKAGE_LIBTIRPC
> > > >       select BR2_PACKAGE_LIBKRB5
> > > >       help
> > > > @@ -17,3 +18,8 @@ config BR2_PACKAGE_LIBTIRPC_GSS

> > > >  comment "libtirpc needs a toolchain w/ threads"
> > > >       depends on !BR2_TOOLCHAIN_HAS_THREADS
> > > > +
> > > > +comment "libtirpc gss support needs a toolchain w/ dynamic library"
> > > > +     depends on BR2_USE_MMU
> > > > +     depends on BR2_STATIC_LIBS
> > > > +     depends on BR2_PACKAGE_LIBTIRPC
> > > Shouldn't the last item depend on BR2_PACKAGE_LIBTIRPC_GSS?

> > I don't think so, then it would never be shown AFAIU.
> Looking into package/apcupsd/Config.in shows 1) comment should be just below
> config (problem also on previous patch) and 2) IMHO "depends on
> BR2_PACKAGE_LIBTIRPC" should not be there at all. Or am I missing something?
Yes, I was missing something :). "depends on BR2_PACKAGE_LIBTIRPC" is correct.
It works, not sure if 1) is relevant, thus sorry for confusion.

Kind regards,
Petr

> > > I'd also name it "libtirpc GSS support ..." (capitalize GSS)

> > I kept it lowercase for consistency with:
> > config BR2_PACKAGE_LIBTIRPC_GSS
> >       bool "gss"

> > Maybe we should change both?
> Well, probably better to keep it lowercase.
> I thought that first is identifier, other is abbreviation in the name,
> but again, looking into package/apcupsd/Config.in shows I$m wrong.

> Kind regards,
> Petr

> > > Kind regards,
> > > Petr
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot